Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-03 Thread Nicolae Brinza
> 1. Parser.y, line 2259: is "|| (block != NULL && block->isEmpty())" really > needed? Will block not always be null if a BlockExpr is {} (see > StatementsAndOptionalExpr nonterminal)? Nope, you can have a nested empty block {{}}. > 2. Why is the OBJECT token treated specially and not mentioned

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/html-module-bug-1189804 into lp:zorba/html-module

2013-09-03 Thread Zorba Build Bot
Validation queue succeeded - proposal merged! -- https://code.launchpad.net/~zorba-coders/zorba/html-module-bug-1189804/+merge/182529 Your team Zorba Coders is subscribed to branch lp:zorba/html-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/html-module-bug-1189804 into lp:zorba/html-module

2013-09-03 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/html-module-bug-1189804 into lp:zorba/html-module has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/html-module-bug-1189804/+merge/182529 -- https://code.launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189804 into lp:zorba

2013-09-03 Thread Zorba Build Bot
Validation queue succeeded - proposal merged! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189804/+merge/181973 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : htt

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189804 into lp:zorba

2013-09-03 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/bug-1189804 into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1189804/+merge/181973 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189804/+merge/181973 You

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189804 into lp:zorba

2013-09-03 Thread Zorba Build Bot
Validation queue starting for the following merge proposals: https://code.launchpad.net/~zorba-coders/zorba/bug-1189804/+merge/181973 https://code.launchpad.net/~zorba-coders/zorba/html-module-bug-1189804/+merge/182529 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https:/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/html-module-bug-1189804 into lp:zorba/html-module

2013-09-03 Thread Ghislain Fourny
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/html-module-bug-1189804/+merge/182529 Your team Zorba Coders is subscribed to branch lp:zorba/html-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https:/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-03 Thread Ghislain Fourny
Review: Needs Fixing Hi Nicolae, Looks good, thanks ;-) It's getting closer and closer to the git EBNFs! Here are some comments: 1. Parser.y, line 2259: is "|| (block != NULL && block->isEmpty())" really needed? Will block not always be null if a BlockExpr is {} (see StatementsAndOptionalExpr

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-03 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-cod

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-03 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Commit Message changed to: Parsers updates. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189806 into lp:zorba

2013-09-03 Thread Chris Hillery
Review: Needs Fixing Need to update error codes. eg, file:NOT_EXISTS instead of file:FOFL0001. Need a commit message for this proposal. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189806/+merge/183528 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://