The proposal to merge
lp:~zorba-coders/zorba/image-module-dont-pass-svg-as-binary into
lp:zorba/image-module has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merge/131829
--
https://code
Validation queue job
image-module-dont-pass-svg-as-binary-2012-11-13T16-03-35.963Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merge/131829
Your team Zorba Coders is subscribed to branch lp:zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/image-module-dont-pass-svg-as-binary-2012-11-13T16-03-35.963Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merge/131829
Your team Zorba Coders is s
The proposal to merge
lp:~zorba-coders/zorba/image-module-dont-pass-svg-as-binary into
lp:zorba/image-module has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merge/131829
--
https:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merge/131829
Your team Zorba Coders is subscribed to branch lp:zorba/image-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubsc
>
> On Nov 8, 2012, at 6:13 AM, David Graf wrote:
>
> >> - getImageFromString: const String aString, should be const String&
> aString,
> > Done
> >> - basic:convert-svg-impl should use basic:convert-svg-string
> > I don't understand. Currently, convert-svg-string invokes convert-svg-impl.
> How
On Nov 8, 2012, at 6:13 AM, David Graf wrote:
>> - getImageFromString: const String aString, should be const String& aString,
> Done
>> - basic:convert-svg-impl should use basic:convert-svg-string
> I don't understand. Currently, convert-svg-string invokes convert-svg-impl.
> How should that wo
> - getImageFromString: const String aString, should be const String& aString,
Done
> - basic:convert-svg-impl should use basic:convert-svg-string
I don't understand. Currently, convert-svg-string invokes convert-svg-impl. How
should that work the other way round?
>
> - we might have to make sure
Review: Needs Fixing
- getImageFromString: const String aString, should be const String& aString,
- basic:convert-svg-impl should use basic:convert-svg-string
- we might have to make sure the new module is used in Zorba (edit
ExternalModules.conf)
--
https://code.launchpad.net/~zorba-coders/zo
Matthias, is it ok for you now?
--
https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merge/131829
Your team Zorba Coders is subscribed to branch lp:zorba/image-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchp
Thanks Chris!
--
https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merge/131829
Your team Zorba Coders is subscribed to branch lp:zorba/image-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe
You need to change the version number in two places: The module .xq file
itself, and the DECLARE_ZORBA_MODULE() statement in CMakeLists.txt.
--
https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merge/131829
Your team Zorba Coders is subscribed to branch lp:zorba
Checkout the security modules for an example.
BTW: you need to increase the major version if the change is backwards
incompatible.
Matthias
On Oct 29, 2012, at 8:33 AM, David Graf wrote:
> Sorry for asking such a stupid question, but how can I increase the version?
> If I exchange 1.0 with 1
Sorry for asking such a stupid question, but how can I increase the version? If
I exchange 1.0 with 1.1., it doesn't work anymore:
:64,9:
Zorba error [zerr:ZXQP0008]:
"{http://www.zorba-xquery.com/modules/image/basic}width#1": function
implementation not found; raised at
/Users/dagraf/work/28m
Review: Needs Fixing
There is nothing wrong with making backwards compatible changes. However, if
such a change is done, the version of the module should be increased
accordingly.
--
https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merge/131829
Your team Zorb
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merge/131829
Your team Zorba Coders is subscribed to branch lp:zorba/image-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubsc
The proposal to merge
lp:~zorba-coders/zorba/image-module-dont-pass-svg-as-binary into
lp:zorba/image-module has been updated.
Commit Message changed to:
Passing the svg to the convert-svg function as a node or a string, instead of a
binary.
For more details, see:
https://code.launchpad.net/~
David Graf has proposed merging
lp:~zorba-coders/zorba/image-module-dont-pass-svg-as-binary into
lp:zorba/image-module.
Commit message:
Passing the svg to the convert-svg function as a node or a string, instead of a
binary.
Requested reviews:
Matthias Brantner (matthias-brantner)
For more d
I know, this change is not backwards compatible. But passing the svg as binary
just doesn't make sense to me! Especially because the first thing the module
did was transforming the binary back to string.
--
https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merg
19 matches
Mail list logo
