Review: Approve
Yes, we cannot JSONify the EXPath module. More than that, this processing
depends on XML data formats for which it doesn't make sense to do it on JSON
because the input data is XML and people want to process that.
A JSONiq geo module would be a completely separate effort. Right
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214
Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The proposal to merge lp:~zorba-coders/zorba/update3.0_geoproj-module into
lp:zorba/geoproj-module has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214
--
https://code.launchpad.net
Review: Needs Information
The changes as made seem fine. Two concerns:
1. Are there any errors raised by the module functions? If so, are they
documented?
2. Matthias: This seems like it is an ideal candidate for JSONify-ing; would
you agree? If so, what would you think is the priority? I'm
The changes as made seem fine. Two concerns:
1. Are there any errors raised by the module functions? If so, are they
documented?
No errors are thrown by the module.
2. Matthias: This seems like it is an ideal candidate for JSONify-ing; would
you agree? If so, what would you think is the
Review: Approve
Approving the changes as they are. Matthias, let us know if you think it should
JSONified immediately or if we can come back to it.
--
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214
Your team Zorba Coders is subscribed to branch
One note: we cannot JSONify the geo module [can we?], since it is an EXPath
module. There are no common APIs or schemas between geo and geoproj so far as I
know, but they might be used by similar people. So, might it be weird if one is
XML and one is JSON? Not really sure how to make that call.
Juan Zacarias has proposed merging
lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module.
Commit message:
Changes for Update 3.0
Requested reviews:
Chris Hillery (ceejatec)
Related bugs:
Bug #1188046 in Zorba: Update non-core module geoproj
9 matches
Mail list logo
