Review: Approve
Looks good - especially the name of the new source file :)
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The proposal to merge lp:~zorba-coders/zorba/bug-1039284 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-1039284-2012-10-22T19-38-54.354Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-1039284 into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
Review: Resubmit
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Hi Till,
Good point. I factored the function out.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe
Review: Approve
The function is not stable because it doesn't add the new document into the
store. However, I approve anyway because I don't think it's important for the
moment.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
Your team Zorba Coders is subscribed to
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/bug-1039284 into
lp:zorba.
Commit message:
Fixes bug 1039284 (json-doc).
Requested reviews:
Till Westmann (tillw)
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #1039284 in Zorba: Implement jn:json-doc()
The proposal to merge lp:~zorba-coders/zorba/bug-1039284 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-1039284-2012-10-15T16-56-53.572Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bug-1039284-2012-10-15T16-56-53.572Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-1039284 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge
Review: Needs Fixing
Looks good and works well.
The only thing that should be fixed is the normalizeInput function. Since the
same function is probably used for fn:doc, we should only have one
implementation of this.
I guess that runtime/util (or runtime/misc?) would be an appropriate
15 matches
Mail list logo