Looks very good, nice work. However, the moduleDocumentation test doesn't
pass, so there must be a typo somewhere in the XQDoc. Also, I suspect once you
fix that, it will complain that all those public variable declarations need to
have XQDoc; you'll probably need to restore the doc from the
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905
Your team Zorba Coders is subscribed to branch lp:zorba/system-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905
Your team Zorba
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905 :
Votes: {'Approve': 2, 'Needs commit message': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905
Your team Zorba Coders is subscribed
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905
Your team Zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1188058 into
lp:zorba/system-module has been updated.
Commit Message changed to:
Update non-core system module to Zorba 3.0 standards. Added
system:all-properties() function.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905
Stage CommitZorba failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/111/console to
view the results.
--
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905
Your team Zorba Coders is subscribed to branch lp:zorba/system-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
The proposal to merge lp:~zorba-coders/zorba/bug-1188058 into
lp:zorba/system-module has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188058
://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905
Your team Zorba Coders is requested to review the proposed merge of
lp:~zorba-coders/zorba/bug-1188058 into lp:zorba/system-module.
=== modified file 'src
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188058/+merge/178905
Your team Zorba Coders is subscribed to branch lp:zorba/system-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
Looks very good, nice work. However, the moduleDocumentation test doesn't pass,
so there must be a typo somewhere in the XQDoc. Also, I suspect once you fix
that, it will complain that all those public variable declarations need to have
XQDoc; you'll probably need to
12 matches
Mail list logo
