Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553
Your team Zorba Coders is subscribed to branch lp:zorba/stack-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
The proposal to merge lp:~zorba-coders/zorba/bug-1188061 into
lp:zorba/stack-module has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188061
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553
Your team Zorba Coders is subscribed to branch lp:zorba/stack-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553
Your team Zorba Coders is subscribed to branch lp:zorba/stack-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug-1188061 into
lp:zorba/stack-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553
--
https://code.launchpad.net/~zorba-coders/zorba/bug
The proposal to merge lp:~zorba-coders/zorba/bug-1188061 into
lp:zorba/stack-module has been updated.
Commit Message changed to:
Update to 3.0 module guidelines; make JSON-ready.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553
--
https
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553
Your team Zorba Coders is subscribed to branch lp:zorba/stack-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
Basically the same comments as the queue proposal:
1. Make the error QName variables %private;
2. Fix or eliminate the XQDoc for the error QNames;
3. Replace node with item in function XQDoc.
In addition:
4. You have a stray p at the beginning of the header XQDoc comment
After that, I'm afraid we've got some more substantive changes to be made to
JSON-ify this module. I'll update the bug with details. If you'd like, we
could merge this first pass (after you've addressed the coding guidelines
issues) and then have a separate proposal for the JSONiq updates;
The documentation has several mentions to tests that are included but no
textual representations are made, Should I move some of the examples to the
code instead of sending the user to check the tests?
Aside from that the documentation seems to be pretty straight forward and
all the errors that I
The documentation has several mentions to tests that are included but no
textual representations are made, Should I move some of the examples to the
code instead of sending the user to check the tests?
No, the @example tags are better. The examples will be included in the
documentation when
After that, I'm afraid we've got some more substantive changes to be made to
JSON-ify this module. I'll update the bug with details. If you'd like, we could
merge this first pass (after you've addressed the coding guidelines issues) and
then have a separate proposal for the JSONiq updates;
Luis - thanks for getting to this module so quickly. Based on this you've
raised some coding-guideline issues, such as the use of p/ and error codes.
After discussion with Matthias, I've proposed some clarifications to the coding
guidelines document on the Wiki; please take a look and update
Review: Needs Fixing
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553
Your team Zorba Coders is subscribed to branch lp:zorba/stack-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1188061
into lp:zorba/stack-module.
Requested reviews:
Luis Rodriguez Gonzalez (kuraru)
Chris Hillery (ceejatec)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553
--
Review: Needs Information
Looks pretty good so far! A couple questions for Matthias since he wrote the
style guide:
1. Is this the correct way to use p for splitting doc paragraphs - wrapping
them in p.../p ? Or should there be single p / elements between
paragraphs?
2. Is this the correct
Also, Luis: Have you done any investigation to ensure that the documentation is
reasonable? In particular is the header comment clear, clean, and possibly have
an example or two?
And, can you verify that all reasonably-possible error conditions are
documented? At least, are there any other
17 matches
Mail list logo
