Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1073091 into lp:zorba

2013-01-16 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1073091/+merge/139346 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1073091 into lp:zorba

2013-01-16 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/bug1073091 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1073091/+merge/139346 -- https://code.launchpad.net/~zorba-coders/zorba/bug1073091/+merge/139346

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1073091 into lp:zorba

2013-01-16 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug1073091-2013-01-16T22-49-54.921Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug1073091/+merge/139346 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1073091 into lp:zorba

2013-01-16 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/bug1073091 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1073091/+merge/139346 -- https://code.launchpad.net/~zorba-coders/zorba/bug1073091/+merge/139346 Your

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1073091 into lp:zorba

2013-01-11 Thread Chris Hillery
Review: Approve I changed the implementation slightly to use std::auto_ptr for memory-leak safety. If you could test to make sure I didn't break anything, I'd appreciate it. -- https://code.launchpad.net/~zorba-coders/zorba/bug1073091/+merge/139346 Your team Zorba Coders is subscribed to

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1073091 into lp:zorba

2013-01-08 Thread Juan Zacarias
I changed the implementation as you suggested. Unless I'm mistaken, there's no requirement that a fragment identifier must follow a forward-slash. The following is a valid URI with a fragment identifier: http://www.example.com/foobar#zot So the check for (lNormUri.at(found-1) == '/')

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1073091 into lp:zorba

2012-12-11 Thread Juan Zacarias
Juan Zacarias has proposed merging lp:~zorba-coders/zorba/bug1073091 into lp:zorba. Commit message: The function fn:unparsed-text-available now return false for fragment identifiers The functions fn:unparsed-text and fn:unparsed-text-lines now throw an error when trying to load a fragment

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1073091 into lp:zorba

2012-12-11 Thread Chris Hillery
Review: Needs Fixing Unless I'm mistaken, there's no requirement that a fragment identifier must follow a forward-slash. The following is a valid URI with a fragment identifier: http://www.example.com/foobar#zot So the check for (lNormUri.at(found-1) == '/') is incorrect. Also I think it