I looks ok to me too, but the real changes are in code that I don't really
understand much, so we have to trust Cezar on this. One thing though: the new
dtd_lax validation mode in include/zorba/static_context_consts.h must be
documented. The current comment there refers to XQUF spec, but the
Cezar Andrei has proposed merging lp:~zorba-coders/zorba/bug891209-xsiType into
lp:zorba.
Requested reviews:
Markos Zaharioudakis (markos-za)
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #891209 in Zorba: validation with xsi:type returns untyped
The proposal to merge lp:~zorba-coders/zorba/bug891209-xsiType into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/96248
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209
The proposal to merge lp:~zorba-coders/zorba/bug891209-xsiType into lp:zorba
has been updated.
Commit Message changed to:
Fix for bug 891209 : validation with xsi:type returns untyped.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/96248
Review: Approve
Unfortunately there is cleaner way to know when dtd validation is required,
this is the way to specify. I added a comment like Markos sugested.
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/96248
Your team Zorba Coders is subscribed to branch
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug891209-xsiType-2012-03-06T21-35-26.248Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/96248
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/96248
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue job bug891209-xsiType-2012-03-06T21-35-26.248Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/96248
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 3 Approve, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/96248
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/96248
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug891209-xsiType into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/96248
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209
Cezar Andrei has proposed merging lp:~zorba-coders/zorba/bug891209-xsiType into
lp:zorba.
Requested reviews:
Markos Zaharioudakis (markos-za)
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #891209 in Zorba: validation with xsi:type returns untyped
The proposal to merge lp:~zorba-coders/zorba/bug891209-xsiType into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/96001
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209
The proposal to merge lp:~zorba-coders/zorba/bug891209-xsiType into lp:zorba
has been updated.
Commit Message changed to:
Fix for bug 891209 : validation with xsi:type returns untyped.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/96001
Cezar Andrei has proposed merging lp:~zorba-coders/zorba/bug891209-xsiType into
lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
Markos Zaharioudakis (markos-za)
Related bugs:
Bug #891209 in Zorba: validation with xsi:type returns untyped
The proposal to merge lp:~zorba-coders/zorba/bug891209-xsiType into lp:zorba
has been updated.
Commit Message changed to:
Fix for bug 891209 : validation with xsi:type returns untyped.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/96003
Validation queue job bug891209-xsiType-2012-03-05T21-51-22.733Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/96003
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug891209-xsiType-2012-03-02T15-27-00.149Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/95487
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The attempt to merge lp:~zorba-coders/zorba/bug891209-xsiType into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job bug891209-xsiType-2012-03-02T15-27-00.149Z is
finished
The proposal to merge lp:~zorba-coders/zorba/bug891209-xsiType into lp:zorba
has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/95487
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209
Cezar Andrei has proposed merging lp:~zorba-coders/zorba/bug891209-xsiType into
lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #891209 in Zorba: validation with xsi:type returns untyped
https://bugs.launchpad.net/zorba/+bug/891209
For more details,
The proposal to merge lp:~zorba-coders/zorba/bug891209-xsiType into lp:zorba
has been updated.
Commit Message changed to:
Fix for bug 891209 : validation with xsi:type returns untyped.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/95476
The proposal to merge lp:~zorba-coders/zorba/bug891209-xsiType into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/95476
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209
There are additional revisions which have not been approved in review. Please
seek review and approval of these new revisions.
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/95476
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Looks good to me but I would feel more comfortable if Markos already took a
look at it.
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/95476
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/bug891209-xsiType
into lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
Markos Zaharioudakis (markos-za)
Related bugs:
Bug #891209 in Zorba: validation with xsi:type returns untyped
The proposal to merge lp:~zorba-coders/zorba/bug891209-xsiType into lp:zorba
has been updated.
Commit Message changed to:
Fix for bug 891209 : validation with xsi:type returns untyped.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/95487
The proposal to merge lp:~zorba-coders/zorba/bug891209-xsiType into lp:zorba
has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug891209-xsiType/+merge/95487
--
https://code.launchpad.net/~zorba-coders/zorba/bug891209
28 matches
Mail list logo
