Review: Approve
Yay for removing unnecessary CMake flags! Looks good.
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The proposal to merge lp:~zorba-coders/zorba/bug955040 into
lp:zorba/data-formatting-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug955040-2012-03-28T15-46-14.833Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
Validation queue job bug955040-2012-03-28T15-46-14.833Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug955040 into
lp:zorba/data-formatting-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
--
https://code.launchpad.net/~zorba-coders/zorba
The proposal to merge lp:~zorba-coders/zorba/bug955040 into
lp:zorba/data-formatting-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug955040-2012-03-28T16-53-23.343Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
Validation queue job bug955040-2012-03-28T16-53-23.343Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug955040 into
lp:zorba/data-formatting-module has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040
ZORBA_WITH_FOP flag has been eliminated...
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Review: Approve
Looks good.
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Sounds fine with me. So remove the ZORBA_WITH_FOP all together and work around
cmake bugs.
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
--
Mailing list:
Rodolfo Ochoa has proposed merging lp:~zorba-coders/zorba/bug955040 into
lp:zorba/data-formatting-module.
Requested reviews:
Matthias Brantner (matthias-brantner)
Cezar Andrei (cezar-andrei)
Related bugs:
Bug #955040 in Zorba: XSL-FO module test added even if module is not built
The proposal to merge lp:~zorba-coders/zorba/bug955040 into
lp:zorba/data-formatting-module has been updated.
Commit Message changed to:
Fixes on CMakeList to avoid submitting a test when module is not active.
Also added functionality to avoid testing for Java if module is not active.
For more
Review: Needs Fixing
1. ZORBA_WITH_FOP means I really want FOP. Ie if there is anything missing it's
an error.
So if ZORBA_WITH_FOP and ZORBA_SUPPRESS_JAVA are both true should be an error.
2. Why did you replace 1 IF with AND condition with 8 nested IF's ?
--
Review: Needs Fixing
I don't understand what ZORBA_WITH_FOP means at all. I'm not really a fan of
having flags to enable functionality anyway, at least not in non-core module
packages - if the user took the time to download the package, presumably they
want the contents, so why force them to
Review: Disapprove
Rodolfo, this changes need to go in data-formating branch not lp:zorba.
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98006
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Needs Fixing
This proposal should be targeted at lp:zorba/data-formatting-module, not
lp:zorba.
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98006
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post
18 matches
Mail list logo