Review: Approve
I've worked with Luis extensively over the past few days, and he has fixed all
the issues that have come up. These test cases now run valgrind clean.
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/zorba-for-sqlite into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
--
https://code.launchpad.net/~zorba-coders/zorba/zorba
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/zorba-for-sqlite into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
--
https://code.launchpad.net/~zorba-coders/zorba/zorba
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in ChangeLog
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The proposal to merge lp:~zorba-coders/zorba/zorba-for-sqlite into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
--
https://code.launchpad.net/~zorba-coders/zorba/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/zorba-for-sqlite-2013-01-10T00-02-39.557Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Validation queue job zorba-for-sqlite-2013-01-10T00-02-39.557Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/zorba-for-sqlite into lp:zorba has
been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite
A new SQLite module version is now uploaded. I fixed most of the problems but
I'm still testing out things.
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Needs Fixing
Code review comments:
1. Many of the functions are not marked %an:sequential. I believe all of them
should be.
2. s:disconnect() returns xs:anyURI, but the documentation says it returns
true if everything went OK. I suspect it should be xs:boolean.
See also the
Review: Needs Fixing
Oh, also a typo: the word prepated (instead of prepared) appears in the
XQDoc 6 times.
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
I believe there's a memory leak. valgrind reports a large block (around 73k) of
memory lost at line 847 in sqlite_module.cpp for most of the tests. This is the
call to sqlite3_open_v2(). After a little debugging, I see that sqlite3_close()
is being called in ConnMap::destroy(). However,
There are two memory errors when running the module tests, one in test9, one in
test6. I'm attaching the relevant parts of the valgrind report.
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Review: Needs Fixing
I've pushed a couple changes to get the module compiling on Linux. However,
several of the test cases fail for me with the error
http://www.zorba-xquery.com/modules/sqlite:SQLI library routine called out
of sequence.
I found this link regarding that error message:
Another problem is that you have hard-coded English error messages in a number
of places in C++ code, such as DB ID not recognized, SQL Statement is not
valid, and so on. I'm actually not sure how to handle this from a non-core
module; I'll send an email about it to the list.
--
Also, need to put something in the ChangeLog.
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe
The proposal to merge lp:~zorba-coders/zorba/zorba-for-sqlite into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
--
https://code.launchpad.net/~zorba-coders/zorba/zorba
The proposal to merge lp:~zorba-coders/zorba/zorba-for-sqlite into lp:zorba has
been updated.
Commit Message changed to:
Add SQLite module.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/zorba-for-sqlite-2012-12-19T09-53-00.358Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The attempt to merge lp:~zorba-coders/zorba/zorba-for-sqlite into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job zorba-for-sqlite-2012-12-19T09-53-00.358Z is finished
The proposal to merge lp:~zorba-coders/zorba/zorba-for-sqlite into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
--
https://code.launchpad.net/~zorba-coders/zorba/zorba
I fixed the problems Chris pointed out. Please review.
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Luis Rodriguez Gonzalez has proposed merging
lp:~zorba-coders/zorba/zorba-for-sqlite into lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
Chris Hillery (ceejatec)
Rodolfo Ochoa (rodolfo-ochoa)
For more details, see:
25 matches
Mail list logo