Review: Approve
I do have two minor points, but they're just about comments so I'll go ahead
and leave my Approve vote too.
First, one minor typo: ahe instead of the in regex.cpp.
Second, question about comment:
//
// The '=' is neither the first or last character within a
//
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Is there some context about '=' that I'm missing, or is that just a typo and
it should be '-'?
Typo.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
I re-voted to prevent this RQ run from succeeding, because it won't have Paul's
typo fixes in it. I'll re-start it in a bit.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 2 Approve, 1 Needs Fixing.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The attempt to merge lp:~zorba-coders/zorba/bug-1123161 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug-1123161-2013-02-23T14-57-54.588Z is finished. The
final
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The attempt to merge lp:~zorba-coders/zorba/bug-1123161 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug-1123161-2013-02-23T00-36-03.688Z is finished. The
final
The attempt to merge lp:~zorba-coders/zorba/bug-1123161 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug-1123161-2013-02-20T17-01-04.41Z is finished. The
final
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
More detailed commit message and Changelog entry, please.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
More detailed commit message and Changelog entry, please.
I'm not finished yet. It was just to see if I broke anything.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1123161/+merge/148773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
18 matches
Mail list logo
