Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
Review: Approve I was wrong. It FIXES the issue. -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/debugger_enhancements into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/debugger_enhancements/+merge/86801 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
The proposal to merge lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fix_bug_dc-2011-12-23T13-04-38.956Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
The attempt to merge lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:272 (message): Validation queue job fix_bug_dc-2011-12-23T13-04-38.956Z is finished. The final status was: Undetermined, probably an error - please email chill...@lambda.nu with the number of this job! Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
The proposal to merge lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
The proposal to merge lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fix_bug_dc-2011-12-23T13-08-35.284Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
The attempt to merge lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:272 (message): Validation queue job fix_bug_dc-2011-12-23T13-08-35.284Z is finished. The final status was: Undetermined, probably an error - please email chill...@lambda.nu with the number of this job! Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
The proposal to merge lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba
Daniel Turcanu has proposed merging lp:~danielturcanu/zorba/plan-serializer
into lp:zorba.
Requested reviews:
Zorba Coders (zorba-coders)
For more details, see:
https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807
Fixed memory leak in serialization of Diagnostic class.
--
https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807
Your team Zorba Coders is requested to review the proposed merge of
lp:~danielturcanu/zorba/plan-serializer into lp:zorba.
=== modified file 'src/zorbaserialization/zorba_class_serializer.cpp'
--- src/zorbaserialization/zorba_class_serializer.cpp 2011-09-30 14:06:33 +
+++ src/zorbaserialization/zorba_class_serializer.cpp 2011-12-23 14:18:26 +
@@ -1080,6 +1080,7 @@
ar local;
ar.set_is_temp_field(false);
obj = internal::SystemDiagnosticBase::find(local);
+free(local);
ZORBA_ASSERT(obj);
}
else
=== modified file 'test/rbkt/Queries/CMakeLists.txt'
--- test/rbkt/Queries/CMakeLists.txt 2011-12-22 20:34:53 +
+++ test/rbkt/Queries/CMakeLists.txt 2011-12-23 14:18:26 +
@@ -168,6 +168,11 @@
SET (SKIP_TEST 1)
ENDIF (NEEDS_FULL_TEXT)
ENDIF (ZORBA_NO_FULL_TEXT)
+ IF(WIN32)
+IF(${TESTNAME} MATCHES test/rbkt/zorba/versioning/link1)
+ SET(SKIP_TEST 1)
+ENDIF(${TESTNAME} MATCHES test/rbkt/zorba/versioning/link1)
+ ENDIF(WIN32)
# If WordNet thesaurus not found, skip ft-thesaurus-true tests
IF (NOT ZORBA_WORDNET_FOUND)
@@ -260,10 +265,12 @@
ENDIF(XVERMAJ EQUAL 2)
IF(WIN32)
- EXPECTED_FAILURE(test/rbkt/zorba/versioning/external1 870991)
- EXPECTED_FAILURE(test/rbkt/zorba/versioning/external2 870991)
+ #there tests now work on Windows
+ #EXPECTED_FAILURE(test/rbkt/zorba/versioning/external1 870991)
+ #EXPECTED_FAILURE(test/rbkt/zorba/versioning/external2 870991)
- EXPECTED_FAILURE(test/rbkt/zorba/versioning/link1 871061)
+ #disabled this test on WIN32
+ #EXPECTED_FAILURE(test/rbkt/zorba/versioning/link1 871061)
# this is still an expected failure but has been commented out since the
# test is now completely disabled because of bug 871335
=== modified file 'test/rbkt/modules/CMakeLists.txt'
--- test/rbkt/modules/CMakeLists.txt 2011-08-26 22:46:24 +
+++ test/rbkt/modules/CMakeLists.txt 2011-12-23 14:18:26 +
@@ -32,6 +32,7 @@
DECLARE_ZORBA_MODULE(URI http://www.zorba-xquery.com/modules/ext;
VERSION 1.0 FILE ext.xq TEST_ONLY)
+IF(NOT WIN32) #disable link + ourlib on Windows
ADD_SUBDIRECTORY(ourlib)
# For the moment, this test module depends on Xerces
@@ -39,6 +40,7 @@
DECLARE_ZORBA_MODULE(URI http://www.zorba-xquery.com/modules/link;
VERSION 1.0 LINK_LIBRARIES ourlib FILE link.xq TEST_ONLY)
ENDIF (NOT ZORBA_NO_XMLSCHEMA)
+ENDIF(NOT WIN32)
DECLARE_ZORBA_SCHEMA(URI http://www.zorba-xquery.com/modules/theschema;
FILE schema.xsd TEST_ONLY)
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/plan-serializer-2011-12-23T14-18-07.233Z/log.html -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba
Validation queue job plan-serializer-2011-12-23T14-18-07.233Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 1 Pending. -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba
The proposal to merge lp:~danielturcanu/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
Is there an example that works with streaming? I wasn't able to make the following work: import module namespace http = http://www.zorba-xquery.com/modules/http-client;; declare namespace h = http://expath.org/ns/http-client;; let $item := http:send-request(h:request href=https://stream.twitter.com/1/statuses/sample.json?delimited=length; method=GET username=wcandillon password=wnvbb86g override-media-type=text/plain / , https://stream.twitter.com/1/statuses/sample.json?delimited=length;, () )[2] for $tweet in tokenize($item,a) return $tweet Where: import module namespace http = http://www.zorba-xquery.com/modules/http-client;; declare namespace h = http://expath.org/ns/http-client;; let $item := http:send-request(h:request href=https://stream.twitter.com/1/statuses/sample.json?delimited=length; method=GET username=wcandillon password=wnvbb86g override-media-type=text/plain / , https://stream.twitter.com/1/statuses/sample.json?delimited=length;, () )[2] return $item streams fine. What am I missing? -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
As discussed in this thread, only the new tokenize function of the string module streams. Use the following instead import module namespace s = http://www.zorba-xquery.com/modules/string;; s:tokenize($item, a) -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~danielturcanu/zorba/plan-serializer into lp:zorba
Daniel, could you please commit the fix for the plan serializer separately from disabling the module test? Otherwise it will be hard for Chris to find out what you did. -- https://code.launchpad.net/~danielturcanu/zorba/plan-serializer/+merge/86807 Your team Zorba Coders is requested to review the proposed merge of lp:~danielturcanu/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 907070] Re: Item API needs operator
I like the suggestion. However, the function should probably be called emitStringValue in order to make it clear what the exact semantics is. ** Changed in: zorba Assignee: Matthias Brantner (matthias-brantner) = Paul J. Lucas (paul-lucas) -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/907070 Title: Item API needs operator Status in Zorba - The XQuery Processor: New Bug description: To emit the string value of an Item to an ostream, you currently have to use getStringValue() or getStringValue2(). This is inefficient since a string that is otherwise not needed needs to be created. Instead, there should be a global operator defined: std::ostream operator( std::ostream, store::Item const ); Its implementation could simply call a new protected, pure virtual member function for Item: virtual void emit( std::ostream ) const = 0; To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/907070/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zerr into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/zerr into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zerr/+merge/86609 -- https://code.launchpad.net/~zorba-coders/zorba/zerr/+merge/86609 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zerr into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/zerr-2011-12-23T19-16-03.574Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/zerr/+merge/86609 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
Review: Approve Works like a charm. -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/tokenize into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647 -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zerr into lp:zorba
Validation queue job zerr-2011-12-23T19-16-03.574Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/zerr/+merge/86609 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
Attempt to merge into lp:zorba failed due to conflicts: text conflict in ChangeLog -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/tokenize into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647 -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
Not sure why the conflicting tags problem only seems to have affected this merge proposal, but at any rate, I've fixed it on the remote queue machine and put code in to prevent it happening in future. -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
The proposal to merge lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fix_bug_dc-2011-12-23T20-23-35.246Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/tokenize into lp:zorba has been updated. Commit Message changed to: implementation of string:split function that doesn't accept regular expressions but allows for streamable processing of the input (resolves bug #898074) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829 -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
Validation queue job fix_bug_dc-2011-12-23T20-23-35.246Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module
The proposal to merge lp:~zorba-coders/zorba/fix_bug_dc into lp:zorba/data-cleaning-module has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_dc/+merge/86706 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
Review: Approve Works great. -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/tokenize into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829 -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/tokenize-2011-12-23T20-55-01.864Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/tokenize into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829 -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/tokenize-2011-12-23T21-25-57.422Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/tokenize into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:273 (message): Validation queue job tokenize-2011-12-23T21-25-57.422Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/tokenize into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829 -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/tokenize into
lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
Paul J. Lucas (paul-lucas)
William Candillon (wcandillon)
Related bugs:
Bug #898074 in Zorba: fn:tokenize() doesn't stream
https://bugs.launchpad.net/zorba/+bug/898074
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835
implementation of string:split function that doesn't accept regular expressions
but allows for streamable processing of the input (resolves bug #898074)
--
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'ChangeLog'
--- ChangeLog 2011-12-23 19:38:53 +
+++ ChangeLog 2011-12-23 21:56:35 +
@@ -12,6 +12,8 @@
set multiple times via the c++ api).
* Fixed bug #905050 (setting and getting the context item type via the c++ api)
* Added createDayTimeDuration, createYearMonthDuration, createDocumentNode, createCommentNode, createPiNode to api's ItemFactory.
+ * Added split function to the string module that allows for streamable tokenization but doesn't have regular expression
+support.
* zerr is not predeclared anymore to be http://www.zorba-xquery.com/errors
version 2.1
=== modified file 'modules/com/zorba-xquery/www/modules/CMakeLists.txt'
--- modules/com/zorba-xquery/www/modules/CMakeLists.txt 2011-12-21 14:40:33 +
+++ modules/com/zorba-xquery/www/modules/CMakeLists.txt 2011-12-23 21:56:35 +
@@ -58,7 +58,7 @@
URI http://www.zorba-xquery.com/modules/reflection;)
DECLARE_ZORBA_MODULE(FILE schema.xq VERSION 2.0
URI http://www.zorba-xquery.com/modules/schema;)
-DECLARE_ZORBA_MODULE(FILE string.xq VERSION 2.0
+DECLARE_ZORBA_MODULE(FILE string.xq VERSION 2.1
URI http://www.zorba-xquery.com/modules/string;)
DECLARE_ZORBA_MODULE(FILE xml.xq VERSION 2.0
URI http://www.zorba-xquery.com/modules/xml;)
=== modified file 'modules/com/zorba-xquery/www/modules/string.xq'
--- modules/com/zorba-xquery/www/modules/string.xq 2011-08-03 15:12:40 +
+++ modules/com/zorba-xquery/www/modules/string.xq 2011-12-23 21:56:35 +
@@ -25,7 +25,7 @@
:)
module namespace string = http://www.zorba-xquery.com/modules/string;;
declare namespace ver = http://www.zorba-xquery.com/options/versioning;;
-declare option ver:module-version 2.0;
+declare option ver:module-version 2.1;
(:~
: This function materializes a streamable string.
@@ -63,3 +63,23 @@
:
:)
declare function string:is-streamable($s as xs:string) as xs:boolean external;
+
+(:~
+ : Returns a sequence of strings constructed by splitting the input wherever the given
+ : separator is found.
+ :
+ : The function is different from fn:tokenize. It doesn't allow
+ : the separator to be a regular expression. This restriction allows for more
+ : performant implementation. Specifically, the function processes
+ : streamable strings as input in a streamable way which is particularly useful
+ : to tokenize huge strings (e.g. if returned by the file module's read-text
+ : function).
+ :
+ : @param $s the input string to split
+ : @param $separator the separator used for splitting the input string $s
+ :
+ : @return a sequence of strings constructed by splitting the input
+ :)
+declare function string:split(
+ $s as xs:string,
+ $separator as xs:string) as xs:string* external;
=== modified file 'src/functions/pregenerated/func_strings.cpp'
--- src/functions/pregenerated/func_strings.cpp 2011-12-21 14:40:33 +
+++ src/functions/pregenerated/func_strings.cpp 2011-12-23 21:56:35 +
@@ -320,6 +320,16 @@
return new StringIsStreamableIterator(sctx, loc, argv);
}
+PlanIter_t fn_zorba_string_split::codegen(
+ CompilerCB*,
+ static_context* sctx,
+ const QueryLoc loc,
+ std::vectorPlanIter_t argv,
+ AnnotationHolder ann) const
+{
+ return new StringSplitIterator(sctx, loc, argv);
+}
+
void populate_context_strings(static_context* sctx)
{
{
@@ -890,6 +900,19 @@
}
+
+ {
+
+
+DECL_WITH_KIND(sctx, fn_zorba_string_split,
+(createQName(http://www.zorba-xquery.com/modules/string,,split;),
+GENV_TYPESYSTEM.STRING_TYPE_ONE,
+GENV_TYPESYSTEM.STRING_TYPE_ONE,
+GENV_TYPESYSTEM.STRING_TYPE_STAR),
+FunctionConsts::FN_ZORBA_STRING_SPLIT_2);
+
+ }
+
}
=== modified file 'src/functions/pregenerated/func_strings.h'
--- src/functions/pregenerated/func_strings.h 2011-12-22 14:14:53 +
+++ src/functions/pregenerated/func_strings.h 2011-12-23 21:56:35 +
@@ -481,6 +481,21 @@
};
+//fn-zorba-string:split
+class fn_zorba_string_split : public function
+{
+public:
+ fn_zorba_string_split(const signature sig, FunctionConsts::FunctionKind kind)
+:
+function(sig, kind)
+ {
+
+ }
+
+ CODEGEN_DECL();
+};
+
+
} //namespace zorba
=== modified file 'src/functions/pregenerated/function_enum.h'
--- src/functions/pregenerated/function_enum.h
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/tokenize into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835 -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/tokenize into lp:zorba has been updated. Commit Message changed to: implementation of string:split function that doesn't accept regular expressions but allows for streamable processing of the input (resolves bug #898074) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835 -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/tokenize into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835 -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/tokenize into
lp:zorba.
Requested reviews:
Paul J. Lucas (paul-lucas)
Matthias Brantner (matthias-brantner)
William Candillon (wcandillon)
Related bugs:
Bug #898074 in Zorba: fn:tokenize() doesn't stream
https://bugs.launchpad.net/zorba/+bug/898074
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86840
implementation of string:split function that doesn't accept regular expressions
but allows for streamable processing of the input (resolves bug #898074)
--
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86840
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'ChangeLog'
--- ChangeLog 2011-12-23 19:38:53 +
+++ ChangeLog 2011-12-23 22:04:30 +
@@ -12,6 +12,8 @@
set multiple times via the c++ api).
* Fixed bug #905050 (setting and getting the context item type via the c++ api)
* Added createDayTimeDuration, createYearMonthDuration, createDocumentNode, createCommentNode, createPiNode to api's ItemFactory.
+ * Added split function to the string module that allows for streamable tokenization but doesn't have regular expression
+support.
* zerr is not predeclared anymore to be http://www.zorba-xquery.com/errors
version 2.1
=== modified file 'modules/com/zorba-xquery/www/modules/CMakeLists.txt'
--- modules/com/zorba-xquery/www/modules/CMakeLists.txt 2011-12-21 14:40:33 +
+++ modules/com/zorba-xquery/www/modules/CMakeLists.txt 2011-12-23 22:04:30 +
@@ -58,7 +58,7 @@
URI http://www.zorba-xquery.com/modules/reflection;)
DECLARE_ZORBA_MODULE(FILE schema.xq VERSION 2.0
URI http://www.zorba-xquery.com/modules/schema;)
-DECLARE_ZORBA_MODULE(FILE string.xq VERSION 2.0
+DECLARE_ZORBA_MODULE(FILE string.xq VERSION 2.1
URI http://www.zorba-xquery.com/modules/string;)
DECLARE_ZORBA_MODULE(FILE xml.xq VERSION 2.0
URI http://www.zorba-xquery.com/modules/xml;)
=== modified file 'modules/com/zorba-xquery/www/modules/string.xq'
--- modules/com/zorba-xquery/www/modules/string.xq 2011-08-03 15:12:40 +
+++ modules/com/zorba-xquery/www/modules/string.xq 2011-12-23 22:04:30 +
@@ -25,7 +25,7 @@
:)
module namespace string = http://www.zorba-xquery.com/modules/string;;
declare namespace ver = http://www.zorba-xquery.com/options/versioning;;
-declare option ver:module-version 2.0;
+declare option ver:module-version 2.1;
(:~
: This function materializes a streamable string.
@@ -63,3 +63,23 @@
:
:)
declare function string:is-streamable($s as xs:string) as xs:boolean external;
+
+(:~
+ : Returns a sequence of strings constructed by splitting the input wherever the given
+ : separator is found.
+ :
+ : The function is different from fn:tokenize. It doesn't allow
+ : the separator to be a regular expression. This restriction allows for more
+ : performant implementation. Specifically, the function processes
+ : streamable strings as input in a streamable way which is particularly useful
+ : to tokenize huge strings (e.g. if returned by the file module's read-text
+ : function).
+ :
+ : @param $s the input string to split
+ : @param $separator the separator used for splitting the input string $s
+ :
+ : @return a sequence of strings constructed by splitting the input
+ :)
+declare function string:split(
+ $s as xs:string,
+ $separator as xs:string) as xs:string* external;
=== modified file 'src/functions/pregenerated/func_strings.cpp'
--- src/functions/pregenerated/func_strings.cpp 2011-12-21 14:40:33 +
+++ src/functions/pregenerated/func_strings.cpp 2011-12-23 22:04:30 +
@@ -320,6 +320,16 @@
return new StringIsStreamableIterator(sctx, loc, argv);
}
+PlanIter_t fn_zorba_string_split::codegen(
+ CompilerCB*,
+ static_context* sctx,
+ const QueryLoc loc,
+ std::vectorPlanIter_t argv,
+ AnnotationHolder ann) const
+{
+ return new StringSplitIterator(sctx, loc, argv);
+}
+
void populate_context_strings(static_context* sctx)
{
{
@@ -890,6 +900,19 @@
}
+
+ {
+
+
+DECL_WITH_KIND(sctx, fn_zorba_string_split,
+(createQName(http://www.zorba-xquery.com/modules/string,,split;),
+GENV_TYPESYSTEM.STRING_TYPE_ONE,
+GENV_TYPESYSTEM.STRING_TYPE_ONE,
+GENV_TYPESYSTEM.STRING_TYPE_STAR),
+FunctionConsts::FN_ZORBA_STRING_SPLIT_2);
+
+ }
+
}
=== modified file 'src/functions/pregenerated/func_strings.h'
--- src/functions/pregenerated/func_strings.h 2011-12-22 14:14:53 +
+++ src/functions/pregenerated/func_strings.h 2011-12-23 22:04:30 +
@@ -481,6 +481,21 @@
};
+//fn-zorba-string:split
+class fn_zorba_string_split : public function
+{
+public:
+ fn_zorba_string_split(const signature sig, FunctionConsts::FunctionKind kind)
+:
+function(sig, kind)
+ {
+
+ }
+
+ CODEGEN_DECL();
+};
+
+
} //namespace zorba
=== modified file 'src/functions/pregenerated/function_enum.h'
--- src/functions/pregenerated/function_enum.h
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/tokenize into lp:zorba has been updated. Commit Message changed to: implementation of string:split function that doesn't accept regular expressions but allows for streamable processing of the input (resolves bug #898074) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86840 -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86840 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/tokenize into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86840 -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86840 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/tokenize-2011-12-23T22-04-07.45Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86840 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 3 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86840 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/tokenize into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86840 -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86840 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
