Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1047547 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1047547/+merge/123396 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1047547 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1047547 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1047547/+merge/123396 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1047547/+merge/123396 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1047547 into lp:zorba
Attempt to merge into lp:zorba failed due to conflicts: text conflict in ChangeLog -- https://code.launchpad.net/~zorba-coders/zorba/bug-1047547/+merge/123396 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-mem_size into lp:zorba
Why does ztd::alloc_sizeof( theKeys ) in src/store/naive/json_items.cpp:245 return 0? Because a specialization for HashMap wasn't ever defined. I really wish we'd get away from using our own non-standard hashmaps. There really is no point. -- https://code.launchpad.net/~zorba-coders/zorba/feature-mem_size/+merge/114764 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1047547 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1047547 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1047547/+merge/123396 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1047547/+merge/123396 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1047547 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1047547-2012-09-11T15-10-43.456Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1047547/+merge/123396 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1047547 into lp:zorba
Validation queue job bug-1047547-2012-09-11T15-10-43.456Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1047547/+merge/123396 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1047547 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1047547 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1047547/+merge/123396 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1047547/+merge/123396 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-1046415 into lp:zorba
Review: Needs Information
- Is the empty string a valid name? Should we raise an error if the name of a
pair is an empty string? Currently, the following query works fine: { :
1}()
- What should happen if the key expression evaluates to null. Currently, the
following query returns 1; { null : 1 }(null) (see test
jsoniq/obj_constr_12.xq).
- I would like to get Paul's opinion on the error message. Maybe it can be made
a bit more crisp without loosing information.
- I think the feature deserves more tests. I have committed a bunch into the
branch.
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1046411 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1046411/+merge/123654 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1046411 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1046411 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1046411/+merge/123654 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1046411/+merge/123654 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1046411 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1046411-2012-09-11T16-04-36.756Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1046411/+merge/123654 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1046411 into lp:zorba
Validation queue job bug-1046411-2012-09-11T16-04-36.756Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1046411/+merge/123654 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1046411 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1046411 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1046411/+merge/123654 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1046411/+merge/123654 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/pjl-misc into lp:zorba. Requested reviews: Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/123802 Fixed pragma warning. -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/123802 Your team Zorba Coders is subscribed to branch lp:zorba. === modified file 'src/runtime/full_text/ft_module_impl.cpp' --- src/runtime/full_text/ft_module_impl.cpp 2012-09-10 22:53:04 + +++ src/runtime/full_text/ft_module_impl.cpp 2012-09-11 18:03:26 + @@ -508,6 +508,7 @@ # ifdef GCC_PRAGMA_DIAGNOSTIC_PUSH # pragma GCC diagnostic push # endif /* GCC_PRAGMA_DIAGNOSTIC_PUSH */ +# pragma GCC diagnostic ignored -Wunknown-pragmas # pragma GCC diagnostic ignored -Wpragmas # pragma GCC diagnostic ignored -Wbind-to-temporary-copy #endif /* __GNUC__ */ @@ -609,6 +610,7 @@ # pragma GCC diagnostic pop #else # pragma GCC diagnostic warning -Wbind-to-temporary-copy +# pragma GCC diagnostic warning -Wunknown-pragmas # pragma GCC diagnostic warning -Wpragmas #endif /* GCC_PRAGMA_DIAGNOSTIC_PUSH */ -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/123802 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/123802 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/123802 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2012-09-11T18-11-38.544Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/123802 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue job pjl-misc-2012-09-11T18-11-38.544Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/123802 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/123802 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/123802 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bang_operator into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bang_operator into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bang_operator/+merge/121347 -- https://code.launchpad.net/~zorba-coders/zorba/bang_operator/+merge/121347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bang_operator into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bang_operator-2012-09-11T23-04-10.294Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bang_operator/+merge/121347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-950621 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-950621/+merge/123655 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-950621 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-950621 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-950621/+merge/123655 -- https://code.launchpad.net/~zorba-coders/zorba/bug-950621/+merge/123655 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-1046415 into lp:zorba
As far as I can make out, an empty string is a valid key for an object. jsonlint.com at least agrees. null is not a valid key, and we should raise an error if such a case arises. Also, the fact that using the *string* null as an accessor worked in that case frightens me. -- https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba
Review: Needs Fixing More modules need changing, coming soon. -- https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-1046415 into lp:zorba
As far as I can make out, an empty string is a valid key for an object. jsonlint.com at least agrees. Fair enough. null is not a valid key, and we should raise an error if such a case arises. Also, the fact that using the *string* null as an accessor worked in that case frightens me. According to what we said, null is cast to a string. That's why the accessor works. I don't see anything being particularly wrong with that. I just wanted to raise it to make sure we are all on the same page. Matthias -- https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba
Review: Approve Should be all done now. -- https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185 -- https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bugs-1022495-and-1022494-2012-09-12T04-38-44.886Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-1022495-and-1022494 into lp:zorba
Validation queue job bugs-1022495-and-1022494-2012-09-12T04-38-44.886Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bugs-1022495-and-1022494/+merge/114185 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
