[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Markos Zaharioudakis]

Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch 
into lp:zorba.

Commit message:
Fixed bug #1043294 (XQST0036 not used in XQuery 3.0).
Partial fixes for bug #867008.

Requested reviews:
  Markos Zaharioudakis (markos-za)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262

Fixed bug #1043294 (XQST0036 not used in XQuery 3.0).
Partial fixes for bug #867008
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
Your team Zorba Coders is subscribed to branch lp:zorba.
-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Markos Zaharioudakis]

Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Markos Zaharioudakis]

The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has 
been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Zorba Build Bot]

Attempt to merge into lp:zorba failed due to conflicts: 

text conflict in ChangeLog
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Zorba Build Bot]

The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has 
been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Markos Zaharioudakis]

The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has 
been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Zorba Build Bot]

Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2013-01-08T09-08-51.485Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Zorba Build Bot]

The attempt to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job markos-scratch-2013-01-08T09-08-51.485Z is finished.
  The final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Zorba Build Bot]

The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has 
been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-reference_module into lp:zorba

[William Candillon]

We agreed with Ghislain to use xs:string.
Regarding dereference(), for which scenario should it throw an exception?
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-reference_module/+merge/138345
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Zorba Build Bot]

Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2013-01-08T11-46-54.981Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Markos Zaharioudakis]

The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has 
been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Zorba Build Bot]

Validation queue job markos-scratch-2013-01-08T11-46-54.981Z is finished. The 
final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[noreply]

The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has 
been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142262
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Markos Zaharioudakis]

Markos Zaharioudakis has proposed merging lp:~zorba-coders/zorba/markos-scratch 
into lp:zorba.

Commit message:
fixed bug #1097101

Requested reviews:
  Markos Zaharioudakis (markos-za)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142307

fixed bug #1097101
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142307
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/types/root_typemanager.cpp'
--- src/types/root_typemanager.cpp	2012-12-18 15:57:51 +
+++ src/types/root_typemanager.cpp	2013-01-08 13:00:33 +
@@ -384,17 +384,20 @@
   XS_NMTOKENS_TYPE = new UserDefinedXQType(this,
XS_NMTOKENS_QNAME,
NULL,
-   NMTOKEN_TYPE_ONE.getp());
+   NMTOKEN_TYPE_ONE.getp(),
+   true);
 
   XS_ENTITIES_TYPE = new UserDefinedXQType(this,
XS_ENTITIES_QNAME,
NULL,
-   ENTITY_TYPE_ONE.getp());
+   ENTITY_TYPE_ONE.getp(),
+   true);
 
   XS_IDREFS_TYPE = new UserDefinedXQType(this,
  XS_IDREFS_QNAME,
  NULL,
- IDREF_TYPE_ONE.getp());
+ IDREF_TYPE_ONE.getp(),
+ true);
 
   STRUCTURED_ITEM_TYPE_ONE = 
   new StructuredItemXQType(this, TypeConstants::QUANT_ONE, true);
@@ -577,6 +580,14 @@
   DELETE_TYPE(ANY_NODE)
   DELETE_TYPE(STRUCTURED_ITEM)
 
+  // These must be deallocated first because they may reference other types
+  delete XS_NMTOKENS_TYPE.getp();
+  XS_NMTOKENS_TYPE.setNull();
+  delete XS_ENTITIES_TYPE.getp();
+  XS_ENTITIES_TYPE.setNull();
+  delete XS_IDREFS_TYPE.getp();
+  XS_IDREFS_TYPE.setNull();
+
 #ifdef ZORBA_WITH_JSON
   DELETE_TYPE(JS_NULL)
 

=== modified file 'src/types/typeimpl.cpp'
--- src/types/typeimpl.cpp	2013-01-08 11:07:41 +
+++ src/types/typeimpl.cpp	2013-01-08 13:00:33 +
@@ -1113,9 +1113,10 @@
 const xqtref_t& baseType,
 TypeConstants::quantifier_t quantifier,
 type_category_t typeCategory,
-content_kind_t contentKind)
+content_kind_t contentKind,
+bool builtin)
   :
-  XQType(manager, USER_DEFINED_KIND, quantifier, false),
+  XQType(manager, USER_DEFINED_KIND, quantifier, builtin),
   m_qname(qname),
   m_baseType(baseType),
   m_typeCategory(typeCategory),
@@ -1139,9 +1140,10 @@
 const TypeManager* manager,
 store::Item_t qname,
 const xqtref_t& baseType,
-const XQType* listItemType)
+const XQType* listItemType,
+bool builtin)
   :
-  XQType(manager, USER_DEFINED_KIND, TypeConstants::QUANT_STAR, false),
+  XQType(manager, USER_DEFINED_KIND, TypeConstants::QUANT_STAR, builtin),
   m_qname(qname),
   m_baseType(baseType),
   m_typeCategory(LIST_TYPE),
@@ -1160,9 +1162,10 @@
 store::Item_t qname,
 const xqtref_t& baseType,
 TypeConstants::quantifier_t quantifier,
-const std::vector& unionItemTypes)
+const std::vector& unionItemTypes,
+bool builtin)
   :
-  XQType(manager, USER_DEFINED_KIND, quantifier, false),
+  XQType(manager, USER_DEFINED_KIND, quantifier, builtin),
   m_qname(qname),
   m_baseType(baseType),
   m_typeCategory(UNION_TYPE),

=== modified file 'src/types/typeimpl.h'
--- src/types/typeimpl.h	2012-12-28 10:24:59 +
+++ src/types/typeimpl.h	2013-01-08 13:00:33 +
@@ -739,14 +739,16 @@
   const xqtref_t& baseType,
   TypeConstants::quantifier_t quantifier,
   type_category_t typeCategory,
-  content_kind_t contentKind);
+  content_kind_t contentKind,
+  bool builtin = false);
 
   // Constructor for List types
   UserDefinedXQType(
   const TypeManager* manager,
   store::Item_t qname,
   const xqtref_t& baseType,
-  const XQType* listItemType);
+  const XQType* listItemType,
+  bool builtin = false);
 
   // Constructor for Union types
   UserDefinedXQType(
@@ -754,7 +756,8 @@
   store::Item_t qname,
   const xqtref_t& baseType,
   TypeConstants::quantifier_t quantifier,
-  const std::vector& unionItemTypes);
+  const std::vector& unionItemTypes,
+  bool builtin = false);
 
   virtual ~UserDefinedXQType() {}
 

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Markos Zaharioudakis]

The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has 
been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142307
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142307
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Markos Zaharioudakis]

Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142307
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Zorba Build Bot]

Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2013-01-08T13-03-49.859Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142307
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-reference_module into lp:zorba

[Ghislain Fourny]

Hi Matthias,

For ref:dereference's not throwing any error, I am not sure I understand your 
comment - looking at the code, it seems to not differentiate between nodes, 
objects and arrays. I have the feeling it is only about removing the if 
statement that throws the error in SimpleStore::getNodeByReference, is it not?


-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-reference_module/+merge/138345
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[Zorba Build Bot]

Validation queue job markos-scratch-2013-01-08T13-03-49.859Z is finished. The 
final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142307
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba

[noreply]

The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has 
been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142307
-- 
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/142307
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

[Nicolae Brinza]

The proposal to merge lp:~nbrinza/zorba/error-messages into lp:zorba has been 
updated.

Commit Message changed to:

Fixed #1072644: broken error location

For more details, see:
https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/142317
-- 
https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/142317
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

[Nicolae Brinza]

The proposal to merge lp:~nbrinza/zorba/error-messages into lp:zorba has been 
updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/142317
-- 
https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/142317
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

[Zorba Build Bot]

Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/error-messages-2013-01-08T13-56-08.244Z/log.html
-- 
https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/142317
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

[Zorba Build Bot]

Validation queue job error-messages-2013-01-08T13-56-08.244Z is finished. The 
final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/142317
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

[Zorba Build Bot]

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, 
Needs Fixing < 1, Pending < 1. Got: 1 Pending.
-- 
https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/142317
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

[Zorba Build Bot]

The proposal to merge lp:~nbrinza/zorba/error-messages into lp:zorba has been 
updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/142317
-- 
https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/142317
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-reference_module into lp:zorba

[Matthias Brantner]

> Hi Matthias,
> 
> For ref:dereference's not throwing any error, I am not sure I understand your
> comment - looking at the code, it seems to not differentiate between nodes,
> objects and arrays. I have the feeling it is only about removing the if
> statement that throws the error in SimpleStore::getNodeByReference, is it not?
Maybe we need to talk about it. The problem is that the code is shared with
the old module (see 
http://www.zorba-xquery.com/html/modules/zorba/xdm/node/node-reference).
-- 
https://code.launchpad.net/~zorba-coders/zorba/feature-reference_module/+merge/138345
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba

[Juan Zacarias]

Juan Zacarias has proposed merging 
lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba.

Commit message:
Added canonicalize function to the core xml module

Requested reviews:
  Luis Rodriguez Gonzalez (kuraru)
  Matthias Brantner (matthias-brantner)
Related bugs:
  Bug #1076919 in Zorba: "Need function to canonicalize XML"
  https://bugs.launchpad.net/zorba/+bug/1076919

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394

Added canonicalize function to the core xml module
-- 
https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'ChangeLog'
--- ChangeLog	2013-01-08 09:03:49 +
+++ ChangeLog	2013-01-08 20:13:28 +
@@ -13,6 +13,7 @@
 	natural language text.
   * Extended cast and castable expression to allow any simple target type
 (as specified by XQuery 3.0)
+  * Added canonicalize function to modules/xml.
 
 Optimizations:
   * Various optimizations in the implementation of the optimizer rules.

=== modified file 'include/zorba/pregenerated/diagnostic_list.h'
--- include/zorba/pregenerated/diagnostic_list.h	2013-01-08 08:34:08 +
+++ include/zorba/pregenerated/diagnostic_list.h	2013-01-08 20:13:28 +
@@ -298,6 +298,8 @@
 
 extern ZORBA_DLL_PUBLIC XQueryErrorCode FOUT1190;
 
+extern ZORBA_DLL_PUBLIC XQueryErrorCode FOCZ0001;
+
 extern ZORBA_DLL_PUBLIC XQueryErrorCode XUST0001;
 
 extern ZORBA_DLL_PUBLIC XQueryErrorCode XUST0002;

=== modified file 'modules/com/zorba-xquery/www/modules/xml.xq'
--- modules/com/zorba-xquery/www/modules/xml.xq	2012-09-19 21:16:15 +
+++ modules/com/zorba-xquery/www/modules/xml.xq	2013-01-08 20:13:28 +
@@ -30,9 +30,9 @@
  : them in a streaming fashion - each at a time:
  :
  : 
- : import module namespace parse-xml = "http://www.zorba-xquery.com/modules/xml";;
+ : import module namespace x = "http://www.zorba-xquery.com/modules/xml";;
  : import schema namespace opt = "http://www.zorba-xquery.com/modules/xml-options";;
- : parse-xml:parse( 
+ : x:parse( 
  :   "JaniJaniJani",
  :   
  : 
@@ -44,9 +44,9 @@
  : before returning a sequence of nodes as shown in the following example:
  :
  : 
- : import module namespace parse-xml = "http://www.zorba-xquery.com/modules/xml";;
+ : import module namespace x = "http://www.zorba-xquery.com/modules/xml";;
  : import schema namespace opt = "http://www.zorba-xquery.com/modules/xml-options";;
- : parse-xml:parse(
+ : x:parse(
  :   "
  : Jani1
  : Jani2
@@ -68,7 +68,7 @@
  : @project data processing/data converters
  :
  :)
-module namespace parse-xml = "http://www.zorba-xquery.com/modules/xml";;
+module namespace x = "http://www.zorba-xquery.com/modules/xml";;
 
 import schema namespace parse-xml-options = "http://www.zorba-xquery.com/modules/xml-options";;
 
@@ -193,9 +193,9 @@
  : An example that sets the base-uri of the parsed external entities:
  : 
  : 
- :   import module namespace parse-xml = "http://www.zorba-xquery.com/modules/xml";;
+ :   import module namespace x = "http://www.zorba-xquery.com/modules/xml";;
  :   import schema namespace opt = "http://www.zorba-xquery.com/modules/xml-options";;
- :   parse-xml:parse("JaniJaniJani",
+ :   x:parse("JaniJaniJani",
  : 
  :   
  :   
@@ -228,7 +228,7 @@
  : @example test/rbkt/Queries/zorba/parsing_and_serializing/parse-xml-fragment-07.xq
  :
  :)
-declare function parse-xml:parse(
+declare function x:parse(
   $xml-string as xs:string?,
   $options as element(parse-xml-options:options)?) as node()* external;
   
@@ -236,7 +236,7 @@
 (:~
  : 
  : Note: this function is included for backwards compatibility purposes. It 
- : is recommended that you use the parse-xml:parse() function instead.
+ : is recommended that you use the x:parse() function instead.
  : 
  :
  : A function to parse XML files and fragments (i.e. 
@@ -330,7 +330,7 @@
  : @deprecated
  :
  :)
-declare function parse-xml:parse-xml-fragment(
+declare function x:parse-xml-fragment(
   $xml-string as xs:string?,
   $options as xs:string) as node()* 
 {
@@ -352,14 +352,14 @@
 then  else ()  
 }
   return
-parse-xml:parse($xml-string, $new_options)
+x:parse($xml-string, $new_options)
 };
 
 
 (:~
  : 
  : Note: this function is included for backwards compatibility purposes. It 
- : is recommended that you use the parse-xml:parse() function instead.
+ : is recommended that you use the x:parse() function instead.
  : 
  :
  : A function to parse XML files and fragments. The behavior is the
@@ -390,7 +390,7 @@
  : @deprecated
  :
  :)
-declare function parse-xml:parse-xml-fragment(
+decla

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba

[Juan Zacarias]

Sorry I had to remove the previous branch proposed for merge because of to much 
of a mess between merges that it seemed some data was lost.

This branch contains all the changes Matthias previously mentioned

including the two last

Fixed the lost of changes made because of wrong merge with trunk
Added more comments to the function, not sure what else to add if the function 
needs more description.
-- 
https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba

[Luis Rodriguez Gonzalez]

Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1096718 into lp:zorba

[Rodolfo Ochoa]

Rodolfo Ochoa has proposed merging lp:~zorba-coders/zorba/bug1096718 into 
lp:zorba.

Commit message:
fix for warnings

Requested reviews:
  Matthias Brantner (matthias-brantner)
  Paul J. Lucas (paul-lucas)
Related bugs:
  Bug #1096717 in Zorba: "extra tokens at end of #endif"
  https://bugs.launchpad.net/zorba/+bug/1096717
  Bug #1096718 in Zorba: "conversion from string literal to 'char *' is 
deprecated"
  https://bugs.launchpad.net/zorba/+bug/1096718

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1096718/+merge/142407

fix for warnings
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1096718/+merge/142407
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/context/root_static_context.cpp'
--- src/context/root_static_context.cpp	2013-01-08 08:34:08 +
+++ src/context/root_static_context.cpp	2013-01-08 21:17:26 +
@@ -94,8 +94,9 @@
   }
 }
 #else
-  static void append_env_var(
-  char * env_var_name,
+  static void append_env_var
+(
+  const char * env_var_name,
   std::vector& pathsVector
   )
 {

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1096718 into lp:zorba

[Rodolfo Ochoa]

The proposal to merge lp:~zorba-coders/zorba/bug1096718 into lp:zorba has been 
updated.

Commit Message changed to:

fix for warnings

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1096718/+merge/142407
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1096718/+merge/142407
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1096718 into lp:zorba

[Rodolfo Ochoa]

don't know why Launchpad doesn't show all the differences, but it also has:
36:   #endif //WIN32
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1096718/+merge/142407
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1073091 into lp:zorba

[Juan Zacarias]

I changed the implementation as you suggested.

> Unless I'm mistaken, there's no requirement that a fragment identifier must
> follow a forward-slash. The following is a valid URI with a fragment
> identifier:
> 
>   http://www.example.com/foobar#zot
> 
> So the check for (lNormUri.at(found-1) == '/') is incorrect. Also I think it
> might cause a crash if the URI is the string "#" (which is probably not valid
> anyway, but still we shouldn't crash).
> 
> More generally: I just spent a while reading RFC 3986 to see whether a simple
> character-search for '#' was sufficient to identify a fragment, when it
> occurred to me that I shouldn't be trying to answer that question manually. I
> think a better solution here would be to construct a zorba::URI object
> (src/zorbatypes/URI.h) from lNormUri and then call get_encoded_fragment() on
> it to see if there is any fragment. I don't like introducing that much
> overhead to perform this function, but parsing URIs is tricky and IMHO it
> makes sense to consolidate all of that functionality in a single place, namely
> the URI class.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1073091/+merge/139346
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba

[Chris Hillery]

The proposal to merge lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba has 
been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/add-jdbc-module/+merge/141866
-- 
https://code.launchpad.net/~zorba-coders/zorba/add-jdbc-module/+merge/141866
Your team Zorba Coders is requested to review the proposed merge of 
lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba

[Zorba Build Bot]

Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/add-jdbc-module-2013-01-08T22-11-56.601Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/add-jdbc-module/+merge/141866
Your team Zorba Coders is requested to review the proposed merge of 
lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1096718 into lp:zorba

[Paul J. Lucas]

Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1096718/+merge/142407
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots-ctest into lp:zorba

[Chris Hillery]

Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/fots-ctest/+merge/138071
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots-ctest into lp:zorba

[Chris Hillery]

The proposal to merge lp:~zorba-coders/zorba/fots-ctest into lp:zorba has been 
updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fots-ctest/+merge/138071
-- 
https://code.launchpad.net/~zorba-coders/zorba/fots-ctest/+merge/138071
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba

[Zorba Build Bot]

The attempt to merge lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job add-jdbc-module-2013-01-08T22-11-56.601Z is finished.
  The final status was:

  

  10 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/add-jdbc-module/+merge/141866
Your team Zorba Coders is requested to review the proposed merge of 
lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba

[Zorba Build Bot]

The proposal to merge lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba has 
been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/add-jdbc-module/+merge/141866
-- 
https://code.launchpad.net/~zorba-coders/zorba/add-jdbc-module/+merge/141866
Your team Zorba Coders is requested to review the proposed merge of 
lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots-ctest into lp:zorba

[Zorba Build Bot]

Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/fots-ctest-2013-01-08T22-37-44.816Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/fots-ctest/+merge/138071
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots-ctest into lp:zorba

[Zorba Build Bot]

Validation queue job fots-ctest-2013-01-08T22-37-44.816Z is finished. The final 
status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/fots-ctest/+merge/138071
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fots-ctest into lp:zorba

[noreply]

The proposal to merge lp:~zorba-coders/zorba/fots-ctest into lp:zorba has been 
updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fots-ctest/+merge/138071
-- 
https://code.launchpad.net/~zorba-coders/zorba/fots-ctest/+merge/138071
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/couchbase-trunk into lp:zorba

[Chris Hillery]

Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk/+merge/135779
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/couchbase-trunk into lp:zorba

[Chris Hillery]

The proposal to merge lp:~zorba-coders/zorba/couchbase-trunk into lp:zorba has 
been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk/+merge/135779
-- 
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk/+merge/135779
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/couchbase-trunk into lp:zorba

[Zorba Build Bot]

Attempt to merge into lp:zorba failed due to conflicts: 

text conflict in ChangeLog
-- 
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk/+merge/135779
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/couchbase-trunk into lp:zorba

[Zorba Build Bot]

The proposal to merge lp:~zorba-coders/zorba/couchbase-trunk into lp:zorba has 
been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk/+merge/135779
-- 
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk/+merge/135779
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba

[Chris Hillery]

The proposal to merge lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba has 
been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/add-jdbc-module/+merge/141866
-- 
https://code.launchpad.net/~zorba-coders/zorba/add-jdbc-module/+merge/141866
Your team Zorba Coders is requested to review the proposed merge of 
lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba

[Zorba Build Bot]

Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/add-jdbc-module-2013-01-09T02-20-48.262Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/add-jdbc-module/+merge/141866
Your team Zorba Coders is requested to review the proposed merge of 
lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba

[Zorba Build Bot]

The proposal to merge lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba has 
been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/add-jdbc-module/+merge/141866
-- 
https://code.launchpad.net/~zorba-coders/zorba/add-jdbc-module/+merge/141866
Your team Zorba Coders is requested to review the proposed merge of 
lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba

[Zorba Build Bot]

The attempt to merge lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job add-jdbc-module-2013-01-09T02-20-48.262Z is finished.
  The final status was:

  

  10 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/add-jdbc-module/+merge/141866
Your team Zorba Coders is requested to review the proposed merge of 
lp:~zorba-coders/zorba/add-jdbc-module into lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

[Paul J. Lucas]

Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/pjl-misc into lp:zorba.

Commit message:
Added missing unit tests.

Requested reviews:
  Paul J. Lucas (paul-lucas)

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/142438

Added missing unit tests.
-- 
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/142438
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'test/unit/CMakeLists.txt'
--- test/unit/CMakeLists.txt	2012-09-19 21:16:15 +
+++ test/unit/CMakeLists.txt	2013-01-09 04:43:21 +
@@ -137,21 +137,32 @@
 ZORBA_GENERATE_EXE(LibUnitTest lib_unit_test.cpp "" "" "")
 
 # ADD NEW UNIT TESTS HERE
+ZORBA_ADD_TEST("test/libunit/base64" LibUnitTest base64)
+ZORBA_ADD_TEST("test/libunit/base64_streambuf" LibUnitTest base64_streambuf)
 IF (NOT WIN32)
   # disabled because of bug lp:867271
   ZORBA_ADD_TEST("test/libunit/string" LibUnitTest string)
 ENDIF (NOT WIN32)
 ZORBA_ADD_TEST("test/libunit/uri" LibUnitTest uri)
 EXPECTED_FAILURE(test/libunit/uri 3118348)
+IF (NOT ZORBA_NO_ICU)
+  ZORBA_ADD_TEST("test/libunit/icu_streambuf" LibUnitTest icu_streambuf)
+ENDIF (NOT ZORBA_NO_ICU)
 ZORBA_ADD_TEST("test/libunit/json_parser" LibUnitTest json_parser)
 #ZORBA_ADD_TEST("test/libunit/memory_manager" LibUnitTest memory_manager)
-IF (NOT ZORBA_HAVE_UNIQUE_PTR)
-  ZORBA_ADD_TEST("test/libunit/unique_ptr" LibUnitTest unique_ptr)
-ENDIF (NOT ZORBA_HAVE_UNIQUE_PTR)
 IF (NOT ZORBA_NO_FULL_TEXT)
   ZORBA_ADD_TEST("test/libunit/stemmer" LibUnitTest stemmer)
   ZORBA_ADD_TEST("test/libunit/thesaurus" LibUnitTest thesaurus)
   ZORBA_ADD_TEST("test/libunit/tokenizer" LibUnitTest tokenizer)
 ENDIF (NOT ZORBA_NO_FULL_TEXT)
+IF (NOT ZORBA_HAVE_UNIQUE_PTR)
+  ZORBA_ADD_TEST("test/libunit/unique_ptr" LibUnitTest unique_ptr)
+ENDIF (NOT ZORBA_HAVE_UNIQUE_PTR)
+IF (NOT ZORBA_HAVE_UNORDERED_MAP)
+  ZORBA_ADD_TEST("test/libunit/unordered_map" LibUnitTest unordered_map)
+ENDIF (NOT ZORBA_HAVE_UNORDERED_MAP)
+IF (NOT ZORBA_HAVE_UNORDERED_SET)
+  ZORBA_ADD_TEST("test/libunit/unordered_set" LibUnitTest unordered_set)
+ENDIF (NOT ZORBA_HAVE_UNORDERED_SET)
 
 # vim:set et sw=2 ts=2:

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

[Paul J. Lucas]

Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/142438
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Cezar Andrei]

> I like the module a lot. There are only a couple of minor things that need
> fixing:
> 
> - There are a bunch of typos in the documentation. Could you please run it
> through a spell-checker?
> 
> For example,
> 
> s/corespond/correspond
> s/initiaized/initialized
> s/corectly/correctly
Fixed.

> 
> - the jsoniq functions module doesn't need to be included
Yes it does, it's used at line 67: jn:members($helper-host-ports)

> - variable names and errors should not use camel-case but dashes, e.g.
> subRange => sub-range
Done.
-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Cezar Andrei]

The proposal to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba has 
been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-utf8_streambuf into lp:zorba

[Paul J. Lucas]

Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/feature-utf8_streambuf 
into lp:zorba.

Commit message:
Streambuf for validating UTF-8 on-the-fly.

Requested reviews:
  Paul J. Lucas (paul-lucas)

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-utf8_streambuf/+merge/142440

Streambuf for validating UTF-8 on-the-fly.
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-utf8_streambuf/+merge/142440
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/unit_tests/CMakeLists.txt'
--- src/unit_tests/CMakeLists.txt	2013-01-05 00:57:49 +
+++ src/unit_tests/CMakeLists.txt	2013-01-09 05:11:31 +
@@ -23,6 +23,8 @@
   test_uri.cpp
   test_uuid.cpp
   unit_tests.cpp
+  test_uri.cpp
+  test_utf8_streambuf.cpp
 )
 
 IF (NOT ZORBA_NO_FULL_TEXT)

=== added file 'src/unit_tests/test_utf8_streambuf.cpp'
--- src/unit_tests/test_utf8_streambuf.cpp	1970-01-01 00:00:00 +
+++ src/unit_tests/test_utf8_streambuf.cpp	2013-01-09 05:11:31 +
@@ -0,0 +1,166 @@
+/*
+ * Copyright 2006-2008 The FLWOR Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "stdafx.h"
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#include "util/utf8_streambuf.h"
+
+using namespace std;
+using namespace zorba;
+
+#define SMILEY_FACE   "\xF0\x9F\x98\x8A"
+#define COPYRIGHT_UTF8"\xC2\xA9"
+#define ONE_THIRD_UTF8"\xE2\x85\x93"
+
+#define BAD_COPYRIGHT_1_UTF8  "\x42\xA9"
+#define BAD_COPYRIGHT_2_UTF8  "\xC2\x79"
+
+static char const *const tests_good[] = {
+  "Hello, world!",
+  "Copyright " COPYRIGHT_UTF8 " 2012",
+  ONE_THIRD_UTF8 " cup sugar",
+  "Smiley " SMILEY_FACE,
+  "Smiley 2 " SMILEY_FACE SMILEY_FACE,
+  SMILEY_FACE " Smiley",
+  SMILEY_FACE SMILEY_FACE " 2 Smiley",
+  0
+};
+
+static char const *const tests_bad[] = {
+  "Copyright " BAD_COPYRIGHT_1_UTF8 " 2012",
+  "Copyright " BAD_COPYRIGHT_2_UTF8 " 2012",
+  0
+};
+
+///
+
+static int failures;
+
+static bool assert_true( int no, char const *expr, int line, bool result ) {
+  if ( !result ) {
+cout << '#' << no << " FAILED, line " << line << ": " << expr << endl;
+++failures;
+  }
+  return result;
+}
+
+static void print_exception( int no, char const *expr, int line,
+ std::exception const &e ) {
+  assert_true( no, expr, line, false );
+  cout << "+ exception: " << e.what() << endl;
+}
+
+#define ASSERT_TRUE( NO, EXPR ) assert_true( NO, #EXPR, __LINE__, !!(EXPR) )
+
+#define ASSERT_TRUE_AND_NO_EXCEPTION( NO, EXPR ) \
+  try { ASSERT_TRUE( NO, EXPR ); } \
+  catch ( exception const &e ) { print_exception( NO, #EXPR, __LINE__, e ); } \
+  catch ( ... ) { assert_true( NO, #EXPR, __LINE__, false ); }
+
+#define ASSERT_EXCEPTION( NO, EXPR ) \
+  try { EXPR; assert_true( NO, #EXPR, __LINE__, false ); } \
+  catch ( ZorbaException const &e ) { } \
+  catch ( ... ) { assert_true( NO, #EXPR, __LINE__, false ); }
+
+///
+
+static bool test_getline( char const *test ) {
+  istringstream iss( test );
+  utf8::streambuf utf_buf( iss.rdbuf() );
+  iss.ios::rdbuf( &utf_buf );
+  iss.exceptions( ios::badbit );
+
+  char buf[ 1024 ];
+  iss.getline( buf, sizeof buf );
+  if ( iss.gcount() ) {
+string const s( buf, iss.gcount() );
+return s == test;
+  }
+  return false;
+}
+
+static bool test_read( char const *test ) {
+  istringstream iss( test );
+  utf8::streambuf utf_buf( iss.rdbuf() );
+  iss.ios::rdbuf( &utf_buf );
+  iss.exceptions( ios::badbit );
+
+  char buf[ 1024 ];
+  iss.read( buf, sizeof buf );
+  if ( iss.gcount() ) {
+string const s( buf, iss.gcount() );
+return s == test;
+  }
+  return false;
+}
+
+static bool test_insertion( char const *test ) {
+  ostringstream oss;
+  utf8::streambuf utf_buf( oss.rdbuf(), true );
+  oss.ios::rdbuf( &utf_buf );
+  oss.exceptions( ios::badbit );
+
+  oss << test << flush;
+  string const s( oss.str() );
+  return s == test;
+}
+
+static bool test_put( char const *test ) {
+  ostringstream oss;
+  utf8::streambuf utf_buf( oss.rdbuf(), true );
+  oss.ios::rdbuf( &utf_buf );
+  oss.exceptions( ios::badbit );
+
+  for ( char const *c = test; *c; ++c )
+oss.put( *c );
+
+  string const s( oss.str() );
+  return s == test;
+}
+
+///
+
+namesp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Zorba Build Bot]

Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/f-nosql-db-trunk-2013-01-09T05-11-01.06Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-utf8_streambuf into lp:zorba

[Paul J. Lucas]

Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-utf8_streambuf/+merge/142440
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/feature-utf8_streambuf into lp:zorba

[Paul J. Lucas]

Do you guys want this??

Please not that it does require some discipline to use due to the way 
exceptions are handled in streams.
-- 
https://code.launchpad.net/~paul-lucas/zorba/feature-utf8_streambuf/+merge/142440
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Zorba Build Bot]

The attempt to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job f-nosql-db-trunk-2013-01-09T05-11-01.06Z is finished.
  The final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Zorba Build Bot]

The proposal to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba has 
been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Cezar Andrei]

The proposal to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba has 
been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Zorba Build Bot]

Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/f-nosql-db-trunk-2013-01-09T05-53-57.216Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Zorba Build Bot]

The attempt to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job f-nosql-db-trunk-2013-01-09T05-53-57.216Z is finished.
  The final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Zorba Build Bot]

The proposal to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba has 
been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Chris Hillery]

The proposal to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba has 
been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Zorba Build Bot]

Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/f-nosql-db-trunk-2013-01-09T06-53-53.881Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Chris Hillery]

> > - the jsoniq functions module doesn't need to be included
> Yes it does, it's used at line 67: jn:members($helper-host-ports)

My understanding is that the JSONiq functions module never needs to be 
included. Those functions are built-in to Zorba, like the F&O functions are. 
The .xq file for the module is included only for reference. Importing it 
explicitly just uses extra CPU cycles at compile time.
-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Zorba Build Bot]

Validation queue job f-nosql-db-trunk-2013-01-09T06-53-53.881Z is finished. The 
final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Zorba Build Bot]

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, 
Needs Fixing < 1, Pending < 1. Got: 2 Approve, 1 Needs Fixing.
-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba

[Zorba Build Bot]

The proposal to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba has 
been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
-- 
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp