Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755 -- https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867259 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug867259/+merge/160515 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867259 into lp:zorba
Looks great! -- https://code.launchpad.net/~zorba-coders/zorba/bug867259/+merge/160515 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug1082740_fn_subsequence-2013-04-24T06-13-54.41Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755 -- https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba
Validation queue job bug1082740_fn_subsequence-2013-04-24T06-13-54.41Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba
I will include the 3 different errors for uri:serialize(), Should I leave uri:parse() without any error code? I'm sure there are some reasonable errors for uri:parse(), but I'm not totally sure what they might be. It's possible that URI.cpp will already throw some exceptions if you try to parse a bogus URI, and that might well be good enough. Matthias, can you think of any specific error cases that we should test out? -- https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1123835 into lp:zorba
Review: Needs Fixing Unfortunately, I don't think the proposed change is safe. istream::unget() is not guaranteed to work, and in particular it probably won't work if the stream is coming via HTTP. However, there is a function StreamResource::isStreamSeekable(). Perhaps you could check that flag, and only call the BOM-checking/unget block of code when it returns true. We could at least claim that we are making a best-effort to validate the incoming data. I would be much happier with something like a three-byte wrapper stream buffer that worked the same way BufferedInputStream does in Java, but it seems like that is somehow really hard to accomplish in C++. -- https://code.launchpad.net/~zorba-coders/zorba/bug1123835/+merge/158978 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867259 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug867259/+merge/160515 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867259 into lp:zorba
Validation queue job bug867259-2013-04-24T11-56-52.859Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug867259/+merge/160515 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug867259 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug867259 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug867259/+merge/160515 -- https://code.launchpad.net/~zorba-coders/zorba/bug867259/+merge/160515 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1147563 into lp:zorba
Review: Needs Fixing Please see https://bugs.launchpad.net/zorba/+bug/1147563/comments/3 -- https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1064978 into lp:zorba
So, should I remove the xml dependency from the function? or should I remove the whole function? If we remove the function the user should be able to create the same function by themselves using xqxq:get-type-variable I think we should remove the entire function. It leaves to many unanswered questions. For example, what if the user wants to pass other parameters to the parse-fragment function or what if the user wants to validate items before passing them as arguments? So I made the following changes: *Removed the implementation of bind-cast-variable *Changed the return value of getVariableType from zorba::String to a string Item since if the function returns a TypeIdentifier getting a legible type of the variable is lost, unless there is a way to get the schema String from a typeIdentifier? I think a string item doesn't make a difference. The type of a variable is a sequence type that consists of a QName and an occurrence indicator. Just having the name doesn't really help. What do you think is missing from the TypeIdentifier? It allows you to retrieve the URI, local name, and quantifier. What am I missing? There are 2 things I miss information about typeIdentifier: 1. how to create a TypeIdentifier from a XQType 2. The function of xqxq is supposed to return the string of type function so getVariableType is returning the XQType toSchemaString so that the user can actually use it to cast the values of the variable, now does a typeIdentifier has a value like that? Does the localname represents that? -- https://code.launchpad.net/~zorba-coders/zorba/bug1064978/+merge/150696 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
Paul J. Lucas has proposed merging lp:~zorba-coders/zorba/bug-1169908 into
lp:zorba.
Commit message:
char_length() and utf8::read() now throw an exception upon an invalid UTF-8.
Requested reviews:
Paul J. Lucas (paul-lucas)
Related bugs:
Bug #1169908 in Zorba: Zorba hangs with invalid utf-8 input
https://bugs.launchpad.net/zorba/+bug/1169908
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692
char_length() and utf8::read() now throw an exception upon an invalid UTF-8.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/runtime/strings/strings_impl.cpp'
--- src/runtime/strings/strings_impl.cpp 2013-04-12 04:34:41 +
+++ src/runtime/strings/strings_impl.cpp 2013-04-24 15:47:29 +
@@ -16,6 +16,7 @@
#include stdafx.h
#include iostream
+#include sstream
#include common/common.h
@@ -39,11 +40,13 @@
#include zorbautils/string_util.h
+#include util/ascii_util.h
+#include util/oseparator.h
#include util/regex.h
-#include util/utf8_util.h
-#include util/utf8_string.h
#include util/string_util.h
#include util/uri_util.h
+#include util/utf8_string.h
+#include util/utf8_util.h
#include util/xml_util.h
@@ -137,49 +140,32 @@
{
utf8::encoded_char_type ec;
memset( ec, 0, sizeof( ec ) );
- utf8::storage_type *p;
- p = ec;
- if ( utf8::read( *state-theStream, ec ) == utf8::npos )
- {
-if ( state-theStream-eof() )
+ try {
+if ( !utf8::read( *state-theStream, ec ) ) {
+ if ( !state-theStream-eof() !state-theStream-good() )
+throw XQUERY_EXCEPTION(
+ zerr::ZOSE0003_STREAM_READ_FAILURE, ERROR_LOC( loc )
+);
break;
-if ( state-theStream-good() ) {
- //
- // If read() failed but the stream state is good, it means that an
- // invalid byte was encountered.
- //
- char buf[ 6 /* bytes at most */ * 5 /* chars per byte */ ], *b = buf;
- bool first = true;
- for ( ; *p; ++p ) {
-if ( first )
- first = false;
-else
- *b++ = ',';
-::strcpy( b, 0x ); b += 2;
-::sprintf( b, %0hhX, *p ); b += 2;
- }
- throw XQUERY_EXCEPTION(
-zerr::ZXQD0006_INVALID_UTF8_BYTE_SEQUENCE,
-ERROR_PARAMS( buf ),
-ERROR_LOC( loc )
- );
-} else {
- throw XQUERY_EXCEPTION(
-zerr::ZOSE0003_STREAM_READ_FAILURE, ERROR_LOC( loc )
- );
}
}
- state-theResult.clear();
- state-theResult.push_back( utf8::next_char( p ) );
-
+ catch ( utf8::invalid_byte const ) {
+ostringstream oss;
+oseparator comma( ',' );
+for ( utf8::storage_type const *c = ec; *c; ++c )
+ oss comma ascii::printable_char( *c );
+throw XQUERY_EXCEPTION(
+ zerr::ZXQD0006_INVALID_UTF8_BYTE_SEQUENCE,
+ ERROR_PARAMS( oss.str() ),
+ ERROR_LOC( loc )
+);
+ }
GENV_ITEMFACTORY-createInteger(
-result,
-Integer(state-theResult[0])
+result, xs_integer( utf8::decode( ec ) )
);
-
- STACK_PUSH(true, state );
- state-theIterator = state-theIterator + 1;
+ STACK_PUSH( true, state );
+ ++(state-theIterator);
}
}
else if (!inputStr.empty())
@@ -190,7 +176,7 @@
{
GENV_ITEMFACTORY-createInteger(
result,
-Integer(state-theResult[state-theIterator])
+xs_integer(state-theResult[state-theIterator])
);
STACK_PUSH(true, state );
@@ -263,7 +249,7 @@
res = (res 0 ? -1 : (res 0 ? 1 : 0));
- GENV_ITEMFACTORY-createInteger(result, Integer(res));
+ GENV_ITEMFACTORY-createInteger(result, xs_integer(res));
STACK_PUSH(true, state);
}
@@ -758,13 +744,11 @@
if (consumeNext(item, theChildren [0].getp(), planState))
{
item-getStringValue2(strval);
-
-STACK_PUSH(GENV_ITEMFACTORY-createInteger(result, Integer(utf8::length(strval))),
- state);
+STACK_PUSH(GENV_ITEMFACTORY-createInteger(result, xs_integer(utf8::length(strval))), state);
}
else
{
-STACK_PUSH(GENV_ITEMFACTORY-createInteger(result, Integer::zero()),
+STACK_PUSH(GENV_ITEMFACTORY-createInteger(result, xs_integer::zero()),
state);
}
STACK_END(state);
@@ -2350,6 +2334,7 @@
store::Item_t result,
PlanState planState) const
{
+ bool read;
store::Item_t item;
size_t lNewPos = 0;
zstring lToken;
@@ -2381,11 +2366,24 @@
while ( !state-theIStream-eof() )
{
utf8::encoded_char_type ec;
- memset( ec, '\0' , sizeof(ec) );
- utf8::storage_type *p;
- p = ec;
-
- if ( utf8::read( *state-theIStream, ec ) != utf8::npos )
+ memset( ec, 0 , sizeof(ec)
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1169908 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1169908-2013-04-24T15-53-40.871Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug-1169908 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug-1169908-2013-04-24T15-53-40.871Z is finished. The final status was: 433 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1169908 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1147563 into lp:zorba
Review: Approve Looks good. It will most likely not pass in the current remote queue setup because it's still running libxercesc 2.8). It has been tested with libxerces 3.1.1 and is running correctly, should pass when Chris will update remote queue to use the newer xerces. -- https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239 -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug1100471-2013-04-24T17-04-59.855Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1064978 into lp:zorba
So, should I remove the xml dependency from the function? or should I
remove
the whole function?
If we remove the function the user should be able to create the same
function
by themselves using xqxq:get-type-variable
I think we should remove the entire function. It leaves to many
unanswered
questions. For example,
what if the user wants to pass other parameters to the parse-fragment
function
or what if the user wants to validate items before passing them as
arguments?
So I made the following changes:
*Removed the implementation of bind-cast-variable
*Changed the return value of getVariableType from zorba::String to a
string
Item since if the function returns a TypeIdentifier getting a legible type
of
the variable is lost, unless there is a way to get the schema String from
a
typeIdentifier?
I think a string item doesn't make a difference. The type of a variable is a
sequence type that consists of a QName and an occurrence indicator. Just
having the name doesn't really help. What do you think is missing from the
TypeIdentifier? It allows you to retrieve the URI, local name, and
quantifier.
What am I missing?
There are 2 things I miss information about typeIdentifier:
1. how to create a TypeIdentifier from a XQType
Take a look at CollectionImpl::getType in src/api/collectionimpl.cpp.
2. The function of xqxq is supposed to return the string of type function so
getVariableType is returning the XQType toSchemaString so that the user can
actually use it to cast the values of the variable, now does a typeIdentifier
has a value like that? Does the localname represents that?
The problem is that there is no representation of types in the data model. To
answer the question we need to investigate the use case. I think the function
should either (1) return a QName item that represents the name of the type
(maybe renaming the function to getVariablePrimeType) or (2) return a string
using the sequence-type syntax (e.g. xs:string*, xs:integer?, or
Q{http://foo.bar}my-type*).
--
https://code.launchpad.net/~zorba-coders/zorba/bug1064978/+merge/150696
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba
Validation queue job bug1100471-2013-04-24T17-04-59.855Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/160731 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/160731 -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/160731 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/markos-scratch-2013-04-24T18-05-01.675Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/160731 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
Validation queue job markos-scratch-2013-04-24T18-05-01.675Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/160731 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/markos-scratch into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/160731 -- https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/160731 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1064978 into lp:zorba
So, should I remove the xml dependency from the function? or should
I
remove
the whole function?
If we remove the function the user should be able to create the same
function
by themselves using xqxq:get-type-variable
I think we should remove the entire function. It leaves to many
unanswered
questions. For example,
what if the user wants to pass other parameters to the parse-fragment
function
or what if the user wants to validate items before passing them as
arguments?
So I made the following changes:
*Removed the implementation of bind-cast-variable
*Changed the return value of getVariableType from zorba::String to a
string
Item since if the function returns a TypeIdentifier getting a legible
type
of
the variable is lost, unless there is a way to get the schema String
from
a
typeIdentifier?
I think a string item doesn't make a difference. The type of a variable is
a
sequence type that consists of a QName and an occurrence indicator. Just
having the name doesn't really help. What do you think is missing from the
TypeIdentifier? It allows you to retrieve the URI, local name, and
quantifier.
What am I missing?
There are 2 things I miss information about typeIdentifier:
1. how to create a TypeIdentifier from a XQType
Take a look at CollectionImpl::getType in src/api/collectionimpl.cpp.
2. The function of xqxq is supposed to return the string of type function so
getVariableType is returning the XQType toSchemaString so that the user can
actually use it to cast the values of the variable, now does a
typeIdentifier
has a value like that? Does the localname represents that?
The problem is that there is no representation of types in the data model. To
answer the question we need to investigate the use case. I think the function
should either (1) return a QName item that represents the name of the type
(maybe renaming the function to getVariablePrimeType) or (2) return a string
using the sequence-type syntax (e.g. xs:string*, xs:integer?, or
Q{http://foo.bar}my-type*).
As for the purpose of the function, is to allow the user a tool so he can cast
a string value into the corresponding type of external variable, that's why we
need the function to return something logical in string which in this case the
schema string of the type fits perfectly, so an actual type representation of
the function is not that helpful if is not usable to cast the variable.
So let me see if I understand your points the first one, is to rename the
function (which is appropriate) and to instead of returning the string item
with the value turn it into a QName my only question would be the namespace of
this QName should it be the same of the external variable? or a new namespace
referring to this primetype, also I am guessing that the localname would be the
schema string of the type.
As for your second suggestion I don't understand what you mean by it, are you
talking about the xqxq.xq description of the function or the new dynamic
context function? the xqxq one is already returning something like that and the
dynamic context one you mean to return a Sequence? or what do you mean?
--
https://code.launchpad.net/~zorba-coders/zorba/bug1064978/+merge/150696
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1169908 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1103819-catchAll into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug1103819-catchAll into lp:zorba has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1103819-catchAll/+merge/159053 -- https://code.launchpad.net/~zorba-coders/zorba/bug1103819-catchAll/+merge/159053 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1169908 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1169908-2013-04-24T21-32-43.53Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug-1169908 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug-1169908-2013-04-24T21-32-43.53Z is finished. The final status was: 4 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1169908 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1147563 into lp:zorba
In trunk at least the following tests are passing: cbcl-schema-element-1 2,4,5,8. Which makes them a regression. -- https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1147563 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug1147563 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485 -- https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1147563 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug1147563-2013-04-25T00-35-04.776Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
Chris Hillery has proposed merging lp:~zorba-coders/zorba/rq-xerces-311 into
lp:zorba.
Commit message:
Any test changes necessary due to upgrading the RQ to Xerces 3.1.1.
Requested reviews:
Zorba Coders (zorba-coders)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781
--
https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781
Your team Zorba Coders is requested to review the proposed merge of
lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba.
=== modified file 'test/fots/CMakeLists.txt'
--- test/fots/CMakeLists.txt 2013-04-24 18:26:40 +
+++ test/fots/CMakeLists.txt 2013-04-25 00:47:30 +
@@ -58,7 +58,6 @@
ENDIF (EXISTS ${_fotsscript})
ENDIF (NOT _fotsscript STREQUAL )
-
# Customized macro for FOTS tests
MACRO (expected_fots_failure)
PARSE_ARGUMENTS (EFF SLOW;CRASH;DISPUTED ${ARGN})
@@ -98,6 +97,7 @@
${test_case} ${bugid} ${_notrun} ${_finalStatus} ${_disputed})
ENDMACRO (expected_fots_failure)
+
##
## Place all known failing FOTS tests here!
##
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba has been updated. Commit Message changed to: Any test changes necessary due to upgrading the RQ to Xerces 3.1.1. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1147563 into lp:zorba
Guys, FYI, this RQ run is running with Xerces 3.1.1. Look for any test progressions/regressions. -- https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba has been updated. Status: Approved = Rejected For more details, see: https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba has been updated. Status: Rejected = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1147563 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug1147563 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug1147563-2013-04-25T00-35-04.776Z is finished. The final status was: 2 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1147563 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug1147563 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485 -- https://code.launchpad.net/~zorba-coders/zorba/bug1147563/+merge/153485 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/rq-xerces-311-2013-04-25T01-02-41.386Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job rq-xerces-311-2013-04-25T01-02-41.386Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/rq-xerces-311-2013-04-25T01-33-39.33Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
Validation queue job rq-xerces-311-2013-04-25T01-33-39.33Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/rq-xerces-311 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 -- https://code.launchpad.net/~zorba-coders/zorba/rq-xerces-311/+merge/160781 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1169908 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1169908-2013-04-25T02-10-50.587Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
Validation queue job bug-1169908-2013-04-25T02-10-50.587Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1 Approve. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1169908 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1169908-2013-04-25T02-57-44.597Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1064978 into lp:zorba
So, should I remove the xml dependency from the function? or
should
I
remove
the whole function?
If we remove the function the user should be able to create the
same
function
by themselves using xqxq:get-type-variable
I think we should remove the entire function. It leaves to many
unanswered
questions. For example,
what if the user wants to pass other parameters to the parse-
fragment
function
or what if the user wants to validate items before passing them as
arguments?
So I made the following changes:
*Removed the implementation of bind-cast-variable
*Changed the return value of getVariableType from zorba::String to a
string
Item since if the function returns a TypeIdentifier getting a legible
type
of
the variable is lost, unless there is a way to get the schema String
from
a
typeIdentifier?
I think a string item doesn't make a difference. The type of a variable
is
a
sequence type that consists of a QName and an occurrence indicator. Just
having the name doesn't really help. What do you think is missing from
the
TypeIdentifier? It allows you to retrieve the URI, local name, and
quantifier.
What am I missing?
There are 2 things I miss information about typeIdentifier:
1. how to create a TypeIdentifier from a XQType
Take a look at CollectionImpl::getType in src/api/collectionimpl.cpp.
2. The function of xqxq is supposed to return the string of type function
so
getVariableType is returning the XQType toSchemaString so that the user
can
actually use it to cast the values of the variable, now does a
typeIdentifier
has a value like that? Does the localname represents that?
The problem is that there is no representation of types in the data model.
To
answer the question we need to investigate the use case. I think the
function
should either (1) return a QName item that represents the name of the type
(maybe renaming the function to getVariablePrimeType) or (2) return a string
using the sequence-type syntax (e.g. xs:string*, xs:integer?, or
Q{http://foo.bar}my-type*).
As for the purpose of the function, is to allow the user a tool so he can cast
a string value into the corresponding type of external variable, that's why we
need the function to return something logical in string which in this case the
schema string of the type fits perfectly, so an actual type representation of
the function is not that helpful if is not usable to cast the variable.
So let me see if I understand your points the first one, is to rename the
function (which is appropriate) and to instead of returning the string item
with the value turn it into a QName my only question would be the namespace of
this QName should it be the same of the external variable? or a new namespace
referring to this primetype, also I am guessing that the localname would be
the schema string of the type.
All types are identified by QNames. For example, xs:string is short for
Q{http://www.w3.org/2001/XMLSchema}string. You cannot assume that the namespace
is always the XMLSchema one. The user could have used her own user-defined type
from a schema. That's why the return type should be a QName.
I'm fine if you call the function getVariablePrimeType and make it return a
QName.
The C++ API should use the TypeIdentifier.
--
https://code.launchpad.net/~zorba-coders/zorba/bug1064978/+merge/150696
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
Validation queue job bug-1169908-2013-04-25T02-57-44.597Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1169908 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-1169908 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1169908/+merge/160692 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
