[Zorba-coders] [Bug 867035] Re: not all the functions from FO 3.0 are implemented
I have marked this bug as In Progress and assigned it back to Juan because AFAIK he is working on this. ** Changed in: zorba Status: Won't Fix = In Progress ** Changed in: zorba Assignee: Sorin Marian Nasoi (sorin.marian.nasoi) = Juan Zacarias (juan457) -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/867035 Title: not all the functions from FO 3.0 are implemented Status in Zorba - The XQuery Processor: In Progress Bug description: That is why test test/rbkt/zorba/spec/xquery_1_1 fails. After you implement the missing FO functions please check this test as well. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/867035/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 867035] Re: not all the functions from FO 3.0 are implemented
** Changed in: zorba Importance: High = Medium -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/867035 Title: not all the functions from FO 3.0 are implemented Status in Zorba - The XQuery Processor: In Progress Bug description: That is why test test/rbkt/zorba/spec/xquery_1_1 fails. After you implement the missing FO functions please check this test as well. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/867035/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_test_xquery_1_1 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix_test_xquery_1_1 into lp:zorba has been updated. Commit Message changed to: Downloaded the latest version of the W3C Working Draft 13 December 2011for XQuery 3.0 FO to be used in test xquery_3_0. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_test_xquery_1_1/+merge/91033 -- https://code.launchpad.net/~zorba-coders/zorba/fix_test_xquery_1_1/+merge/91033 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_test_xquery_1_1 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix_test_xquery_1_1 into lp:zorba has been updated. Commit Message changed to: Downloaded the latest version of the W3C Working Draft from December 13, 2011 of the XQuery 3.0 FO to be used in test xquery_3_0. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_test_xquery_1_1/+merge/91033 -- https://code.launchpad.net/~zorba-coders/zorba/fix_test_xquery_1_1/+merge/91033 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 924205] Re: test converters/base64/binaryReadWrite.xq fails with plan serializer
** Branch linked: lp:~zorba-coders/zorba/plan-serializer -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/924205 Title: test converters/base64/binaryReadWrite.xq fails with plan serializer Status in Zorba - The XQuery Processor: New Bug description: The test converters/base64/binaryReadWrite.xq fails with plan serializer in debug mode. In release mode on Win32 it seems to work. There is an assert in materialize_clause::clone() . The stack for the assert is: zorba_simplestore.dll!zorba::assertion_failed(const char * condition, const char * file, int line) Line 66 + 0x4c bytesC++ zorba_simplestore.dll!zorba::materialize_clause::clone(std::mapzorba::expr const *,zorba::rchandlezorba::expr,std::lesszorba::expr const *,std::allocatorstd::pairzorba::expr const * const,zorba::rchandlezorba::expr subst) Line 806 + 0x1d bytes C++ zorba_simplestore.dll!zorba::flwor_expr::clone(std::mapzorba::expr const *,zorba::rchandlezorba::expr,std::lesszorba::expr const *,std::allocatorstd::pairzorba::expr const * const,zorba::rchandlezorba::expr subst) Line 1225 + 0x30 bytes C++ zorba_simplestore.dll!zorba::InlineFunctions::rewritePost(zorba::expr * node, zorba::RewriterContext rCtx) Line 1083 + 0x3a bytesC++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 60 + 0x1e bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::RuleMajorDriver::rewrite(zorba::RewriterContext rCtx) Line 61 + 0x55 bytes C++ zorba_simplestore.dll!zorba::DefaultOptimizer::rewrite(zorba::RewriterContext rCtx) Line 83 + 0xf bytes C++ zorba_simplestore.dll!zorba::user_function::getPlan(zorba::CompilerCB * ccb, unsigned int planStateSize) Line 388 + 0x4d bytes C++ zorba_simplestore.dll!zorba::user_function::prepare_for_serialize(zorba::CompilerCB * compilerCB) Line 102 + 0x14 bytesC++ zorba_simplestore.dll!zorba::CompilerCB::prepare_for_serialize() Line 182 C++ zorba_simplestore.dll!zorba::XQueryImpl::serialize(zorba::serialization::Archiver ar) Line 200 C++ zorba_simplestore.dll!zorba::XQueryImpl::saveExecutionPlan(std::basic_ostreamchar,std::char_traitschar os, Zorba_binary_plan_format_t archive_format, Zorba_save_plan_options_t save_options) Line 922 C++ To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/924205/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_test_xquery_1_1 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_test_xquery_1_1/+merge/91033 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 924754] [NEW] support for the xs:dateTimeStamp type
Public bug reported: I bumped into the following issue while trying to run the following XQuery 3.0 test: exists(fn:timezone-from-dateTime(xs:dateTimeStamp(2011-07-28T12:34:56-08:00))) Zorba returned: static error [err:XPST0017]: xs:dateTimeStamp: function with arity 1 not declared Looking into the latest FO Spec for XQuery 3.0 I see that a new type, xs:dateTimeStamp was added for the implementations that support XSD 1.1. I have a few questions: 1) should Zorba support the new type, xs:dateTimeStamp? If so, some function signatures need to be changed, for instance: Now, in Zorba, fn:current-dateTime() returns a xs:dateTime instead of a xs:dateTimeStamp as stated in the http://www.w3.org/TR/xpath-functions-30/#func-current-dateTime. 2) Should Zorba support constructor functions for xsd types ? Meaning should we add functions like: fn:unsignedInt($arg as xs:anyAtomicType?) as xs:unsignedInt? 3) There are 2 tests in Zorba( xquery_1_0 and xquery_1_1) that check if all the functions from the fn: namespace of the FO spec 1.0 and 3.0 are implemented in Zorba. The problem with these tests is that they only check the function names and their corresponding arities; they do not check if the types of the parameters are correct. This is the reason why the change in the signature of the fn:current-dateTime() that should now return a xs:dateTimeStamp was not picked up by these tests. IMO we should update these 2 tests to also check the parameter types: one problem I see here is that the introspection module only provides function to get the function name and arity, not the types of the parameters. Thanks for the help, Sorin ** Affects: zorba Importance: Undecided Assignee: Markos Zaharioudakis (markos-za) Status: New -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/924754 Title: support for the xs:dateTimeStamp type Status in Zorba - The XQuery Processor: New Bug description: I bumped into the following issue while trying to run the following XQuery 3.0 test: exists(fn:timezone-from-dateTime(xs:dateTimeStamp(2011-07-28T12:34:56-08:00))) Zorba returned: static error [err:XPST0017]: xs:dateTimeStamp: function with arity 1 not declared Looking into the latest FO Spec for XQuery 3.0 I see that a new type, xs:dateTimeStamp was added for the implementations that support XSD 1.1. I have a few questions: 1) should Zorba support the new type, xs:dateTimeStamp? If so, some function signatures need to be changed, for instance: Now, in Zorba, fn:current-dateTime() returns a xs:dateTime instead of a xs:dateTimeStamp as stated in the http://www.w3.org/TR/xpath-functions-30/#func-current-dateTime. 2) Should Zorba support constructor functions for xsd types ? Meaning should we add functions like: fn:unsignedInt($arg as xs:anyAtomicType?) as xs:unsignedInt? 3) There are 2 tests in Zorba( xquery_1_0 and xquery_1_1) that check if all the functions from the fn: namespace of the FO spec 1.0 and 3.0 are implemented in Zorba. The problem with these tests is that they only check the function names and their corresponding arities; they do not check if the types of the parameters are correct. This is the reason why the change in the signature of the fn:current-dateTime() that should now return a xs:dateTimeStamp was not picked up by these tests. IMO we should update these 2 tests to also check the parameter types: one problem I see here is that the introspection module only provides function to get the function name and arity, not the types of the parameters. Thanks for the help, Sorin To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/924754/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/declare-uri-file into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/declare-uri-file into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job declare-uri-file-2012-02-01T11-39-55.537Z is finished. The final status was: 28 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 921458] Re: file:read-text-lines() blocking
** Changed in: zorba Importance: High = Critical -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/921458 Title: file:read-text-lines() blocking Status in Zorba - The XQuery Processor: New Bug description: I wrote the following query: import module namespace file =http://expath.org/ns/file;; for $line at $i in file:read-text-lines(doc.xml) return if($i lt 1104869) then () else concat($line, ) Where doc.xml is a large document. The result of the query seems to never end and its memory footprint is huge. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/921458/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/declare-uri-file into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/declare-uri-file into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 -- https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~gislenius/zorba/item-typos into lp:zorba
Ghislain Fourny has proposed merging lp:~gislenius/zorba/item-typos into lp:zorba. Requested reviews: Matthias Brantner (matthias-brantner) For more details, see: https://code.launchpad.net/~gislenius/zorba/item-typos/+merge/91098 Correcting two typos (from Sausalito). -- https://code.launchpad.net/~gislenius/zorba/item-typos/+merge/91098 Your team Zorba Coders is subscribed to branch lp:zorba. === modified file 'src/store/naive/node_factory.h' --- src/store/naive/node_factory.h 2012-01-11 17:30:25 + +++ src/store/naive/node_factory.h 2012-02-01 14:58:27 + @@ -108,7 +108,7 @@ virtual TextNode* createTextNode( XmlTree* tree, InternalNode* parent, -bool aqppend, +bool append, csize pos, zstring content); === modified file 'src/store/naive/node_items.cpp' --- src/store/naive/node_items.cpp 2012-01-26 19:56:14 + +++ src/store/naive/node_items.cpp 2012-02-01 14:58:27 + @@ -1722,7 +1722,7 @@ strStream ?xml version=\1.0\ encoding=\UTF-8\? std::endl document; strStream baseUri = \ theBaseUri \; - strStream docUri = \ theDocUri; + strStream docUri = \ theDocUri \; strStream \ std::endl; store::Iterator_t iter = getChildren(); -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~gislenius/zorba/item-typos into lp:zorba
Review: Approve -- https://code.launchpad.net/~gislenius/zorba/item-typos/+merge/91098 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~gislenius/zorba/item-typos into lp:zorba
Review: Approve -- https://code.launchpad.net/~gislenius/zorba/item-typos/+merge/91098 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~gislenius/zorba/item-typos into lp:zorba
The proposal to merge lp:~gislenius/zorba/item-typos into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~gislenius/zorba/item-typos/+merge/91098 -- https://code.launchpad.net/~gislenius/zorba/item-typos/+merge/91098 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:zorba/data-cleaning-module into lp:~diogo-simoes89/zorba/DC
Diogo Simões has proposed merging lp:zorba/data-cleaning-module into lp:~diogo-simoes89/zorba/DC. Requested reviews: Diogo Simões (diogo-simoes89) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-module/+merge/91121 Changes in the tests of conversion module: - address-from-phone - address-from-user - phone-from-address - phone-from-user - user-from-address - user-from-phone These changes support variations of the webservices results -- https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-module/+merge/91121 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:zorba/data-cleaning-module into lp:~diogo-simoes89/zorba/DC
The proposal to merge lp:zorba/data-cleaning-module into lp:~diogo-simoes89/zorba/DC has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-module/+merge/91121 -- https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-module/+merge/91121 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug918592 into lp:zorba
The issue you mentioned is orthogonal to this merge proposal. There is a stable PHP API which implementation needs to be updated if the SWIG API change. It's the same for XQJ I assume? But again, this is not related to the merge proposal. -- https://code.launchpad.net/~zorba-coders/zorba/bug918592/+merge/89398 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/DC into lp:zorba/data-cleaning-module
The proposal to merge lp:~diogo-simoes89/zorba/DC into lp:zorba/data-cleaning-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~diogo-simoes89/zorba/DC/+merge/91124 -- https://code.launchpad.net/~diogo-simoes89/zorba/DC/+merge/91124 Your team Zorba Coders is requested to review the proposed merge of lp:~diogo-simoes89/zorba/DC into lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 897588] Re: Get annotation values from introspection/sctx
I have implemented one of the function at https://code.launchpad.net /~zorba-coders/zorba/bug897588 ** Branch linked: lp:~zorba-coders/zorba/bug897588 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/897588 Title: Get annotation values from introspection/sctx Status in Zorba - The XQuery Processor: New Bug description: The following functions should be added: declare function sctx:function-annotation($function-name as xs:QName, $arity as xs:integer, $annotation as xs:QName) as xs:anyAtomicType* external; declare function sctx:variable-annotations($name as xs:QName) as xs:QName* external; declare function sctx:variable-annotation($name as xs:QName, $annotation as xs:QName) as xs:anyAtomicType* external; To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/897588/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-bug921624 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix-bug921624 into lp:zorba has been updated. Commit Message changed to: Install the XHTML DTD locally so we don't ask w3.org for it. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-bug921624/+merge/91129 -- https://code.launchpad.net/~zorba-coders/zorba/fix-bug921624/+merge/91129 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-bug921624 into lp:zorba
Review: Approve I have resubmitted the merge proposal after I merged the lp:zorba trunk (there was a conflict in the Changelog). The fix works. -- https://code.launchpad.net/~zorba-coders/zorba/fix-bug921624/+merge/91129 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-bug921624 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-bug921624/+merge/91129 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-bug921624 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix-bug921624 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-bug921624/+merge/91129 -- https://code.launchpad.net/~zorba-coders/zorba/fix-bug921624/+merge/91129 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-bug921624 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fix-bug921624-2012-02-01T16-44-59.851Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fix-bug921624/+merge/91129 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-bug921624 into lp:zorba
Validation queue job fix-bug921624-2012-02-01T16-44-59.851Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fix-bug921624/+merge/91129 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-bug921624 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix-bug921624 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-bug921624/+merge/91129 -- https://code.launchpad.net/~zorba-coders/zorba/fix-bug921624/+merge/91129 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/declare-uri-file into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/declare-uri-file into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 -- https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/declare-uri-file into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/declare-uri-file-2012-02-01T17-18-00.232Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/DC into lp:zorba/data-cleaning-module
Diogo, you need to set the commit message for the merge proposal in order for the validation queue to run. -- https://code.launchpad.net/~diogo-simoes89/zorba/DC/+merge/91124 Your team Zorba Coders is requested to review the proposed merge of lp:~diogo-simoes89/zorba/DC into lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 921624] Re: testdriver_mt and OptionalFeatureErrors
** Changed in: zorba Status: New = Fix Committed -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/921624 Title: testdriver_mt and OptionalFeatureErrors Status in Zorba - The XQuery Processor: Fix Committed Bug description: For some reason it takes a very long time to run the OptionalFeatureErrors tests in the XQTS with the testdriver_mt no matter if I use a Debug or a Release build. It might be a performance issue or a testdriver_mt issue, in any case I think that Markos is the best person to take a look when he has some time. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/921624/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/DC into lp:zorba/data-cleaning-module
Thanks Chris. Guess it is done now To: mp+91...@code.launchpad.net From: chillery+launch...@lambda.nu Subject: Re: [Merge] lp:~diogo-simoes89/zorba/DC into lp:zorba/data-cleaning-module Date: Wed, 1 Feb 2012 17:18:20 + Diogo, you need to set the commit message for the merge proposal in order for the validation queue to run. -- https://code.launchpad.net/~diogo-simoes89/zorba/DC/+merge/91124 You are the owner of lp:~diogo-simoes89/zorba/DC. -- https://code.launchpad.net/~diogo-simoes89/zorba/DC/+merge/91124 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/DC into lp:zorba/data-cleaning-module
Review: Approve Changes in the tests of conversion module: - address-from-phone - address-from-user - phone-from-address - phone-from-user - user-from-address - user-from-phone These changes support variations of the webservices results -- https://code.launchpad.net/~diogo-simoes89/zorba/DC/+merge/91124 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 924987] Re: Failure getting type of a collection via the StaticCollectionManager
** Branch linked: lp:~zorba-coders/zorba/bug924987 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/924987 Title: Failure getting type of a collection via the StaticCollectionManager Status in Zorba - The XQuery Processor: New Bug description: When getting a type of a static collection that is declared as schema-element(...) we run into an assertion in TypeOps::get_type_identifier. Also, the current implementation of TypeIdentifier has no clear way of representing such a type. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/924987/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 924987] [NEW] Failure getting type of a collection via the StaticCollectionManager
Public bug reported: When getting a type of a static collection that is declared as schema-element(...) we run into an assertion in TypeOps::get_type_identifier. Also, the current implementation of TypeIdentifier has no clear way of representing such a type. ** Affects: zorba Importance: High Assignee: Till Westmann (tillw) Status: New -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/924987 Title: Failure getting type of a collection via the StaticCollectionManager Status in Zorba - The XQuery Processor: New Bug description: When getting a type of a static collection that is declared as schema-element(...) we run into an assertion in TypeOps::get_type_identifier. Also, the current implementation of TypeIdentifier has no clear way of representing such a type. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/924987/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/declare-uri-file into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/declare-uri-file into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job declare-uri-file-2012-02-01T17-18-00.232Z is finished. The final status was: 40 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/declare-uri-file into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/declare-uri-file into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 -- https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/declare-uri-file into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/declare-uri-file into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 -- https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/declare-uri-file into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/declare-uri-file-2012-02-01T17-43-03.504Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-bug921624 into lp:zorba
Review: Approve Looks good. -- https://code.launchpad.net/~zorba-coders/zorba/fix-bug921624/+merge/90231 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/declare-uri-file into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/declare-uri-file into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 -- https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/declare-uri-file into lp:zorba
Review: Approve Approve. -- https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba
Till Westmann has proposed merging lp:~zorba-coders/zorba/bug924987 into
lp:zorba.
Requested reviews:
Till Westmann (tillw)
Markos Zaharioudakis (markos-za)
Related bugs:
Bug #924987 in Zorba: Failure getting type of a collection via the
StaticCollectionManager
https://bugs.launchpad.net/zorba/+bug/924987
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144
fixes bug 924987
- extended TypeIdentifier to also support schema-element, schema-attribute
and namespace-node sequence types
- fixed TypeOps::get_type_identifier
- added a test to the staticcollectionmanager unit test
- added operator for TypeIdentifier
--
https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'include/zorba/identtypes.h'
--- include/zorba/identtypes.h 2011-09-21 14:49:55 +
+++ include/zorba/identtypes.h 2012-02-01 18:52:21 +
@@ -17,6 +17,7 @@
#define ZORBA_TYPEIDENT_TYPES_API_H
#include zorba/config.h
+#include iostream
namespace zorba {
class ZORBA_DLL_PUBLIC IdentTypes {
@@ -32,8 +33,13 @@
ANY_NODE_TYPE, // node()
ITEM_TYPE, // item()
EMPTY_TYPE,// empty-sequence()
+SCHEMA_ELEMENT_TYPE,
+SCHEMA_ATTRIBUTE_TYPE,
+NAMESPACE_TYPE,
INVALID_TYPE,
} kind_t;
+
+ static char const *const kind_string_of[];
typedef enum {
QUANT_ONE,
@@ -41,8 +47,17 @@
QUANT_PLUS,
QUANT_STAR,
} quantifier_t;
+
+ static char const *const quantifier_string_of[];
};
}
+namespace std {
+
+ZORBA_DLL_PUBLIC ostream operator(ostream o, const zorba::IdentTypes::kind_t ik);
+ZORBA_DLL_PUBLIC ostream operator(ostream o, const zorba::IdentTypes::quantifier_t iq);
+
+}
+
#endif
/* vim:set et sw=2 ts=2: */
=== modified file 'include/zorba/typeident.h'
--- include/zorba/typeident.h 2011-06-14 17:26:33 +
+++ include/zorba/typeident.h 2012-02-01 18:52:21 +
@@ -20,6 +20,7 @@
#include zorba/api_shared_types.h
#include zorba/identtypes.h
#include zorba/zorba_string.h
+#include iostream
namespace zorba {
@@ -61,7 +62,7 @@
createAttributeType(
const String uri,
bool uriWildcard,
-const String localNameName,
+const String localName,
bool localNameWildcard,
TypeIdentifier_t contentType,
IdentTypes::quantifier_t quantifier = IdentTypes::QUANT_ONE
@@ -108,6 +109,30 @@
TypeIdentifier_t
createEmptyType();
+static
+TypeIdentifier_t
+createSchemaElementType(
+const String uri,
+const String localName,
+TypeIdentifier_t contentType,
+IdentTypes::quantifier_t quantifier = IdentTypes::QUANT_ONE
+);
+
+static
+TypeIdentifier_t
+createSchemaAttributeType(
+const String uri,
+const String localName,
+TypeIdentifier_t contentType,
+IdentTypes::quantifier_t quantifier = IdentTypes::QUANT_ONE
+);
+
+static
+TypeIdentifier_t
+createNamespaceType(
+IdentTypes::quantifier_t quantifier = IdentTypes::QUANT_ONE
+);
+
IdentTypes::kind_t
getKind() const;
@@ -129,6 +154,9 @@
TypeIdentifier_t
getContentType() const;
+std::ostream
+emit(std::ostream) const;
+
private:
TypeIdentifier();
@@ -148,5 +176,12 @@
} /* namespace zorba */
+namespace std {
+
+ZORBA_DLL_PUBLIC ostream operator(ostream o, const zorba::TypeIdentifier ti);
+ZORBA_DLL_PUBLIC ostream operator(ostream o, const zorba::TypeIdentifier_t ti);
+
+}
+
#endif /* ZORBA_TYPES_TYPEIDENT_H */
/* vim:set et sw=2 ts=2: */
=== modified file 'src/api/CMakeLists.txt'
--- src/api/CMakeLists.txt 2011-08-31 13:17:59 +
+++ src/api/CMakeLists.txt 2012-02-01 18:52:21 +
@@ -27,6 +27,7 @@
zorba_string.cpp
itemfactoryimpl.cpp
item.cpp
+identtypesimpl.cpp
typeidentimpl.cpp
unmarshaller.cpp
xmldatamanagerimpl.cpp
=== added file 'src/api/identtypesimpl.cpp'
--- src/api/identtypesimpl.cpp 1970-01-01 00:00:00 +
+++ src/api/identtypesimpl.cpp 2012-02-01 18:52:21 +
@@ -0,0 +1,61 @@
+/*
+ * Copyright 2006-2008 The FLWOR Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License);
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include zorba/identtypes.h
+
+namespace zorba {
+
+char const *const IdentTypes::kind_string_of[] = {
+ NAMED_TYPE,
+ ELEMENT_TYPE,
+ ATTRIBUTE_TYPE,
+ DOCUMENT_TYPE,
+ PI_TYPE,
+ TEXT_TYPE,
+ COMMENT_TYPE,
+
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 921458] Re: file:read-text-lines() blocking
Paul, Could you please investigate why William's program doesn't stream after
applying the patch below?
I understand why it didn't stream in the trunk (i.e. with fn:tokenize) but
using the string:split function, there should be nothing that prevents it from
streaming. I guess the problem is somewhere in the implementation of the split
function (in src/runtime/strings/strings_impl.cpp).
=== modified file 'modules/org/expath/ns/file.xq'
--- modules/org/expath/ns/file.xq 2011-10-19 05:09:31 +
+++ modules/org/expath/ns/file.xq 2012-02-01 20:39:39 +
@@ -23,6 +23,8 @@
:)
module namespace file = http://expath.org/ns/file;;
+import module namespace string = http://www.zorba-xquery.com/modules/string;;
+
import schema namespace output =
http://www.w3.org/2010/xslt-xquery-serialization;;
declare namespace ann = http://www.zorba-xquery.com/annotations;;
declare namespace ver = http://www.zorba-xquery.com/options/versioning;;
@@ -424,8 +426,7 @@
$encoding as xs:string
) as xs:string*
{
- let $content := file:read-text($file, $encoding)
- return fn:tokenize($content, \n)
+ string:split(file:read-text($file, $encoding), f)
};
(:~
** Changed in: zorba
Assignee: (unassigned) = Paul J. Lucas (paul-lucas)
--
You received this bug notification because you are a member of Zorba
Coders, which is the registrant for Zorba.
https://bugs.launchpad.net/bugs/921458
Title:
file:read-text-lines() blocking
Status in Zorba - The XQuery Processor:
New
Bug description:
I wrote the following query:
import module namespace file =http://expath.org/ns/file;;
for $line at $i in file:read-text-lines(doc.xml)
return
if($i lt 1104869) then () else concat($line,
)
Where doc.xml is a large document.
The result of the query seems to never end and its memory footprint is huge.
To manage notifications about this bug go to:
https://bugs.launchpad.net/zorba/+bug/921458/+subscriptions
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 921458] Re: file:read-text-lines() blocking
Even without streaming this program doesn't seem to work -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/921458 Title: file:read-text-lines() blocking Status in Zorba - The XQuery Processor: New Bug description: I wrote the following query: import module namespace file =http://expath.org/ns/file;; for $line at $i in file:read-text-lines(doc.xml) return if($i lt 1104869) then () else concat($line, ) Where doc.xml is a large document. The result of the query seems to never end and its memory footprint is huge. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/921458/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/plan-serializer
into lp:zorba.
Requested reviews:
Zorba Coders (zorba-coders)
Chris Hillery (ceejatec)
Markos Zaharioudakis (markos-za)
Related bugs:
Bug #924205 in Zorba: test converters/base64/binaryReadWrite.xq fails with
plan serializer
https://bugs.launchpad.net/zorba/+bug/924205
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174
Fix in plan serializer about preparing user_functions plan for serialization.
--
https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174
Your team Zorba Coders is requested to review the proposed merge of
lp:~zorba-coders/zorba/plan-serializer into lp:zorba.
=== modified file 'src/api/xqueryimpl.cpp'
--- src/api/xqueryimpl.cpp 2012-01-11 17:30:25 +
+++ src/api/xqueryimpl.cpp 2012-02-01 21:49:22 +
@@ -193,7 +193,8 @@
}
else
{
-ar.compiler_cb = theCompilerCB;
+//ar.compiler_cb = theCompilerCB;
+theCompilerCB-prepare_for_serialize();
}
ar theCompilerCB;
=== modified file 'src/compiler/api/compilercb.cpp'
--- src/compiler/api/compilercb.cpp 2012-01-11 17:30:25 +
+++ src/compiler/api/compilercb.cpp 2012-02-01 21:49:22 +
@@ -27,6 +27,7 @@
#include system/properties.h
#include zorbaserialization/serialization_engine.h
+#include functions/udf.h
namespace zorba
@@ -120,6 +121,7 @@
theTimeout(timeout),
theTempIndexCounter(0)
{
+ theLocalUdfs = new rclistuser_function*;
}
@@ -143,6 +145,7 @@
theTempIndexCounter(0),
theConfig(cb.theConfig)
{
+ theLocalUdfs = new rclistuser_function*;
}
@@ -169,6 +172,20 @@
{
}
+//compile all the user_functions so the expr tree is stable at serialize
+void CompilerCB::prepare_for_serialize()
+{
+ rclistuser_function*::iterator udf_it;
+ for(udf_it=theLocalUdfs-begin(); udf_it != theLocalUdfs-end(); udf_it++)
+ {
+(*udf_it)-prepare_for_serialize(this);
+ }
+}
+
+rchandlerclistuser_function* CompilerCB::get_local_udfs()
+{
+ return theLocalUdfs;
+}
/***
=== modified file 'src/compiler/api/compilercb.h'
--- src/compiler/api/compilercb.h 2012-01-11 17:30:25 +
+++ src/compiler/api/compilercb.h 2012-02-01 21:49:22 +
@@ -29,7 +29,7 @@
// without having the definition of static_context availble.
# include context/static_context.h
#endif
-
+#include zorbatypes/rclist.h
#include zorbaserialization/class_serializer.h
namespace zorba {
@@ -39,7 +39,6 @@
#endif
class static_context;
-
/***
There is one CompilerCB per query plus one CompilerCB per invocation of an
eval or xqdoc expression that appears in the query. The query-level ccb is
@@ -167,10 +166,14 @@
configtheConfig;
+ rchandlerclistuser_function* theLocalUdfs;//for plan serializer
+
public:
SERIALIZABLE_CLASS(CompilerCB);
CompilerCB(::zorba::serialization::Archiver ar);
void serialize(::zorba::serialization::Archiver ar);
+ void prepare_for_serialize();
+ rchandlerclistuser_function* get_local_udfs();
public:
CompilerCB(XQueryDiagnostics*, long timeout = -1);
=== modified file 'src/compiler/expression/flwor_expr.cpp'
--- src/compiler/expression/flwor_expr.cpp 2011-12-21 14:40:33 +
+++ src/compiler/expression/flwor_expr.cpp 2012-02-01 21:49:22 +
@@ -803,7 +803,7 @@
flwor_clause_t materialize_clause::clone(expr::substitution_t subst) const
{
- ZORBA_ASSERT(false);
+ return new materialize_clause(theContext, get_loc());
}
=== modified file 'src/compiler/expression/ftnode.cpp'
--- src/compiler/expression/ftnode.cpp 2011-07-17 20:05:49 +
+++ src/compiler/expression/ftnode.cpp 2012-02-01 21:49:22 +
@@ -363,7 +363,7 @@
void ftextension_selection::serialize( serialization::Archiver ar ) {
serialize_baseclass( ar, (ftprimary*)this );
- ar pragmas_;
+ //ar pragmas_;
ar ftselection_;
}
@@ -392,7 +392,7 @@
void ftextension_option::serialize( serialization::Archiver ar ) {
serialize_baseclass( ar, (ftmatch_option*)this );
- ar qname_;
+ //ar qname_;
ar val_;
}
=== modified file 'src/compiler/expression/var_expr.cpp'
--- src/compiler/expression/var_expr.cpp 2012-01-11 17:30:25 +
+++ src/compiler/expression/var_expr.cpp 2012-02-01 21:49:22 +
@@ -134,6 +134,7 @@
ar theCopyClause;
ar theParamPos;
ar theUDF;
+ ar theSetExprs;
ar theIsPrivate;
ar theIsExternal;
ar theIsMutable;
=== modified file 'src/compiler/rewriter/rules/flwor_rules.cpp'
--- src/compiler/rewriter/rules/flwor_rules.cpp 2011-09-02 20:43:46 +
+++ src/compiler/rewriter/rules/flwor_rules.cpp 2012-02-01 21:49:22 +
@@ -627,6 +627,10 @@
{
// TODO
}
+else if (kind == flwor_clause::materialize_clause)
+{
+ // TODO
+}
else
{
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/plan-serializer into lp:zorba has been updated. Commit Message changed to: several fixes for the plan serializer + implemented materialize_clause::clone() For more details, see: https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/plan-serializer-2012-02-01T21-51-04.553Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 924205] Re: test converters/base64/binaryReadWrite.xq fails with plan serializer
** Changed in: zorba Assignee: Markos Zaharioudakis (markos-za) = Matthias Brantner (matthias-brantner) ** Changed in: zorba Milestone: None = 2.2 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/924205 Title: test converters/base64/binaryReadWrite.xq fails with plan serializer Status in Zorba - The XQuery Processor: New Bug description: The test converters/base64/binaryReadWrite.xq fails with plan serializer in debug mode. In release mode on Win32 it seems to work. There is an assert in materialize_clause::clone() . The stack for the assert is: zorba_simplestore.dll!zorba::assertion_failed(const char * condition, const char * file, int line) Line 66 + 0x4c bytesC++ zorba_simplestore.dll!zorba::materialize_clause::clone(std::mapzorba::expr const *,zorba::rchandlezorba::expr,std::lesszorba::expr const *,std::allocatorstd::pairzorba::expr const * const,zorba::rchandlezorba::expr subst) Line 806 + 0x1d bytes C++ zorba_simplestore.dll!zorba::flwor_expr::clone(std::mapzorba::expr const *,zorba::rchandlezorba::expr,std::lesszorba::expr const *,std::allocatorstd::pairzorba::expr const * const,zorba::rchandlezorba::expr subst) Line 1225 + 0x30 bytes C++ zorba_simplestore.dll!zorba::InlineFunctions::rewritePost(zorba::expr * node, zorba::RewriterContext rCtx) Line 1083 + 0x3a bytesC++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 60 + 0x1e bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::RuleMajorDriver::rewrite(zorba::RewriterContext rCtx) Line 61 + 0x55 bytes C++ zorba_simplestore.dll!zorba::DefaultOptimizer::rewrite(zorba::RewriterContext rCtx) Line 83 + 0xf bytes C++ zorba_simplestore.dll!zorba::user_function::getPlan(zorba::CompilerCB * ccb, unsigned int planStateSize) Line 388 + 0x4d bytes C++ zorba_simplestore.dll!zorba::user_function::prepare_for_serialize(zorba::CompilerCB * compilerCB) Line 102 + 0x14 bytesC++ zorba_simplestore.dll!zorba::CompilerCB::prepare_for_serialize() Line 182 C++ zorba_simplestore.dll!zorba::XQueryImpl::serialize(zorba::serialization::Archiver ar) Line 200 C++ zorba_simplestore.dll!zorba::XQueryImpl::saveExecutionPlan(std::basic_ostreamchar,std::char_traitschar os, Zorba_binary_plan_format_t archive_format, Zorba_save_plan_options_t save_options) Line 922 C++ To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/924205/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/stack into lp:~zorba-coders/zorba/zorba-experimental
The proposal to merge lp:~zorba-coders/zorba/stack into lp:~zorba-coders/zorba/zorba-experimental has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/stack/+merge/91178 -- https://code.launchpad.net/~zorba-coders/zorba/stack/+merge/91178 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/stack into lp:~zorba-coders/zorba/zorba-experimental. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/plan-serializer into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job plan-serializer-2012-02-01T21-51-04.553Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924987 into lp:zorba has been updated. Commit Message changed to: fixes bug 924987 - extended TypeIdentifier to also support schema-element, schema-attribute and namespace-node sequence types - fixed TypeOps::get_type_identifier - added a test to the staticcollectionmanager unit test - added operator for TypeIdentifier For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 -- https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924987 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 -- https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
I killed Matthias' validation queue run, because it wouldn't have proven anything - I didn't have ZORBA_TEST_PLAN_SERIALIZATION ON yet. I'm restarting it now with that flag set. -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 925143] [NEW] CollectionManager in SWIG apis
Public bug reported: Stijn Tonk stijnt...@hotmail.com has made the feature request to provide the CollectionManager API in the swig bindings. Currently, we only expose the DocumentManager. ** Affects: zorba Importance: High Status: New -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/925143 Title: CollectionManager in SWIG apis Status in Zorba - The XQuery Processor: New Bug description: Stijn Tonk stijnt...@hotmail.com has made the feature request to provide the CollectionManager API in the swig bindings. Currently, we only expose the DocumentManager. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/925143/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/DC into lp:zorba/data-cleaning-module
The proposal to merge lp:~diogo-simoes89/zorba/DC into lp:zorba/data-cleaning-module has been updated. Commit Message changed to: Changes in the tests of conversion module: - address-from-phone - address-from-user - phone-from-address - phone-from-user - user-from-address - user-from-phone These changes support variations of the webservices results For more details, see: https://code.launchpad.net/~diogo-simoes89/zorba/DC/+merge/91124 -- https://code.launchpad.net/~diogo-simoes89/zorba/DC/+merge/91124 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/DC into lp:zorba/data-cleaning-module
Review: Approve -- https://code.launchpad.net/~diogo-simoes89/zorba/DC/+merge/91124 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/declare-uri-file into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/declare-uri-file into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 -- https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
Validation queue job plan-serializer-2012-02-01T22-06-51.313Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 4 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
Review: Approve Looks good! Please don't re-Approved this merge proposal yet. I'll need to re-enable ZORBA_TEST_PLAN_SERIALIZATION one last time for the final submission. Once there's two Approve votes I'll do that. -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/plan-serializer into lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba
Validation queue job bug924987-2012-02-01T22-33-57.831Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~diogo-simoes89/zorba/DC into lp:zorba/data-cleaning-module
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/DC-2012-02-01T22-59-07.423Z/log.html -- https://code.launchpad.net/~diogo-simoes89/zorba/DC/+merge/91124 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 1 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924987 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924987 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 -- https://code.launchpad.net/~zorba-coders/zorba/bug924987/+merge/91144 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/declare-uri-file into lp:zorba
Validation queue job declare-uri-file-2012-02-01T23-55-57.921Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/declare-uri-file into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/declare-uri-file into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 -- https://code.launchpad.net/~zorba-coders/zorba/declare-uri-file/+merge/91049 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 921458] Re: file:read-text-lines() blocking
In the original query, where does the value of $i come from? -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/921458 Title: file:read-text-lines() blocking Status in Zorba - The XQuery Processor: New Bug description: I wrote the following query: import module namespace file =http://expath.org/ns/file;; for $line at $i in file:read-text-lines(doc.xml) return if($i lt 1104869) then () else concat($line, ) Where doc.xml is a large document. The result of the query seems to never end and its memory footprint is huge. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/921458/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 921458] Re: file:read-text-lines() blocking
for $line at _$i_ -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/921458 Title: file:read-text-lines() blocking Status in Zorba - The XQuery Processor: New Bug description: I wrote the following query: import module namespace file =http://expath.org/ns/file;; for $line at $i in file:read-text-lines(doc.xml) return if($i lt 1104869) then () else concat($line, ) Where doc.xml is a large document. The result of the query seems to never end and its memory footprint is huge. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/921458/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/plan-serializer into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/plan-serializer-2012-02-02T01-07-10.053Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 921458] Re: file:read-text-lines() blocking
It doesn't stream because the StreamableString is materializing the string. Sticking an assert() in materialize() shows the stack trace: #0 0x7fff8157482a in __kill () #1 0x7fff830e0a9c in abort () #2 0x7fff831135de in __assert_rtn () #3 0x00010aa19df4 in zorba::simplestore::StreamableStringItem::materialize (this=0x7fc67a6865a0) at atomic_items.cpp:1772 #4 0x00010aa1d596 in zorba::simplestore::StreamableStringItem::getStringValue2 (this=0x7fc67a6865a0, val=@0x7fff68c3b018) at atomic_items.cpp:1693 #5 0x00010a1e137e in zorba::FnTokenizeIterator::nextImpl (this=0x7fc67a6aede0, result=@0x7fff68c3be80, planState=@0x7fc67a679940) at strings_impl.cpp:1706 #6 0x00010a1d2e2c in zorba::Batcherzorba::FnTokenizeIterator::produceNext (this=0x7fc67a6aede0, result=@0x7fff68c3be80, planState=@0x7fc67a679940) at plan_iterator.h:531 #7 0x00010a248815 in zorba::PlanIterator::consumeNext (result=@0x7fff68c3be80, iter=0x7fc67a6aede0, planState=@0x7fc67a679940) at plan_iterator.cpp:124 #8 0x000109ec835a in zorba::FunctionTraceIterator::nextImpl (this=0x7fc67a682b10, result=@0x7fff68c3be80, aPlanState=@0x7fc67a679940) at other_diagnostics_impl.cpp:43 #9 0x0001093df3c8 in zorba::Batcherzorba::FunctionTraceIterator::produceNext (this=0x7fc67a682b10, result=@0x7fff68c3be80, planState=@0x7fc67a679940) at plan_iterator.h:531 #10 0x00010a248815 in zorba::PlanIterator::consumeNext (result=@0x7fff68c3be80, iter=0x7fc67a682b10, planState=@0x7fc67a679940) at plan_iterator.cpp:124 #11 0x00010a346b54 in zorba::UDFunctionCallIterator::nextImpl (this=0x7fc67a6a17c0, result=@0x7fff68c3be80, planState=@0x7fc67a679a20) at fncall_iterator.cpp:490 #12 0x00010a350804 in zorba::Batcherzorba::UDFunctionCallIterator::produceNext (this=0x7fc67a6a17c0, result=@0x7fff68c3be80, planState=@0x7fc67a679a20) at plan_iterator.h:531 #13 0x00010a248815 in zorba::PlanIterator::consumeNext (result=@0x7fff68c3be80, iter=0x7fc67a6a17c0, planState=@0x7fc67a679a20) at plan_iterator.cpp:124 #14 0x00010a310ccb in zorba::flwor::FLWORIterator::bindVariable (this=0x7fc67a6e6b50, varNo=0, iterState=0x7fc67a675c50, planState=@0x7fc67a679a20) at flwor_iterator.cpp:1199 #15 0x00010a31162a in zorba::flwor::FLWORIterator::nextImpl (this=0x7fc67a6e6b50, result=@0x7fff68c3c478, planState=@0x7fc67a679a20) at flwor_iterator.cpp:948 #16 0x00010a31c3ce in zorba::Batcherzorba::flwor::FLWORIterator::produceNext (this=0x7fc67a6e6b50, result=@0x7fff68c3c478, planState=@0x7fc67a679a20) at plan_iterator.h:531 #17 0x00010a248815 in zorba::PlanIterator::consumeNext (result=@0x7fff68c3c478, iter=0x7fc67a6e6b50, planState=@0x7fc67a679a20) at plan_iterator.cpp:124 #18 0x00010a246e91 in zorba::PlanWrapper::next (this=0x7fc67b002660, result=@0x7fff68c3c478) at plan_wrapper.cpp:149 #19 0x00010916e306 in zorba::serializer::serialize (this=0x7fff68c3c808, aObject=@0x7fff68c3c730, aOStream=@0x7fff72b43f70, aHandler=0x0) at serializer.cpp:2257 #20 0x00010916e5d5 in zorba::serializer::serialize (this=0x7fff68c3c808, aObject=@0x7fff68c3c8d8, aOStream=@0x7fff72b43f70) at serializer.cpp:2215 #21 0x00010909fe8f in zorba::XQueryImpl::serialize (this=0x7fc67a675330, os=@0x7fff72b43f70, aWrapper=@0x7fff68c3c998, opt=0x7fff68c3cc60) at xqueryimpl.cpp:1290 #22 0x0001090a1203 in zorba::XQueryImpl::execute (this=0x7fc67a675330, os=@0x7fff72b43f70, opt=0x7fff68c3cc60) at xqueryimpl.cpp:1116 #23 0x0001090448d4 in compileAndExecute (zorbaInstance=0x10b31daa0, properties=@0x7fff68c3db60, staticContext=@0x7fff68c3d8b8, qfilepath=@0x7fff68c3d8d0, qfile=@0x7fc67a674d60, outputStream=@0x7fff72b43f70, timing=@0x7fff68c3d4a8) at zorbacmd.cpp:634 #24 0x00010904898b in main (argc=4, argv=0x7fff68c3e328) at zorbacmd.cpp:906 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/921458 Title: file:read-text-lines() blocking Status in Zorba - The XQuery Processor: New Bug description: I wrote the following query: import module namespace file =http://expath.org/ns/file;; for $line at $i in file:read-text-lines(doc.xml) return if($i lt 1104869) then () else concat($line, ) Where doc.xml is a large document. The result of the query seems to never end and its memory footprint is huge. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/921458/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 921458] Re: file:read-text-lines() blocking
Oh wait you said *with* the patch. It would help if he/you attached the patch as a patch to the bug. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/921458 Title: file:read-text-lines() blocking Status in Zorba - The XQuery Processor: New Bug description: I wrote the following query: import module namespace file =http://expath.org/ns/file;; for $line at $i in file:read-text-lines(doc.xml) return if($i lt 1104869) then () else concat($line, ) Where doc.xml is a large document. The result of the query seems to never end and its memory footprint is huge. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/921458/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
Validation queue job plan-serializer-2012-02-02T01-07-10.053Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/plan-serializer into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/plan-serializer into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 -- https://code.launchpad.net/~zorba-coders/zorba/plan-serializer/+merge/91174 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 924205] Re: test converters/base64/binaryReadWrite.xq fails with plan serializer
** Changed in: zorba Status: New = Fix Committed -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/924205 Title: test converters/base64/binaryReadWrite.xq fails with plan serializer Status in Zorba - The XQuery Processor: Fix Committed Bug description: The test converters/base64/binaryReadWrite.xq fails with plan serializer in debug mode. In release mode on Win32 it seems to work. There is an assert in materialize_clause::clone() . The stack for the assert is: zorba_simplestore.dll!zorba::assertion_failed(const char * condition, const char * file, int line) Line 66 + 0x4c bytesC++ zorba_simplestore.dll!zorba::materialize_clause::clone(std::mapzorba::expr const *,zorba::rchandlezorba::expr,std::lesszorba::expr const *,std::allocatorstd::pairzorba::expr const * const,zorba::rchandlezorba::expr subst) Line 806 + 0x1d bytes C++ zorba_simplestore.dll!zorba::flwor_expr::clone(std::mapzorba::expr const *,zorba::rchandlezorba::expr,std::lesszorba::expr const *,std::allocatorstd::pairzorba::expr const * const,zorba::rchandlezorba::expr subst) Line 1225 + 0x30 bytes C++ zorba_simplestore.dll!zorba::InlineFunctions::rewritePost(zorba::expr * node, zorba::RewriterContext rCtx) Line 1083 + 0x3a bytesC++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 60 + 0x1e bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::PrePostRewriteRule::apply(zorba::RewriterContext rCtx, zorba::expr * curExpr, bool modified) Line 51 + 0x31 bytes C++ zorba_simplestore.dll!zorba::RuleMajorDriver::rewrite(zorba::RewriterContext rCtx) Line 61 + 0x55 bytes C++ zorba_simplestore.dll!zorba::DefaultOptimizer::rewrite(zorba::RewriterContext rCtx) Line 83 + 0xf bytes C++ zorba_simplestore.dll!zorba::user_function::getPlan(zorba::CompilerCB * ccb, unsigned int planStateSize) Line 388 + 0x4d bytes C++ zorba_simplestore.dll!zorba::user_function::prepare_for_serialize(zorba::CompilerCB * compilerCB) Line 102 + 0x14 bytesC++ zorba_simplestore.dll!zorba::CompilerCB::prepare_for_serialize() Line 182 C++ zorba_simplestore.dll!zorba::XQueryImpl::serialize(zorba::serialization::Archiver ar) Line 200 C++ zorba_simplestore.dll!zorba::XQueryImpl::saveExecutionPlan(std::basic_ostreamchar,std::char_traitschar os, Zorba_binary_plan_format_t archive_format, Zorba_save_plan_options_t save_options) Line 922 C++ To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/924205/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 921458] Re: file:read-text-lines() blocking
*With* William's patch, the query works for me and the string is never materialized (where x.xq is William's query): $ time bin/zorba -f -q /tmp/x.xq # ... output elided ... real0m58.719s user0m57.956s sys 0m0.483s It takes longer than it should, but it does run to completion in a not- too-long amount of time. However, the performance is pretty bad considering: $ time wc -l /tmp/doc.xml 1798219 /tmp/doc.xml real0m0.085s user0m0.069s sys 0m0.016s -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/921458 Title: file:read-text-lines() blocking Status in Zorba - The XQuery Processor: New Bug description: I wrote the following query: import module namespace file =http://expath.org/ns/file;; for $line at $i in file:read-text-lines(doc.xml) return if($i lt 1104869) then () else concat($line, ) Where doc.xml is a large document. The result of the query seems to never end and its memory footprint is huge. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/921458/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 921458] Re: file:read-text-lines() blocking
Oh, since the string isn't materialized, that means it *must* be streaming so it's not clear there's anything to fix... assigning back to you. ** Changed in: zorba Assignee: Paul J. Lucas (paul-lucas) = Matthias Brantner (matthias-brantner) -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/921458 Title: file:read-text-lines() blocking Status in Zorba - The XQuery Processor: New Bug description: I wrote the following query: import module namespace file =http://expath.org/ns/file;; for $line at $i in file:read-text-lines(doc.xml) return if($i lt 1104869) then () else concat($line, ) Where doc.xml is a large document. The result of the query seems to never end and its memory footprint is huge. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/921458/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental
The proposal to merge lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq/+merge/90824 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq/+merge/90824 Your team Zorba Coders is requested to review the proposed merge of lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental
The proposal to merge lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental has been updated. Commit Message changed to: ... For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq/+merge/91198 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq/+merge/91198 Your team Zorba Coders is requested to review the proposed merge of lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental
The proposal to merge lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq/+merge/91198 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq/+merge/91198 Your team Zorba Coders is requested to review the proposed merge of lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental
The attempt to merge lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental failed. Below is the output from the failed tests. experimental build started for lp:zorba/3.0. Check out http://3.0.zorba-xquery.com/ in half an hour or so. Logfile at http://zorbatest.lambda.nu:8080/remotequeue/experimental/3.0.log . -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq/+merge/91198 Your team Zorba Coders is requested to review the proposed merge of lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental
The proposal to merge lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq/+merge/91198 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq/+merge/91198 Your team Zorba Coders is requested to review the proposed merge of lp:zorba/3.0 into lp:~zorba-coders/zorba/zorba-experimental. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/iframe into lp:zorba
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/iframe into lp:zorba. Requested reviews: Matthias Brantner (matthias-brantner) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/iframe/+merge/91202 don't output empty iframe elements for html serialization -- https://code.launchpad.net/~zorba-coders/zorba/iframe/+merge/91202 Your team Zorba Coders is subscribed to branch lp:zorba. === modified file 'ChangeLog' --- ChangeLog 2012-02-01 16:36:44 + +++ ChangeLog 2012-02-02 05:56:19 + @@ -34,6 +34,7 @@ * Fixed bug #918211 (xqueryx fulltext w3c conformance generation) * Fixed bug #918157 (Add XQFTTS to validation queue) * Fixed bug with unversioned modules with C++ external functions + * Don't output empty iframe elements when serializing as html version 2.1 === modified file 'src/api/serialization/serializer.cpp' --- src/api/serialization/serializer.cpp 2012-01-11 17:30:25 + +++ src/api/serialization/serializer.cpp 2012-02-02 05:56:19 + @@ -984,12 +984,10 @@ zstring nodename; utf8::to_lower(item-getNodeName()-getStringValue(), nodename); - if (ztd::equals(nodename, script, 6) || + return (ztd::equals(nodename, script, 6) || ztd::equals(nodename, textarea, 8) || - ztd::equals(nodename, div, 3)) -return true; - else -return false; + ztd::equals(nodename, iframe, 6) || + ztd::equals(nodename, div, 3)); } -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/iframe into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/iframe/+merge/91202 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
