Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug938320 into lp:zorba

2012-08-27 Thread Chris Hillery
Review: Needs Information General question: Is there a reason you created ZorbaIOStream rather than using normal C++ iostreams? It seems like re-inventing the wheel, and it also makes it harder to use this feature with streams from other sources. Also, comments in swig/Item.h are inaccurate - a

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/doxygen_xml_generation into lp:zorba

2012-08-27 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/doxygen_xml_generation into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/doxygen_xml_generation/+merge/121349 -- https://code.launchpad.net/~zorba-coders/zorba/doxygen

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/doxygen_xml_generation into lp:zorba

2012-08-27 Thread Zorba Build Bot
Validation queue job doxygen_xml_generation-2012-08-28T00-20-57.476Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/doxygen_xml_generation/+merge/121349 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bang_operator into lp:zorba

2012-08-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bang_operator/+merge/121347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/doxygen_xml_generation into lp:zorba

2012-08-27 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/doxygen_xml_generation-2012-08-28T00-20-57.476Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/doxygen_xml_generation/+merge/121349 Your team Zorba Coders is subscribed to branch lp:zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/doxygen_xml_generation into lp:zorba

2012-08-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/doxygen_xml_generation into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/doxygen_xml_generation/+merge/121349 -- https://code.launchpad.net/~zorba-coders/zorba/d

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/doxygen_xml_generation into lp:zorba

2012-08-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/doxygen_xml_generation/+merge/121349 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.ne

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1040558 into lp:zorba

2012-08-27 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/bug-1040558 into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1040558/+merge/120956 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1040558/+merge/120956 You

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1040558 into lp:zorba

2012-08-27 Thread Zorba Build Bot
Validation queue job bug-1040558-2012-08-27T20-44-57.648Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1040558/+merge/120956 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-c

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1040558 into lp:zorba

2012-08-27 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1040558-2012-08-27T20-44-57.648Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1040558/+merge/120956 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: h

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1040558 into lp:zorba

2012-08-27 Thread Luis Rodriguez Gonzalez
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1040558/+merge/120956 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1040558 into lp:zorba

2012-08-27 Thread Luis Rodriguez Gonzalez
The proposal to merge lp:~zorba-coders/zorba/bug-1040558 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1040558/+merge/120956 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1040558/+merge/1209

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1040558 into lp:zorba

2012-08-27 Thread Juan Zacarias
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1040558/+merge/120956 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-27 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-27 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-27 Thread Zorba Build Bot
Validation queue job jsoniq-static-casts-2012-08-27T16-42-57.41Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-27 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-static-casts-2012-08-27T16-42-57.41Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-27 Thread Matthias Brantner
Review: Approve JSONItem::unfix contains a "return" statement before an assertion. Not sure if that's on purpose. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba

2012-08-27 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/jsoniq-static-casts into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-static-casts/+merge/118961 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/doxygen_xml_generation into lp:zorba

2012-08-27 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/doxygen_xml_generation/+merge/121349 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.ne

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bang_operator into lp:zorba

2012-08-27 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bang_operator/+merge/121347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba

2012-08-27 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/structural-any-uri-lazy/+merge/104918 -- https://code.launchpad.net/~zorba-coders/zorba/struc

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba

2012-08-27 Thread Zorba Build Bot
Validation queue job structural-any-uri-lazy-2012-08-27T15-25-59.316Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/structural-any-uri-lazy/+merge/104918 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba

2012-08-27 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/structural-any-uri-lazy-2012-08-27T15-25-59.316Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/structural-any-uri-lazy/+merge/104918 Your team Zorba Coders is subscribed to branch lp:zor

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba

2012-08-27 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/structural-any-uri-lazy/+merge/104918 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba

2012-08-27 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/structural-any-uri-lazy/+merge/104918 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba

2012-08-27 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba has been updated. Commit Message changed to: Made URI computation lazy in StructuralAnyUri. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/structural-any-uri-lazy/+merge/104918 -- https://

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_867094 into lp:zorba

2012-08-27 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_867094/+merge/121405 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_867094 into lp:zorba

2012-08-27 Thread Sorin Marian Nasoi
Sorin Marian Nasoi has proposed merging lp:~zorba-coders/zorba/fix_bug_867094 into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) Related bugs: Bug #867094 in Zorba: "XQTSX failures due to W3C bugs" https://bugs.launchpad.net/zorba/+bug/867094 For more details, see: https://code.

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_969251 into lp:zorba

2012-08-27 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/fix_bug_969251 into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_969251/+merge/108679 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_969251/+merge/1

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_969251 into lp:zorba

2012-08-27 Thread Zorba Build Bot
Validation queue job fix_bug_969251-2012-08-27T09-56-00.342Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_969251/+merge/108679 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~z

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_969251 into lp:zorba

2012-08-27 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fix_bug_969251-2012-08-27T09-56-00.342Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_969251/+merge/108679 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing l

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_969251 into lp:zorba

2012-08-27 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/fix_bug_969251 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_969251/+merge/108679 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_969251/+m

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_969251 into lp:zorba

2012-08-27 Thread Ghislain Fourny
Review: Approve Thanks Sorin ;-) -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_969251/+merge/108679 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://laun

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba

2012-08-27 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/structural-any-uri-lazy/+merge/104918 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba

2012-08-27 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/structural-any-uri-lazy/+merge/104918 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.n

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/structural-any-uri-lazy into lp:zorba

2012-08-27 Thread Markos Zaharioudakis
Hi Ghislain, The point of the non-const param is to call take() inside the constructor, thus saving a (synchronized) ref counting. I have now added this take() call in the StructuralAnyURIItem constructor. You are right about the static casts. I thought that getAnyUriTypeCode() was a zorba::It