Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba_FOTS_driver into lp:zorba

[Matthias Brantner]

Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/zorba_FOTS_driver/+merge/132980
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba_FOTS_driver into lp:zorba

[Sorin Marian Nasoi]

@Matthias: Let me ask you if I may: which of the issues you reported are a show 
stopper for merging the FOTS driver into Zorba?

Can you please list them with the appropriate reported Launchpad issues?

This will help me a lot in addressing them asap.

Thanks for your feedback.
-- 
https://code.launchpad.net/~zorba-coders/zorba/zorba_FOTS_driver/+merge/132980
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba_FOTS_driver into lp:zorba

[Sorin Marian Nasoi]

First of all let me mention that this type of communication in Launchpad 
messages is IMHO very hard to follow.

Anyway: this is how you chose to report your issues so here are my remarks 
below.

> Where did the file fots.xq go? Is it replaced by cli.xq? If so, the README.txt
> and the help
> in cli.xq should be adapted.
They were updated: are you using the latest version of the driver?


> I would be nice to get better error messages if one of the command line
> parameters is missing.
> For example,
> 
> ./bin/zorba -f -q ../sandbox/test/fots_driver/cli.xq -e
> fotsPath:=/home/mbrantner/w3c/checkout/2011/QT3-test-suite/  -e mode:=run-
> test-sets -e testSetPrefixes:=prod-WindowClause
> :359,3: type error
> [err:XPTY0004]: empty path; raised at
> /home/mbrantner/zorba/sandbox/src/util/fs_util.cpp:196
> =
> file:read-text#1 
> /home/mbrantner/zorba/sandbox/test/fots_driver/zorba-fots-driver.xqy at line
> 175 column 40
> =
> driver:run-fots#9 
> /home/mbrantner/zorba/build/../sandbox/test/fots_driver/cli.xq at line 127
> column 10
Please open a Launchpad issue with the "fots-driver" TAG and assign it to me.

 
> Also, I think it became to hard to use. It would be nice if at least the path
> to the manifest
> file doesn't need to be given on the command line. Maybe a CMake-configured
> bash/bat
> script in the build directory would help to make it easier to run.
My experience with what you are proposing is this:
- it makes it easier to use, it is true
- everyone will forget what params were set in the file or that a file even 
exists. This makes it very hard to debug the reported issues because you also 
have to send the file with the configured params.

Also one needs to set different options to see what happens: for instance what 
happens when you enable the HOF feature? You can easily create a new 
ZorbaManifest_HOF_ENABLED.xml and invoke teh CLI with that file.
You see the difference in a second, you to not need to change any configuration 
file.

I would vote against your proposal.

 
> >> - Rename fots_driver to fots
> >> - Rename zorba-fots-driver.xqy to fots-driver.xq
> > People must get used to the terminology:
> > - FOTS means the testsuite from W3C: hence when a test is wrong => file a
> bug to W3C
> > - FOTS driver is the thing that runs the testsuite: hence when an error is
> detected in the FOTS driver = > file a bug in Launchpad with a "fots-driver"
> TAG
> > - test case is a single test
> > - test set is unit (a bunch) of tests grouped together because they test a
> certain feature/function/functionality
> >
> > The renaming you suggest would confuse people.
> At least the zorba in zorba-fots-driver is redundant.
No it is not: if we decide to put it in FOTS/drivers together with the Saxon, 
BaseX it will make sense right?

> >> - We generally use xq instead of xqy for xquery files. Maybe we should do
> this
> >> here to.
> > If you really insist then I can rename the files, sure...
> It's not a strong reject but I love consistency in the repository.
Please open a Launchpad issue with the "fots-driver" TAG and assign it to me.


> >> - Does the dependency output have to appear in every run?
> > Do not know what you mean by "dependency output": can you please be more
> specific?
> The output file is very verbose. At the beginning, it contains a huge list
> starting with the dependencies-satisfied
> file. Does it need to be there.
> 
> The output of a failing test is very long. You can't immediately see why
> something fails.
> For example,
> 
>   
> 
> 
> 
> let $MAX_DIFF := 2
> 
> for sliding window $w in ./stream/event
>   start  $s_curr at $s_pos previous $s_prev
> when ($s_curr/@time ne $s_prev/@time) or (empty($s_prev))
>   only end next $e_next
> when $e_next/@time - $s_curr/@time gt $MAX_DIFF
> return
>   avg( $w/@temp )
>   
> 
>   8 9 17 18
> 
> 
>   
> 
>temp_events.xml from the XQuery 3.0 Use Cases
> 
>   
> 
>   
>   import module namespace xqxq = 'http://www.zorba-
> xquery.com/modules/xqxq';
> variable $queryID := xqxq:prepare-main-module('
> xquery version ''3.0'';
> 
> 
> 
> let $MAX_DIFF := 2
> 
> for sliding window $w in ./stream/event
>   start  $s_curr at $s_pos previous $s_prev
> when ($s_curr/@time ne $s_prev/@time) or (empty($s_prev))
>   only end next $e_next
> when $e_next/@time - $s_curr/@time gt $MAX_DIFF
> return
>   avg( $w/@temp )
>   '
> );
> variable $contextItem := doc("/home/mbrantner/w3c/checkout/2011/QT3-test-
> suite//prod/WindowClause/temp_events.xml");
> xqxq:bind-context-item($queryID, $contextItem);
> 
> 
> xqxq:evaluate($queryID)
>   
> 
>   8 9 17 18
> 
> 8 9 17 18
>   

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba_FOTS_driver into lp:zorba

[Matthias Brantner]

Where did the file fots.xq go? Is it replaced by cli.xq? If so, the README.txt 
and the help
in cli.xq should be adapted.

I would be nice to get better error messages if one of the command line 
parameters is missing.
For example,

./bin/zorba -f -q ../sandbox/test/fots_driver/cli.xq -e 
fotsPath:=/home/mbrantner/w3c/checkout/2011/QT3-test-suite/  -e 
mode:=run-test-sets -e testSetPrefixes:=prod-WindowClause
:359,3: type error 
[err:XPTY0004]: empty path; raised at 
/home/mbrantner/zorba/sandbox/src/util/fs_util.cpp:196 
=
file:read-text#1  
/home/mbrantner/zorba/sandbox/test/fots_driver/zorba-fots-driver.xqy at line 
175 column 40
=
driver:run-fots#9  
/home/mbrantner/zorba/build/../sandbox/test/fots_driver/cli.xq at line 127 
column 10


Also, I think it became to hard to use. It would be nice if at least the path 
to the manifest
file doesn't need to be given on the command line. Maybe a CMake-configured 
bash/bat
script in the build directory would help to make it easier to run.

>> - Rename fots_driver to fots
>> - Rename zorba-fots-driver.xqy to fots-driver.xq
> People must get used to the terminology:
> - FOTS means the testsuite from W3C: hence when a test is wrong => file a bug 
> to W3C
> - FOTS driver is the thing that runs the testsuite: hence when an error is 
> detected in the FOTS driver = > file a bug in Launchpad with a "fots-driver" 
> TAG
> - test case is a single test
> - test set is unit (a bunch) of tests grouped together because they test a 
> certain feature/function/functionality
> 
> The renaming you suggest would confuse people.
At least the zorba in zorba-fots-driver is redundant.

>> - We generally use xq instead of xqy for xquery files. Maybe we should do 
>> this
>> here to.
> If you really insist then I can rename the files, sure...
It's not a strong reject but I love consistency in the repository.

> 
>> - Does the dependency output have to appear in every run?
> Do not know what you mean by "dependency output": can you please be more 
> specific?
The output file is very verbose. At the beginning, it contains a huge list 
starting with the dependencies-satisfied
file. Does it need to be there.

The output of a failing test is very long. You can't immediately see why 
something fails.
For example,

  



let $MAX_DIFF := 2

for sliding window $w in ./stream/event
  start  $s_curr at $s_pos previous $s_prev
when ($s_curr/@time ne $s_prev/@time) or (empty($s_prev))
  only end next $e_next
when $e_next/@time - $s_curr/@time gt $MAX_DIFF
return
  avg( $w/@temp )
  

  8 9 17 18


  

   temp_events.xml from the XQuery 3.0 Use Cases 

  

  
  import module namespace xqxq = 
'http://www.zorba-xquery.com/modules/xqxq';
variable $queryID := xqxq:prepare-main-module('
xquery version ''3.0'';



let $MAX_DIFF := 2

for sliding window $w in ./stream/event
  start  $s_curr at $s_pos previous $s_prev
when ($s_curr/@time ne $s_prev/@time) or (empty($s_prev))
  only end next $e_next
when $e_next/@time - $s_curr/@time gt $MAX_DIFF
return
  avg( $w/@temp )
  '
);
variable $contextItem := 
doc("/home/mbrantner/w3c/checkout/2011/QT3-test-suite//prod/WindowClause/temp_events.xml");
xqxq:bind-context-item($queryID, $contextItem);


xqxq:evaluate($queryID)
  

  8 9 17 18

8 9 17 18
Result 
'891718'
 is different from the expected result 
'8 9 17 18'.
  

  


This output contains a lot of stuff that might be helpful in some cases but it 
would be really nice
to just have a summary of the failures and the reason why something failed. 

Also, this test seems to give the correct result but the comparison fails.


Matthias
-- 
https://code.launchpad.net/~zorba-coders/zorba/zorba_FOTS_driver/+merge/132980
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/image-module-head into lp:zorba

[noreply]

The proposal to merge lp:~zorba-coders/zorba/image-module-head into lp:zorba 
has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/image-module-head/+merge/133626
-- 
https://code.launchpad.net/~zorba-coders/zorba/image-module-head/+merge/133626
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/image-module-head into lp:zorba

[Zorba Build Bot]

Validation queue job image-module-head-2012-11-09T18-43-44.962Z is finished. 
The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/image-module-head/+merge/133626
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/image-module-head into lp:zorba

[Zorba Build Bot]

Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/image-module-head-2012-11-09T18-43-44.962Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/image-module-head/+merge/133626
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/image-module-head into lp:zorba

[Matthias Brantner]

The proposal to merge lp:~zorba-coders/zorba/image-module-head into lp:zorba 
has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/image-module-head/+merge/133626
-- 
https://code.launchpad.net/~zorba-coders/zorba/image-module-head/+merge/133626
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/image-module-head into lp:zorba

[Matthias Brantner]

Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/image-module-head/+merge/133626
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1075106 into lp:zorba

[Matthias Brantner]

Review: Needs Fixing

ChangeLog entry is missing.
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1075106/+merge/133612
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1075106 into lp:zorba

[noreply]

The proposal to merge lp:~paul-lucas/zorba/bug-1075106 into lp:zorba has been 
updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1075106/+merge/133612
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1075106/+merge/133612
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1075106 into lp:zorba

[Zorba Build Bot]

Validation queue job bug-1075106-2012-11-09T14-28-50.881Z is finished. The 
final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1075106/+merge/133612
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba

[Zorba Build Bot]

The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba 
has been updated.

Status: Approved => Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
-- 
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1075106 into lp:zorba

[Zorba Build Bot]

Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/bug-1075106-2012-11-09T14-28-50.881Z/log.html
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1075106/+merge/133612
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba

[Zorba Build Bot]

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, 
Needs Fixing < 1, Pending < 1. Got: 1 Needs Fixing, 1 Needs Information.
-- 
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba

[Zorba Build Bot]

Validation queue job xml-in-json-indices-2012-11-09T13-57-20.423Z is finished. 
The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1075106 into lp:zorba

[Paul J. Lucas]

The proposal to merge lp:~paul-lucas/zorba/bug-1075106 into lp:zorba has been 
updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/bug-1075106/+merge/133612
-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1075106/+merge/133612
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba

[Zorba Build Bot]

Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/xml-in-json-indices-2012-11-09T13-57-20.423Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba

[Ghislain Fourny]

Hi Till,

Good catch, it was a double free. Only Linux complained about it. Thanks! It 
should be fixed now, rerunning the tests.
-- 
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba

[Ghislain Fourny]

The proposal to merge lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba 
has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
-- 
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/image-module-head into lp:zorba

[David Graf]

The proposal to merge lp:~zorba-coders/zorba/image-module-head into lp:zorba 
has been updated.

Commit Message changed to:

take image module HEAD (not 2.7 tag)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/image-module-head/+merge/133626
-- 
https://code.launchpad.net/~zorba-coders/zorba/image-module-head/+merge/133626
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/image-module-dont-pass-svg-as-binary into lp:zorba/image-module

[David Graf]

> 
> On Nov 8, 2012, at 6:13 AM, David Graf  wrote:
> 
> >> - getImageFromString: const String aString, should be const String&
> aString,
> > Done
> >> - basic:convert-svg-impl should use basic:convert-svg-string
> > I don't understand. Currently, convert-svg-string invokes convert-svg-impl.
> How should that work the other way round?
> Sorry, I meant to say basic:convert-svg should use basic:convert-svg-string
done
> 
> >>
> >> - we might have to make sure the new module is used in Zorba (edit
> >> ExternalModules.conf)
> > Like this: https://code.launchpad.net/~zorba-coders/zorba/image-module-head?
> Yes. This one should be merged first.
proposed
-- 
https://code.launchpad.net/~zorba-coders/zorba/image-module-dont-pass-svg-as-binary/+merge/131829
Your team Zorba Coders is subscribed to branch lp:zorba/image-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/image-module-head into lp:zorba

[David Graf]

Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/image-module-head/+merge/133626
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/image-module-head into lp:zorba

[David Graf]

David Graf has proposed merging lp:~zorba-coders/zorba/image-module-head into 
lp:zorba.

Commit message:
take image module HEAD (not 2.7 tag)

Requested reviews:
  David Graf (davidagraf)
  Matthias Brantner (matthias-brantner)

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/image-module-head/+merge/133626

take image module HEAD (not 2.7 tag)
-- 
https://code.launchpad.net/~zorba-coders/zorba/image-module-head/+merge/133626
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'modules/ExternalModules.conf'
--- modules/ExternalModules.conf	2012-10-25 00:07:03 +
+++ modules/ExternalModules.conf	2012-11-09 08:40:28 +
@@ -35,7 +35,7 @@
 graphvizbzr  lp:zorba/graphviz-module zorba-2.7
 htmlbzr  lp:zorba/html-module zorba-2.7
 http-client bzr  lp:zorba/http-client-module  zorba-2.7
-image   bzr  lp:zorba/image-modulezorba-2.7
+image   bzr  lp:zorba/image-module
 languages   bzr  lp:zorba/languages-modulezorba-2.7
 oauth   bzr  lp:zorba/oauth-modulezorba-2.7
 process bzr  lp:zorba/process-module  zorba-2.7

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/bug-1075106 into lp:zorba

[David Graf]

Review: Approve


-- 
https://code.launchpad.net/~paul-lucas/zorba/bug-1075106/+merge/133612
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp