Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/141196
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Commit Message changed to:
Mostly added "catch ( ... )" to exception-handlers.
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/141196
--
https://code.launchpad.net/~paul-luca
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been
updated.
Description changed to:
Mostly added "catch ( ... )" to exception-handlers.
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/141196
--
https://code.launchpad.net/~paul-lucas/z
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/pjl-misc into lp:zorba.
Requested reviews:
Paul J. Lucas (paul-lucas)
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/141196
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/141196
Your t
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/llvm/+merge/141181
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
Mo
The proposal to merge lp:~zorba-coders/zorba/llvm into lp:zorba has been
updated.
Commit Message changed to:
Fix build with the following options:
- ZORBA_NO_ICU
- ZORBA_NO_XMLSCHEMA
- ZORBA_NO_FULLTEXT
- ZORBA_WITH_FILE_ACCESS=OFF
For more details, see:
https://code.launchpad.net/~zorba-coders
William Candillon has proposed merging lp:~zorba-coders/zorba/llvm into
lp:zorba.
Commit message:
Fix build with the following options:
- ZORBA_NO_ICU
- ZORBA_NO_XMLSCHEMA
- ZORBA_NO_FULLTEXT
- ZORBA_WITH_FILE_ACCESS=OFF
Requested reviews:
Paul J. Lucas (paul-lucas)
Matthias Brantner (matthi
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/141178
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/141178
Your team Zorba Coders is subscribed
The attempt to merge lp:~nbrinza/zorba/hof into lp:zorba failed. Below is the
output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job hof-2012-12-23T11-01-53.663Z is finished. The final
status was:
60
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/hof-2012-12-23T11-01-53.663Z/log.html
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/141178
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/141178
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/141178
Your team Zorba Coders is subscribed
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated.
Commit Message changed to:
Implementation of higher order functions.
For more details, see:
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/141178
--
https://code.launchpad.net/~nbrinza/zorba/hof/+merge/141178
Your
FYI, return values are still not documented:
ERROR: Return value not documented;
Module: http://www.zorba-xquery.com/modules/couchbase
Function: cb:disconnect
Arity: 1
ERROR: Return value not documented;
Module: http://www.zorba-xquery.com/modules/couchbase
Function: cb
Start testing: Dec 23 02:50 PST
--
3755/4573 Testing: zorba_sqlite_module/test6.xq
3755/4573 Test: zorba_sqlite_module/test6.xq
Command: "/home/ceej/utils/bin/valgrind" "--tool=memcheck" "--leak-check=full"
"--track-fds=yes" "--num-callers=50
There are two memory errors when running the module tests, one in test9, one in
test6. I'm attaching the relevant parts of the valgrind report.
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing li
I believe there's a memory leak. valgrind reports a large block (around 73k) of
memory lost at line 847 in sqlite_module.cpp for most of the tests. This is the
call to sqlite3_open_v2(). After a little debugging, I see that sqlite3_close()
is being called in ConnMap::destroy(). However, accordin
The proposal to merge lp:~zorba-coders/zorba/couchbase-trunk into lp:zorba has
been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk/+merge/135779
--
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk
The attempt to merge lp:~zorba-coders/zorba/couchbase-trunk into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job couchbase-trunk-2012-12-23T10-03-48.68Z is finished.
The
Review: Needs Fixing
Oh, also a typo: the word "prepated" (instead of "prepared") appears in the
XQDoc 6 times.
--
https://code.launchpad.net/~zorba-coders/zorba/zorba-for-sqlite/+merge/139108
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorb
Review: Needs Fixing
Code review comments:
1. Many of the functions are not marked %an:sequential. I believe all of them
should be.
2. s:disconnect() returns xs:anyURI, but the documentation says it returns
"true if everything went OK". I suspect it should be xs:boolean.
See also the discussi
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/couchbase-trunk-2012-12-23T10-03-48.68Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk/+merge/135779
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
The proposal to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba has
been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
--
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-tr
The attempt to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job f-nosql-db-trunk-2012-12-23T09-35-47.636Z is finished.
T
The proposal to merge lp:~zorba-coders/zorba/couchbase-trunk into lp:zorba has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk/+merge/135779
--
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/f-nosql-db-trunk-2012-12-23T09-35-47.636Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Maili
The proposal to merge lp:~zorba-coders/zorba/couchbase-trunk into lp:zorba has
been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk/+merge/135779
--
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk
The attempt to merge lp:~zorba-coders/zorba/couchbase-trunk into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job couchbase-trunk-2012-12-23T09-06-55.865Z is finished.
The
Comment from Matthias:
- rename delete-value function to remove to be consistent with Couchbase
- document errors that may be raised by the functions
- can we make the get and put functions take sequences of keys and values,
respectively
(e.g. nosql:get-text($db as xs:anyURI, $keys as object()* )
The proposal to merge lp:~zorba-coders/zorba/f-nosql-db-trunk into lp:zorba has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-trunk/+merge/136215
--
https://code.launchpad.net/~zorba-coders/zorba/f-nosql-db-tr
I believe Matthias is correct, with the possible exception that if the output
from the Couchbase API itself is a literal JSON *string*, we may want to have
an API to pass that string through to module clients. However, even in that
case, I think there should be another form that parses the JSON
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/couchbase-trunk-2012-12-23T09-06-55.865Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk/+merge/135779
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Review: Needs Fixing
Comment from Matthias:
I think the return values of the view functions should be object()* instead of
xs:string* .
--
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk/+merge/135779
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: ht
The proposal to merge lp:~zorba-coders/zorba/couchbase-trunk into lp:zorba has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk/+merge/135779
--
https://code.launchpad.net/~zorba-coders/zorba/couchbase-trunk
33 matches
Mail list logo
