Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/read-pdf-installer-changes into lp:zorba/read-pdf-module
Its now using ZORBA_FIND_JAR correclty but it seems this didn't solve the problem of the module not working it just builds. The module works on Windows. -- https://code.launchpad.net/~zorba-coders/zorba/read-pdf-installer-changes/+merge/149359 Your team Zorba Coders is subscribed to branch lp:zorba/read-pdf-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/hof-2013-03-04T22-44-26.059Z/log.html -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151635 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151635 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151635 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Commit Message changed to: Implementation of higher order functions. For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151635 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151635 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The attempt to merge lp:~nbrinza/zorba/hof into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job hof-2013-03-04T22-44-26.059Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151635 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151635 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151635 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Commit Message changed to: Implementation of higher order functions. For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151641 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151641 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151641 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151641 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/hof-2013-03-04T23-05-21.304Z/log.html -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151641 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The attempt to merge lp:~nbrinza/zorba/hof into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job hof-2013-03-04T23-05-21.304Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151641 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151641 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151641 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Commit Message changed to: Implementation of higher order functions. For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151650 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151650 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151650 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151650 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/hof-2013-03-04T23-43-28.732Z/log.html -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151650 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
Validation queue job hof-2013-03-04T23-43-28.732Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151650 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Pending. -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151650 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151650 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151650 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba
Review: Approve I approve conditionally. There are still some things that require fixing: 1. The following from the diff doesn't make sense. 547 +zstring lNodeName = child-getNodeName()-getLocalName(); 548 +std::transform( 549 + lNodeName.begin(), lNodeName.end(), 550 + lNodeName.begin(), tolower); 551 + If the options are validated using a schema, there is no need to transform them to lower case because the schema is case-sensitive. Also, the code should validate the namespace of the node, not only the local name. 2. Why is x:canonicalize#1 not implemented on x:canonicalize#2 by specifying the default options in XQuery. 3. x:canonicalize-options-impl needs documentation and should be named x:canonicalize-impl instead. I think (but I'm not sure) that it doesn't go through the RQ if the private function doesn't have sufficient parameter documentation. -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Commit Message changed to: Implementation of higher order functions. For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/hof-2013-03-05T00-49-26.585Z/log.html -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The attempt to merge lp:~nbrinza/zorba/hof into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job hof-2013-03-05T00-49-26.585Z is finished. The final status was: 2 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/hof-2013-03-05T01-36-25.371Z/log.html -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The attempt to merge lp:~nbrinza/zorba/hof into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job hof-2013-03-05T01-36-25.371Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof-merge into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof-merge into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof-merge/+merge/151673 -- https://code.launchpad.net/~nbrinza/zorba/hof-merge/+merge/151673 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof-merge into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/hof-merge-2013-03-05T02-23-32.944Z/log.html -- https://code.launchpad.net/~nbrinza/zorba/hof-merge/+merge/151673 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/pjl-misc into lp:zorba.
Requested reviews:
Paul J. Lucas (paul-lucas)
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674
Added follow_symlink to fs::get_type().
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/runtime/full_text/thesauri/iso2788.cpp'
--- src/runtime/full_text/thesauri/iso2788.cpp 2013-02-07 17:24:36 +
+++ src/runtime/full_text/thesauri/iso2788.cpp 2013-03-05 02:25:27 +
@@ -15,7 +15,7 @@
*/
#include stdafx.h
-#include algorithm/* for lower_bound() */
+#include algorithm/* for equal_range() */
#include cstring
#include util/less.h
=== modified file 'src/util/file.cpp'
--- src/util/file.cpp 2013-02-07 17:24:36 +
+++ src/util/file.cpp 2013-03-05 02:25:27 +
@@ -216,7 +216,7 @@
void file::do_stat() {
#ifdef ZORBA_WITH_FILE_ACCESS
- fs::size_type fs_size;
+ fs::size_type fs_size = 0;
switch ( fs::get_type( c_str(), fs_size ) ) {
case fs::non_existent: type = type_non_existent; break;
case fs::directory : type = type_directory;break;
=== modified file 'src/util/fs_util.cpp'
--- src/util/fs_util.cpp 2013-02-07 17:24:36 +
+++ src/util/fs_util.cpp 2013-03-05 02:25:27 +
@@ -275,20 +275,25 @@
#endif /* ZORBA_WITH_FILE_ACCESS */
-type get_type( char const *path, size_type *size ) {
+type get_type( char const *path, bool follow_symlink, size_type *size ) {
#ifndef WIN32
struct stat st_buf;
- if ( ::stat( path, st_buf ) == -1 ) {
+ int const status = follow_symlink ?
+::stat( path, st_buf ) : ::lstat( path, st_buf );
+ if ( status == -1 ) {
if ( errno == ENOENT )
return non_existent;
-throw ZORBA_IO_EXCEPTION( stat(), path );
+throw ZORBA_IO_EXCEPTION( follow_symlink ? stat() : lstat(), path );
}
if ( S_ISDIR( st_buf.st_mode ) )
return directory;
- if ( size )
-*size = st_buf.st_size;
- if ( S_ISREG( st_buf.st_mode ) )
+ if ( S_ISLNK( st_buf.st_mode ) )
+return link;
+ if ( S_ISREG( st_buf.st_mode ) ) {
+if ( size )
+ *size = st_buf.st_size;
return file;
+ }
return other;
#else
WCHAR wpath[ MAX_PATH ];
=== modified file 'src/util/fs_util.h'
--- src/util/fs_util.h 2013-02-07 17:24:36 +
+++ src/util/fs_util.h 2013-03-05 02:25:27 +
@@ -500,27 +500,37 @@
* Gets the type of the given file.
*
* @param path The full path to check.
+ * @param follow_symlink If \c true follows symbolic links.
* @param size A pointer to a receive the size of the file in bytes. The size
* is set only if it's not \c nullptr and the file's type is \c file.
- * @return Returns said type.
+ * @return If \a path refers to a symbolic link and \a follow_symlink is
+ * \c true, the type returned is of that to which the link refers; if \a path
+ * refers to a symbolic and \a follow_symlink is \c false, returns \c link; if
+ * \a path does not refer to a symbolic link, returns the type of \a path.
*/
-type get_type( char const *path, size_type *size = nullptr );
+type get_type( char const *path, bool follow_symlink = true,
+ size_type *size = nullptr );
/**
* Gets the type of the given file.
*
* @tparam PathStringType The \a path string type.
* @param path The full path to check.
+ * @param follow_symlink If \c true follows symbolic links.
* @param size A pointer to a receive the size of the file in bytes. The size
* is set only if it's not \c nullptr and the file's type is \c file.
- * @return Returns said type.
+ * @return If \a path refers to a symbolic link and \a follow_symlink is
+ * \c true, the type returned is of that to which the link refers; if \a path
+ * refers to a symbolic and \a follow_symlink is \c false, returns \c link; if
+ * \a path does not refer to a symbolic link, returns the type of \a path.
*/
templateclass PathStringType inline
typename std::enable_ifztd::has_c_strPathStringType,
char const* (PathStringType::*)() const::value,
type::type
-get_type( PathStringType const path, size_type *size = nullptr ) {
- return get_type( path.c_str(), size );
+get_type( PathStringType const path, bool follow_symlink = true,
+ size_type *size = nullptr ) {
+ return get_type( path.c_str(), follow_symlink, size );
}
/**
=== modified file 'src/util/string_util.cpp'
--- src/util/string_util.cpp 2013-02-07 17:24:36 +
+++ src/util/string_util.cpp 2013-03-05 02:25:27 +
@@ -28,8 +28,8 @@
// Windows doesn't have these functions -- add them ourselves.
- static float strtof( char const *s, char **end ) {
-double const result = std::strtod( s, end );
+ static float strtof( char const *s, char **last ) {
+double const result = std::strtod( s, last );
if ( !errno ) {
if ( result
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Description changed to: Added follow_symlink to fs::get_type(). Added atoull( char const *buf, char const *end, char const **last ); For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Commit Message changed to: Added follow_symlink to fs::get_type(). Added atoull( char const *buf, char const *end, char const **last ); For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof-merge into lp:zorba
Validation queue job hof-merge-2013-03-05T02-23-32.944Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~nbrinza/zorba/hof-merge/+merge/151673 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/hof-merge into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Pending. -- https://code.launchpad.net/~nbrinza/zorba/hof-merge/+merge/151673 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof-merge into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof-merge into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof-merge/+merge/151673 -- https://code.launchpad.net/~nbrinza/zorba/hof-merge/+merge/151673 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/hof-2013-03-05T02-53-19.978Z/log.html -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The attempt to merge lp:~nbrinza/zorba/hof into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job hof-2013-03-05T02-53-19.978Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~nbrinza/zorba/hof into lp:zorba
The proposal to merge lp:~nbrinza/zorba/hof into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 -- https://code.launchpad.net/~nbrinza/zorba/hof/+merge/151660 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba
I approve conditionally. There are still some things that require fixing: 1. If the options are validated using a schema, there is no need to transform them to lower case because the schema is case-sensitive. Also, the code should validate the namespace of the node, not only the local name. Fixed. 2. Why is x:canonicalize#1 not implemented on x:canonicalize#2 by specifying the default options in XQuery. XML_PARSE_NOERROR is the only option set by default but this is mandatory for the error handling. The XQDoc documentation was updated to state this fact. 3. x:canonicalize-options-impl needs documentation and should be named x:canonicalize-impl instead. I think (but I'm not sure) that it doesn't go through the RQ if the private function doesn't have sufficient parameter documentation. Done the renaming. The RQ runs the moduleDocumentation test that checks the XQDoc comments for all public functions *only*. -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/canonicalize-core-fixed-2013-03-05T04-20-03.545Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job canonicalize-core-fixed-2013-03-05T04-20-03.545Z is finished. The final status was: No tests were run - build or configure step must have failed. Not commiting changes. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-03-05T04-29-43.078Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue job pjl-misc-2013-03-05T04-29-43.078Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/151674 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/canonicalize-core-fixed-2013-03-05T05-03-08.926Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~nbrinza/zorba/hof-merge into lp:zorba
Nicolae, please move the branch under ~zorba-coders/zorba. -- https://code.launchpad.net/~nbrinza/zorba/hof-merge/+merge/151673 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/canonicalize-core-fixed-2013-03-05T06-14-06.536Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job canonicalize-core-fixed-2013-03-05T06-14-06.536Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/canonicalize-core-fixed into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 -- https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/hof-merge into lp:zorba
Markos, I have moved it. -- https://code.launchpad.net/~zorba-coders/zorba/hof-merge/+merge/151673 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
