Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
Review: Needs Fixing 1. Unless I'm missing something, we don't want the function util:replace-entity-references(). The result of calling fn:serialize() should be exactly the XML we wish to canonicalize; if it contains lt; and gt; then there's a problem. 2. I also don't like the $actualResult1 / $actualResult2 disparity. Surely there is only one correct way to serialize a sequence of items according to FOTS? I think maybe util:serialize-result() should return xs:string rather than xs:string*, and it should handle either directly concatenating nodes or concatenating simple items with space delimiters if that is necessary. 3. Why did you add the new order by clause in reporting.xq ? If that's only for W3C reporting then I don't really care, but I'm curious. 4. Finally, I'm concerned that this caused new EXPECTED_FOTS_FAILURE()s to be added. Why is that? Were we generated false positives before, or is there a problem in the canonicalization? -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/msb-misc into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/msb-misc/+merge/152762 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/msb-misc into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/msb-misc into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/msb-misc/+merge/152762 -- https://code.launchpad.net/~zorba-coders/zorba/msb-misc/+merge/152762 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/msb-misc into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/msb-misc-2013-03-12T09-01-51.999Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/msb-misc/+merge/152762 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
1. Unless I'm missing something, we don't want the function util:replace- entity-references(). The result of calling fn:serialize() should be exactly the XML we wish to canonicalize; if it contains lt; and gt; then there's a problem. It's because in FOTS it's stated that we should use XML serialization in 'assert-xml' implementation. Please see http://dev.w3.org/cvsweb/2011/QT3-test-suite/catalog-schema.xsd?rev=1.29;content-type=text%2Fplain [...] Asserts the result of the query by providing a serialization of the expression result using the default serialization parameters method=xml indent=no omit-xml-declaration=yes [...] 2. I also don't like the $actualResult1 / $actualResult2 disparity. Surely there is only one correct way to serialize a sequence of items according to FOTS? I think maybe util:serialize-result() should return xs:string rather than xs:string*, and it should handle either directly concatenating nodes or concatenating simple items with space delimiters if that is necessary. It's a bug/inconsistency in FOTS. They do not state explicitly how the sequences of elements should be treated. In order to fix these cases I know that Michael Kay tried to replace all expected results presented as sequences with single elements. Assuming we have a test-case returning 3 items: '1' and '2' as xs:string and element a/, test creators will enter expected result as: 1) assert-xml![CDATA[1 2 a/]]/assert-xml 2) assert-xml![CDATA[12a/]]/assert-xml 3) assert-xml![CDATA[1 2a/]]/assert-xml see http://dev.w3.org/cvsweb/2011/QT3-test-suite/fn/in-scope-prefixes.xml?rev=1.3;content-type=text%2Fplain and look for K2-InScopePrefixesFunc-11 The case you mention covers situations 1) and 2) and I will report the situation described at 3) as a bug to W3C. 3. Why did you add the new order by clause in reporting.xq ? If that's only for W3C reporting then I don't really care, but I'm curious. The ordering has nothing to do with W3C reporting. It only concerns 'generate-expected-failures' mode. 4. Finally, I'm concerned that this caused new EXPECTED_FOTS_FAILURE()s to be added. Why is that? Were we generated false positives before, or is there a problem in the canonicalization? There differences you see come from the lack of ordering in the EXPECTED_FOTS_FAILURE. -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152788 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/msb-misc into lp:zorba
Validation queue job msb-misc-2013-03-12T09-01-51.999Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/msb-misc/+merge/152762 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/msb-misc into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/msb-misc into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/msb-misc/+merge/152762 -- https://code.launchpad.net/~zorba-coders/zorba/msb-misc/+merge/152762 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fix_bug_1086398-2013-03-12T14-03-44.003Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
Sorin Marian Nasoi has proposed merging lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba. Commit message: - fix in 'assert-xml' implementation: added XML canonicalization support (102 PROGRESSIONS and 2 FALSE positives) - fix in 'assert-string-value' implementation: 30 PROGRESSIONS Requested reviews: Sorin Marian Nasoi (sorin.marian.nasoi) Related bugs: Bug #1086398 in Zorba: FOTS: add canonicalization in eval:assert-xml function https://bugs.launchpad.net/zorba/+bug/1086398 For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 - fix in 'assert-xml' implementation: added XML canonicalization support (102 PROGRESSIONS and 2 FALSE positives) - fix in 'assert-string-value' implementation: 30 PROGRESSIONS -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. === modified file 'test/fots/CMakeLists.txt' --- test/fots/CMakeLists.txt 2013-03-07 12:35:29 + +++ test/fots/CMakeLists.txt 2013-03-12 14:01:21 + @@ -123,24 +123,11 @@ EXPECTED_FOTS_FAILURE (app-CatalogCheck Catalog012 0) EXPECTED_FOTS_FAILURE (app-Demos currencysvg 0) EXPECTED_FOTS_FAILURE (app-Demos itunes 0) -EXPECTED_FOTS_FAILURE (app-FunctxFn functx-fn-number-all 0) -EXPECTED_FOTS_FAILURE (app-FunctxFunctx functx-functx-copy-attributes-1 0) -EXPECTED_FOTS_FAILURE (app-FunctxFunctx functx-functx-copy-attributes-all 0) EXPECTED_FOTS_FAILURE (app-FunctxFunctx functx-functx-id-from-element-1 0) -EXPECTED_FOTS_FAILURE (app-FunctxFunctx functx-functx-sort-as-numeric-all 0) -EXPECTED_FOTS_FAILURE (app-FunctxFunctx functx-functx-sort-case-insensitive-all 0) -EXPECTED_FOTS_FAILURE (app-FunctxFunctx functx-functx-sort-all 0) -EXPECTED_FOTS_FAILURE (app-UseCaseNS ns-queries-results-q5 0) -EXPECTED_FOTS_FAILURE (app-UseCaseNS ns-queries-results-q8 0) -EXPECTED_FOTS_FAILURE (app-XMark XMark-Q3 0) -EXPECTED_FOTS_FAILURE (app-XMark XMark-All 0) EXPECTED_FOTS_FAILURE (fn-adjust-date-to-timezone cbcl-adjust-date-to-timezone-002 0) EXPECTED_FOTS_FAILURE (fn-adjust-date-to-timezone cbcl-adjust-date-to-timezone-003 0) EXPECTED_FOTS_FAILURE (fn-adjust-dateTime-to-timezone cbcl-adjust-dateTime-to-timezone-002 0) EXPECTED_FOTS_FAILURE (fn-adjust-dateTime-to-timezone cbcl-adjust-dateTime-to-timezone-003 0) -EXPECTED_FOTS_FAILURE (fn-analyze-string analyzeString-008 0) -EXPECTED_FOTS_FAILURE (fn-analyze-string analyzeString-017 0) -EXPECTED_FOTS_FAILURE (fn-analyze-string analyzeString-017a 0) EXPECTED_FOTS_FAILURE (fn-available-environment-variables fn-available-environment-variables-011 0) EXPECTED_FOTS_FAILURE (fn-avg cbcl-avg-002 0) EXPECTED_FOTS_FAILURE (fn-avg cbcl-avg-003 0) @@ -168,8 +155,6 @@ EXPECTED_FOTS_FAILURE (fn-distinct-values cbcl-distinct-values-002 0) EXPECTED_FOTS_FAILURE (fn-distinct-values cbcl-distinct-values-002b 0) EXPECTED_FOTS_FAILURE (fn-distinct-values cbcl-distinct-values-003 0) -EXPECTED_FOTS_FAILURE (fn-doc fn-doc-25 0) -EXPECTED_FOTS_FAILURE (fn-doc fn-doc-33 0) EXPECTED_FOTS_FAILURE (fn-environment-variable environment-variable-005 0) EXPECTED_FOTS_FAILURE (fn-environment-variable environment-variable-006 0) EXPECTED_FOTS_FAILURE (fn-environment-variable environment-variable-007 0) @@ -317,8 +302,6 @@ EXPECTED_FOTS_FAILURE (fn-id fn-id-dtd-20 0) EXPECTED_FOTS_FAILURE (fn-id fn-id-dtd-21 0) EXPECTED_FOTS_FAILURE (fn-id fn-id-dtd-23 0) -EXPECTED_FOTS_FAILURE (fn-id K2-SeqIDFunc-11 0) -EXPECTED_FOTS_FAILURE (fn-id K2-SeqIDFunc-12 0) EXPECTED_FOTS_FAILURE (fn-idref fn-idref-dtd-5 0) EXPECTED_FOTS_FAILURE (fn-idref fn-idref-dtd-7 0) EXPECTED_FOTS_FAILURE (fn-idref fn-idref-dtd-8 0) @@ -336,13 +319,7 @@ EXPECTED_FOTS_FAILURE (fn-idref fn-idref-dtd-23 0) EXPECTED_FOTS_FAILURE (fn-idref fn-idref-dtd-24 0) EXPECTED_FOTS_FAILURE (fn-idref fn-idref-dtd-25 0) -EXPECTED_FOTS_FAILURE (fn-in-scope-prefixes K2-InScopePrefixesFunc-11 0) -EXPECTED_FOTS_FAILURE (fn-in-scope-prefixes K2-InScopePrefixesFunc-12 0) -EXPECTED_FOTS_FAILURE (fn-in-scope-prefixes K2-InScopePrefixesFunc-18 0) -EXPECTED_FOTS_FAILURE (fn-in-scope-prefixes K2-InScopePrefixesFunc-26 0) -EXPECTED_FOTS_FAILURE (fn-in-scope-prefixes K2-InScopePrefixesFunc-28 0) EXPECTED_FOTS_FAILURE (fn-iri-to-uri fn-iri-to-uri-18A 0) -EXPECTED_FOTS_FAILURE (fn-last last-11 0) EXPECTED_FOTS_FAILURE (fn-last last-24 0) EXPECTED_FOTS_FAILURE (fn-matches cbcl-matches-038 1131304) EXPECTED_FOTS_FAILURE (fn-matches.re re00056 1131984) @@ -376,9 +353,6 @@ EXPECTED_FOTS_FAILURE (fn-parse-xml parse-xml-010 0) EXPECTED_FOTS_FAILURE (fn-parse-xml parse-xml-011 0) EXPECTED_FOTS_FAILURE (fn-parse-xml-fragment parse-xml-fragment-001 0) -EXPECTED_FOTS_FAILURE (fn-parse-xml-fragment parse-xml-fragment-010 0) -EXPECTED_FOTS_FAILURE (fn-parse-xml-fragment parse-xml-fragment-011 0) -EXPECTED_FOTS_FAILURE (fn-parse-xml-fragment parse-xml-fragment-012 0) EXPECTED_FOTS_FAILURE (fn-parse-xml-fragment parse-xml-fragment-016 0)
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job fix_bug_1086398-2013-03-12T14-03-44.003Z is finished. The final status was: 2 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fix_bug_1086398-2013-03-12T15-37-39.266Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
Validation queue job fix_bug_1086398-2013-03-12T15-37-39.266Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Approve. -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/hof-merge into lp:zorba
In translator.cpp:3356 what is the reason for the arity checks for fn:number and fn:static-base-uri functions? -- https://code.launchpad.net/~zorba-coders/zorba/hof-merge/+merge/151673 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug924756-xsDateTimeStamp-2013-03-12T19-27-54.498Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug924756-xsDateTimeStamp-2013-03-12T19-27-54.498Z is finished. The final status was: 8 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fix_bug_1086398-2013-03-12T19-56-38.931Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
Validation queue job fix_bug_1086398-2013-03-12T19-56-38.931Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1086398 into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1086398/+merge/152913 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/hof-merge into lp:zorba
Markos, I've fixed the following issues you have reported (with changes merged into this branch): -- Also, the grammar rule for LiteralFunctionItem should use EQNAME, instead of QNAME. I've looked into it and the QNAME production actually covers EQNAMEs. I haven't tested it but they should work, as all the other grammar rules use the QNAME production. -- In typeops.cpp:749, you should not be casting AnyFunctionXQType to FunctionXQType. Fixed. -- is_equal() has not been implemented for function types. If you think it will never be called, then at least put an assertion to make sure that it will indeed never be called. I have implemented it. -- I think we should completely remove the option to enable/disable the HOF feature. I have removed it from the features system. -- There are also several failures in fn-function-lookup and misc-HigherOrderFunctions test sets. Are you aware of these failures? Yes, I'm aware. As I have said in an e-mail, the remaining failures are caused by the function-lookup() which I'm working on. On the other hand, there should be no failures in misc-HigherOrderFunctions, unless there are functions which use the $$context-position or $$context-size. I'll look into this. I will update the test/fots/CMakeLists.txt but it will take a while as FOTS has no progression registration mechanism as the rbkt testdriver has. -- In translator.cpp:3356 what is the reason for the arity checks for fn:number and fn:static-base-uri functions? I've looked into it and also run some tests and seems the checks are indeed redundant. I had copied the arity verification from the FunctionCall end_visit() translation, see e.g. translator.cpp:10875 in the Trunk branch. I have removed those checks. -- https://code.launchpad.net/~zorba-coders/zorba/hof-merge/+merge/151673 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba
Sorin Marian Nasoi has proposed merging
lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba.
Commit message:
Fixes FOTS driver.
Requested reviews:
Sorin Marian Nasoi (sorin.marian.nasoi)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009
Fixes FOTS driver.
--
https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'test/fots/CMakeLists.txt'
--- test/fots/CMakeLists.txt 2013-03-12 15:34:52 +
+++ test/fots/CMakeLists.txt 2013-03-12 20:29:28 +
@@ -121,7 +121,6 @@
EXPECTED_FOTS_FAILURE (app-CatalogCheck Catalog010 0)
EXPECTED_FOTS_FAILURE (app-CatalogCheck Catalog011 0)
EXPECTED_FOTS_FAILURE (app-CatalogCheck Catalog012 0)
-EXPECTED_FOTS_FAILURE (app-Demos currencysvg 0)
EXPECTED_FOTS_FAILURE (app-Demos itunes 0)
EXPECTED_FOTS_FAILURE (app-FunctxFunctx functx-functx-id-from-element-1 0)
EXPECTED_FOTS_FAILURE (fn-adjust-date-to-timezone cbcl-adjust-date-to-timezone-002 0)
@@ -722,25 +721,6 @@
EXPECTED_FOTS_FAILURE (prod-VarDefaultValue extvardef-016b 0)
EXPECTED_FOTS_FAILURE (prod-VersionDecl VersionDecl-v1-processor-and-v3-query 0)
EXPECTED_FOTS_FAILURE (prod-VersionDecl version_declaration-023-v3 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase01S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase02S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase03S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase04S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase05S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase06S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase07S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase08S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase09S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase10S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase11S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase12S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase13S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase14S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase15S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase16S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase17S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase18S 0)
-EXPECTED_FOTS_FAILURE (prod-WindowClause WindowingUseCase19S 0)
EXPECTED_FOTS_FAILURE (prod-WindowClause SlidingWindowExpr507 0)
EXPECTED_FOTS_FAILURE (prod-WindowClause TumblingWindowExpr507 0)
EXPECTED_FOTS_FAILURE (xs-anyURI cbcl-anyURI-002 0)
=== modified file 'test/fots_driver/cli.xq'
--- test/fots_driver/cli.xq 2013-02-28 11:15:32 +
+++ test/fots_driver/cli.xq 2013-03-12 20:29:28 +
@@ -370,6 +370,13 @@
$resultsFilePath)
}
+case wiki-report
+return
+{
+ r:wiki-report($fotsPath,
+$resultsFilePath)
+}
+
case generate-expected-failures
return
{
=== modified file 'test/fots_driver/environment.xq'
--- test/fots_driver/environment.xq 2013-03-12 13:56:51 +
+++ test/fots_driver/environment.xq 2013-03-12 20:29:28 +
@@ -459,15 +459,20 @@
then xs:string($namespace/@prefix)
else p
return
- if ($prefix eq )
- then concat('import schema default element namespace ',
- $env/fots:schema/@uri,
- ';#xA;')
- else concat('import schema namespace ',
- $prefix,
- ' = ',
- $env/fots:schema/@uri,
- ';#xA;')
+ if (empty($env/fots:schema/@uri))
+ then 'import schema default element namespace ;'
+ else
+ {
+if ($prefix eq )
+then concat('import schema default element namespace ',
+$env/fots:schema/@uri,
+';#xA;')
+else concat('import schema namespace ',
+$prefix,
+' = ',
+$env/fots:schema/@uri,
+';#xA;')
+ }
};
=== modified file 'test/fots_driver/fots-driver.xq'
--- test/fots_driver/fots-driver.xq 2013-03-07 13:49:26 +
+++ test/fots_driver/fots-driver.xq 2013-03-12 20:29:28 +
@@ -416,7 +416,7 @@
$expectedFailures,
$cliMode)
}
- catch *
+ catch err:FODC0002
{
error($err:code,
concat(#xA;Please make sure the passed 'fotsPath' points to the,
@@ -566,7 +566,7 @@
$expectedFailures,
$cliMode)
}
- catch *
+ catch err:FODC0002
{
error($err:code,
concat(#xA;Please make sure the passed 'fotsPath' points to the,
=== modified file 'test/fots_driver/reporting.xq'
--- test/fots_driver/reporting.xq 2013-03-12 13:56:51 +
+++
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fixes_FOTS_driver-2013-03-12T21-06-39.052Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job fixes_FOTS_driver-2013-03-12T21-06-39.052Z is finished. The final status was: 1 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba has been updated. Commit Message changed to: Fixes FOTS driver: - added case where the used schema does not have a namespace defined. - fix in util:get-value function that allows .xml files to be passed as 'assert-xml' expected results. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot into lp:zorba
Sorin Marian Nasoi has proposed merging lp:~zorba-coders/zorba/bump_FOTS_snapshot into lp:zorba with lp:~zorba-coders/zorba/fixes_FOTS_driver as a prerequisite. Commit message: Updated FOTS snapshot to March 12. Requested reviews: Sorin Marian Nasoi (sorin.marian.nasoi) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot/+merge/153026 Updated FOTS snapshot to March 12. -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot/+merge/153026 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/fixes_FOTS_driver. === modified file 'test/fots/ImportFOTS.cmake' --- test/fots/ImportFOTS.cmake 2013-02-27 11:48:55 + +++ test/fots/ImportFOTS.cmake 2013-03-12 22:50:26 + @@ -19,7 +19,7 @@ # Change this to publish updated FOTS archives -SET (FOTS_ARCHIVE FOTS_270213.tgz) +SET (FOTS_ARCHIVE FOTS_120313.tgz) # Change this to modify which elements in FOTS driver results are output # as CDATA -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot/+merge/153026 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/fixes_FOTS_driver. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot/+merge/153026 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/fixes_FOTS_driver. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba
Validation queue job fixes_FOTS_driver-2013-03-12T22-47-41.831Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver/+merge/153009 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot into lp:zorba
Validation queue job bump_FOTS_snapshot-2013-03-12T23-12-41.111Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot/+merge/153026 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/fixes_FOTS_driver. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bump_FOTS_snapshot into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot/+merge/153026 -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot/+merge/153026 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/fixes_FOTS_driver. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug924756-xsDateTimeStamp-2013-03-13T01-17-05.513Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug924756-xsDateTimeStamp-2013-03-13T01-17-05.513Z is finished. The final status was: 3 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug924756-xsDateTimeStamp-2013-03-13T01-49-00.348Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
Validation queue job bug924756-xsDateTimeStamp-2013-03-13T01-49-00.348Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug924756-xsDateTimeStamp into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 -- https://code.launchpad.net/~zorba-coders/zorba/bug924756-xsDateTimeStamp/+merge/149901 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/pjl-misc into lp:zorba. Commit message: Fix negative time-zone bug for cases like -00:30, i.e., hours is zero, but minutes are negative. Requested reviews: Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Fix negative time-zone bug for cases like -00:30, i.e., hours is zero, but minutes are negative. -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Your team Zorba Coders is subscribed to branch lp:zorba. === modified file 'src/zorbatypes/datetime/timezone.cpp' --- src/zorbatypes/datetime/timezone.cpp 2013-02-28 11:15:32 + +++ src/zorbatypes/datetime/timezone.cpp 2013-03-13 03:17:21 + @@ -108,6 +108,8 @@ tz = TimeZone(hours); tz.data[MINUTE_DATA] = std::abs(minutes); tz.data[SECONDS_DATA] = std::abs(seconds); + if ( minutes 0 || seconds 0 ) // hours is checked in TimeZone() ctor +tz.is_negative = true; tz.normalize(); return 0; } -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-03-13T03-18-39.352Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
FYI: this change fixes 13 failing FOTS format-dateTime tests all by itself. I suspect there are more bugs in the code dateTime/timezone code than in the formatting code. -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue job pjl-misc-2013-03-13T03-18-39.352Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Approve. -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/pjl-misc-2013-03-13T04-31-43.245Z/log.html -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue job pjl-misc-2013-03-13T04-31-43.245Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The proposal to merge lp:~paul-lucas/zorba/pjl-misc into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/153046 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
