[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba

2013-03-29 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba has been updated. Commit Message changed to: - updated FOTS snapshot to March 29th. Updated expected failures accordingly. - if a test did not pass, we further check if the reason it failed is an environment dep

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba

2013-03-29 Thread Sorin Marian Nasoi
One more thing: even Mike Kay says that these 2 let's call them features (ability to define COLLECTIONS and to set COLLATION URI's) is like "implicit dependency [...] An implementation that cannot set the context as required should behave in the same way as if a dependency has not been satisf

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba

2013-03-29 Thread Sorin Marian Nasoi
Please also see: https://bugs.launchpad.net/zorba/+bug/1160111/comments/2 My understanding of the comment is this: Step 1) minimise the number of failing test cases as much as possible Step 2) maximize the number of passing test cases as much as possible What is your opinion? -- https://code.lau

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba

2013-03-29 Thread Sorin Marian Nasoi
> The changes seem OK for now; however, they don't actually *fix* the two > related bugs, do they? They do actually because they correctly marked some bugs as notRun instead of fail (which according to W3C is OK). If we decide we want to increase the number of test cases that PASS, additional wor

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fixes_FOTS_driver_29_MAR into lp:zorba

2013-03-29 Thread Chris Hillery
Review: Approve The changes seem OK for now; however, they don't actually *fix* the two related bugs, do they? -- https://code.launchpad.net/~zorba-coders/zorba/fixes_FOTS_driver_29_MAR/+merge/156109 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.ne