Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Did you have any other comments, Cezar?
I want to think a bit about the ExternalModuleConfig.cmake that's included
here; it looks like it might be redundant with the one in the Zorba trunk, plus
I'm not sure it's the right solution to the problem anyway.
--
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been
updated.
Commit Message changed to:
Added URI processing module.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
--
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been
updated.
Description changed to:
- Fix for Bug 867376 URI processing module
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-867376-2013-05-02T09-13-03.471Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/deprecate-true_false_null/+merge/160980
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/deprecate-true_false_null into
lp:zorba has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/deprecate-true_false_null/+merge/160980
--
The attempt to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug-867376-2013-05-02T09-13-03.471Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/deprecate-true_false_null-2013-05-02T09-50-53.505Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/deprecate-true_false_null/+merge/160980
Your team Zorba Coders is subscribed to branch
Validation queue job deprecate-true_false_null-2013-05-02T09-50-53.505Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/deprecate-true_false_null/+merge/160980
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/deprecate-true_false_null into
lp:zorba has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/deprecate-true_false_null/+merge/160980
--
Review: Needs Fixing
- Could you give an example in the documentation of uri:parse and show a
resulting URI object?
- The names of the variables are all upper-case. I know that we don't have any
coding conventions for it but the names in the full-text module are all
lower-case. Should we be
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc_2/+merge/162233
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug-1134008 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-1134008-2013-05-02T20-19-39.258Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bug-1134008-2013-05-02T20-19-39.258Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1
Approve, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000
Your team Zorba Coders is subscribed to branch
The proposal to merge lp:~zorba-coders/zorba/bug-1134008 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc/+merge/162230
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/fix_disputed_tc into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc/+merge/162230
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/fix_disputed_tc-2013-05-02T21-27-40.308Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc/+merge/162230
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Sorin Marian Nasoi has proposed merging
lp:~zorba-coders/zorba/bump_FOTS_snapshot_May_2nd into lp:zorba.
Commit message:
- bumped FOTS snapshot to May 2nd
- newly added test-case fn-substring-31 passing
- FOAR0002-5 used to report 'wrongError' now passing after fixes in FOTS
Requested reviews:
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot_May_2nd/+merge/162253
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue job fix_disputed_tc-2013-05-02T21-27-40.308Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc/+merge/162230
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/fix_disputed_tc into lp:zorba has
been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc/+merge/162230
--
- Could you give an example in the documentation of uri:parse and show a
resulting URI object?
Done
- The names of the variables are all upper-case. I know that we don't have any
coding conventions for it but the names in the full-text module are all lower-
case. Should we be consistent here?
I believe all outstanding comments have been addressed; Matthias, one more
pass, please?
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
I have pushed some final documentation improvements.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The attempt to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug-867376-2013-05-03T03-13-20.382Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
One of the FOTS tests crashes
We already pushed a fix for that one before asking for your re-review (it was
an infinite loop eventually causing OOM).
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
34 matches
Mail list logo
