Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-09 Thread Chris Hillery
Review: Needs Fixing

1. Error QNames should not be declared as public constants (see coding 
guidelines). Declare them as private variables as follows:

declare %private variable $queue:NOT-EXISTS as xs:QName := 
fn:QName($queue:ERR-NS, queue:NOT-EXISTS);

2. The current XQDoc for those error QNames is pointless. Either eliminate the 
XQDoc entirely, or put in some meaningful comment (only for later authors of 
the module since it won't be part of the public API).

3. The XQDoc for all the queue functions refers to nodes. It should now say 
items since it works for objects and arrays in addition to nodes.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1188062/+merge/169946
Your team Zorba Coders is subscribed to branch lp:zorba/queue-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-07-09 Thread Chris Hillery
Review: Needs Fixing

Basically the same comments as the queue proposal:

1. Make the error QName variables %private;
2. Fix or eliminate the XQDoc for the error QNames;
3. Replace node with item in function XQDoc.

In addition:

4. You have a stray p at the beginning of the header XQDoc comment (diff line 
21).

5. You have /p in at least 8 places, instead of p/.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553
Your team Zorba Coders is subscribed to branch lp:zorba/stack-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-based-on-json-http-client into lp:zorba/http-client-module

2013-07-09 Thread Chris Hillery
Review: Needs Information

1. Do we need to promote this to version 2.0 of the EXpath module? Isn't the 
public API exactly the same, as defined by EXpath? I understand the 
implementation is different, but I don't believe that's relevant for module 
versioning.

2. (Possibly the same question) Do we need to keep the old version of this 
module, what we're calling 1.0? Again, they have the same interface, so why 
would anyone care about importing one or the other?

3. FYI the XQDoc has a link to the scripting tutorial on 
http://www.zorba-xquery.com/ . That might even be a broken link now, but it 
should presumably be updated to http://www.zorba.io/ .

4. Also FYI, the example given (reading the Zorba blog RSS feed) almost 
certainly won't work, since (a) the URL is old and (b) our blog isn't working 
at the moment.
-- 
https://code.launchpad.net/~zorba-coders/zorba/http-client-based-on-json-http-client/+merge/169578
Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module

2013-07-09 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module

2013-07-09 Thread Zorba Build Bot
Voting criteria failed for the following merge proposals:

https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
 :
Votes: {'Approve': 2, 'Needs commit message': 1}
-- 
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module

2013-07-09 Thread Zorba Build Bot
Validation queue result for 
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032

Stage CommitZorba failed.

Check console output at http://jenkins.lambda.nu/job/CommitZorba/10/console to 
view the results.
-- 
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-09 Thread Chris Hillery
Review: Needs Fixing

1. Very sorry for the mis-information, but this module should NOT have been 
moved into the zorba.io namespace. EXpath modules should remain in their 
expath.org/ns namespace.

2. Remove the how to build the module information from the XQDoc; XQDoc 
should only contain information on *using* the module, not building it. Move 
this information into a top-level README.txt file in the module.

3. Are there any errors which may be raised by these module functions? If so, 
are they documented?

4. Why did you change the GEOS_VERSION_PATCH check in geo_functions.cpp ?
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module

2013-07-09 Thread Chris Hillery
Review: Needs Information

The changes as made seem fine. Two concerns:

1. Are there any errors raised by the module functions? If so, are they 
documented?

2. Matthias: This seems like it is an ideal candidate for JSONify-ing; would 
you agree? If so, what would you think is the priority? I'm tempted to merge 
this revision as it stands, and file a separate lower-priority bug to JSONify 
this module later if we have time.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214
Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module

2013-07-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/install_mysql_update into 
lp:zorba/jdbc-module has been updated.

Commit Message changed to:

Update test-setup script to MySQL 5.6; don't download Connector jar; cleanup.

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
-- 
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module

2013-07-09 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_info-extraction-module into lp:zorba/info-extraction-module

2013-07-09 Thread Chris Hillery
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_info-extraction-module/+merge/170463
Your team Zorba Coders is subscribed to branch lp:zorba/info-extraction-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_info-extraction-module into lp:zorba/info-extraction-module

2013-07-09 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_info-extraction-module/+merge/170463

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_info-extraction-module/+merge/170463
Your team Zorba Coders is subscribed to branch lp:zorba/info-extraction-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module

2013-07-09 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/install_mysql_update into 
lp:zorba/jdbc-module has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
-- 
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module

2013-07-09 Thread Zorba Build Bot
Validation queue succeeded - proposal merged!
-- 
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032
Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_info-extraction-module into lp:zorba/info-extraction-module

2013-07-09 Thread Zorba Build Bot
Voting criteria failed for the following merge proposals:

https://code.launchpad.net/~zorba-coders/zorba/update3.0_info-extraction-module/+merge/170463
 :
Votes: {'Approve': 1}
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_info-extraction-module/+merge/170463
Your team Zorba Coders is subscribed to branch lp:zorba/info-extraction-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_info-extraction-module into lp:zorba/info-extraction-module

2013-07-09 Thread Zorba Build Bot
Validation queue result for 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_info-extraction-module/+merge/170463

Stage CommitZorba failed.

Check console output at http://jenkins.lambda.nu/job/CommitZorba/12/console to 
view the results.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_info-extraction-module/+merge/170463
Your team Zorba Coders is subscribed to branch lp:zorba/info-extraction-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_node-position-module into lp:zorba

2013-07-09 Thread Chris Hillery
Review: Approve

I changed the module version declaration back to xquery version 1.0. It 
seemed weird to have it claim to be jsoniq when the module is only dealing 
with XML nodes. I also added a copyright notice to 
modules/nodes/CMakeLists.txt. Other than that looked fine.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_node-position-module/+merge/173105
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_node-position-module into lp:zorba

2013-07-09 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_node-position-module/+merge/173105

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_node-position-module/+merge/173105
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_examples_XQDoc into lp:zorba

2013-07-09 Thread Chris Hillery
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_examples_XQDoc/+merge/170878
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_examples_XQDoc into lp:zorba

2013-07-09 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/fix_examples_XQDoc/+merge/170878

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_examples_XQDoc/+merge/170878
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1151967 into lp:zorba

2013-07-09 Thread Chris Hillery
Review: Needs Fixing


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1151967/+merge/162905
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_node-position-module into lp:zorba

2013-07-09 Thread Zorba Build Bot
Voting criteria failed for the following merge proposals:

https://code.launchpad.net/~zorba-coders/zorba/update3.0_node-position-module/+merge/173105
 :
Votes: {'Approve': 1}
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_node-position-module/+merge/173105
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1151967 into lp:zorba

2013-07-09 Thread Chris Hillery
Oops, forgot to comment:

1. Need to fix merge conflict.

2. There are some code changes in here as well. I assume they are the Removing 
some warnings comment? If so, please mention that in the commit message for 
this proposal, along with the main changes.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1151967/+merge/162905
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_node-position-module into lp:zorba

2013-07-09 Thread Zorba Build Bot
Validation queue result for 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_node-position-module/+merge/173105

Stage CommitZorba failed.

Check console output at http://jenkins.lambda.nu/job/CommitZorba/13/console to 
view the results.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_node-position-module/+merge/173105
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_examples_XQDoc into lp:zorba

2013-07-09 Thread Zorba Build Bot
Validation queue result for 
https://code.launchpad.net/~zorba-coders/zorba/fix_examples_XQDoc/+merge/170878

Stage TestZorbaUbuntu failed.
4 tests failed (8345 total tests run).

Check test results at 
http://jenkins.lambda.nu/job/TestZorbaUbuntu/58/testReport/ to view the results.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_examples_XQDoc/+merge/170878
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-07-09 Thread Chris Hillery
Review: Needs Fixing

1. OMG code duplication: the entire contents of http-client.xq.src is copied 
(and modified?) from the original http-client module. That's nearly 3000 lines 
of some of the ugliest and most error-filled code we've got. No way do we want 
to maintain two copies of it. Also, they both call curl_global_init() and 
curl_global_cleanup(), which means that they will stomp on each other if anyone 
attempts to use both. This code must be consolidated somehow, perhaps into a 
common library that both modules use. Or, we need to simply eliminate the 
original http-client library. Perhaps we could replace the old http-client 
module with a pure XQuery wrapper module that replicates the old API, much like 
V2 of the EXPath http-client module does?

2. Need to consolidate the CMake code which searches for curl, etc. It was 
copied from modules/com/zorba-xquery/www/modules/CMakeLists.txt, and it still 
exists in that location. That means the search for CURL is done twice, and the 
cached variable ZORBA_HAVE_CURL is defined twice, and the Windows .pem files 
are copied twice... I would suggest that it should remain where it is in 
modules/CMakeList.txt, and be deleted from the other location, and testing done 
to ensure it still works right. (This issue would also be resolved by 
eliminating the original http-client module or replacing it with a wrapper 
module.)

3. The module error codes need to be changed to match the coding guidelines: 
http://my.zorba.io/dokuwiki/doku.php?id=coding-guidelines#error_codes


-- 
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-07-09 Thread Federico Cavalieri
Thank you for your feedback.
 
 3. The module error codes need to be changed to match the coding guidelines:
 http://my.zorba.io/dokuwiki/doku.php?id=coding-guidelines#error_codes

I updated the error codes according to the guidelines
-- 
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-07-09 Thread Federico Cavalieri
 1. OMG code duplication: the entire contents of http-client.xq.src is copied
 (and modified?) from the original http-client module. That's nearly 3000 lines
 of some of the ugliest and most error-filled code we've got. No way do we want
 to maintain two copies of it. Also, they both call curl_global_init() and
 curl_global_cleanup(), which means that they will stomp on each other if
 anyone attempts to use both. This code must be consolidated somehow, perhaps
 into a common library that both modules use. Or, we need to simply eliminate
 the original http-client library. Perhaps we could replace the old http-client
 module with a pure XQuery wrapper module that replicates the old API, much
 like V2 of the EXPath http-client module does?
 
 2. Need to consolidate the CMake code which searches for curl, etc. It was
 copied from modules/com/zorba-xquery/www/modules/CMakeLists.txt, and it still
 exists in that location. That means the search for CURL is done twice, and the
 cached variable ZORBA_HAVE_CURL is defined twice, and the Windows .pem files
 are copied twice... I would suggest that it should remain where it is in
 modules/CMakeList.txt, and be deleted from the other location, and testing
 done to ensure it still works right. (This issue would also be resolved by
 eliminating the original http-client module or replacing it with a wrapper
 module.)

Yes, part of the code of the json-http-client duplicates that of the original 
http-client-module. It is not 100% the same because, as you said, because 
the original contains several bugs. The bugs I found (which include, headers 
mangling, 
broken/absent charset encoding/decoding, broken/absent streamable string and 
binary
support, error reporting, and so on) are fixed in the JSON HTTP module code.

I believe that removing the old http-client module would solve many problems, 
but given the widespread use of this module I am not sure if this is feasible.
I remember that when I started working on this module there was a discussion on 
this option and that keeping the old module (and duplicating the code) was the 
final decision.
However, my knowledge in this respect is limited, so I am not sure.

The next best thing would be to replace the old module with a wrapper.
The only downside of this is that some of the old module bugs are really 
common, 
e.g.: all requests which do not contain a manually specified charset=UTF-8 
specification in the media-type are sent with a wrong encoding.

Therefore, I will begin to work on the wrapper.
-- 
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba

2013-07-09 Thread Juan Zacarias
All the changes were addressed except for 

-I know that it's unrelated to the change but the example using file:read-text 
in the materialize function doesn't make sense anymore. Because read-text 
returns a seekable string it can be consumed more than once. The http-client 
would be the right example. Also, a is-seekable function would be great to have.

Should I do this change?
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_data-cleaning-module into lp:zorba/data-cleaning-module

2013-07-09 Thread Juan Zacarias
Changes done
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module

2013-07-09 Thread Juan Zacarias
 The changes as made seem fine. Two concerns:
 
 1. Are there any errors raised by the module functions? If so, are they
 documented?
No errors are thrown by the module.

 
 2. Matthias: This seems like it is an ideal candidate for JSONify-ing; would
 you agree? If so, what would you think is the priority? I'm tempted to merge
 this revision as it stands, and file a separate lower-priority bug to JSONify
 this module later if we have time.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214
Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-09 Thread Juan Zacarias
 1. Very sorry for the mis-information, but this module should NOT have been
 moved into the zorba.io namespace. EXpath modules should remain in their
 expath.org/ns namespace.
 
 2. Remove the how to build the module information from the XQDoc; XQDoc
 should only contain information on *using* the module, not building it. Move
 this information into a top-level README.txt file in the module.
ok

 
 3. Are there any errors which may be raised by these module functions? If so,
 are they documented?
Actually there are, I will update it.

 
 4. Why did you change the GEOS_VERSION_PATCH check in geo_functions.cpp ?
It was breaking my windows build of the module, not sure why it wasn't 
happening before.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba

2013-07-09 Thread Chris Hillery
Discussed with Juan - the is-seekable() function should be easy enough to add, 
so sure, let's do it.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_data-cleaning-module into lp:zorba/data-cleaning-module

2013-07-09 Thread Chris Hillery
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_data-cleaning-module into lp:zorba/data-cleaning-module

2013-07-09 Thread Juan Zacarias
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_data-cleaning-module into lp:zorba/data-cleaning-module

2013-07-09 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_data-cleaning-module into lp:zorba/data-cleaning-module

2013-07-09 Thread Zorba Build Bot
Validation queue result for 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213

Stage TestZorbaUbuntu failed.
2 tests failed (8345 total tests run).

Check test results at 
http://jenkins.lambda.nu/job/TestZorbaUbuntu/59/testReport/ to view the results.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_data-cleaning-module into lp:zorba/data-cleaning-module

2013-07-09 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_data-cleaning-module into lp:zorba/data-cleaning-module

2013-07-09 Thread Zorba Build Bot
Validation queue succeeded - proposal merged!
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_data-cleaning-module into lp:zorba/data-cleaning-module

2013-07-09 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/update3.0_data-cleaning-module 
into lp:zorba/data-cleaning-module has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_data-cleaning-module/+merge/170213
Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_couchbase_update into lp:zorba/couchbase-module

2013-07-09 Thread Juan Zacarias
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/install_couchbase_update/+merge/171023
Your team Zorba Coders is subscribed to branch lp:zorba/couchbase-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_couchbase_update into lp:zorba/couchbase-module

2013-07-09 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/install_couchbase_update/+merge/171023

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/install_couchbase_update/+merge/171023
Your team Zorba Coders is subscribed to branch lp:zorba/couchbase-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geo-module into lp:zorba/geo-module

2013-07-09 Thread Chris Hillery
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geo-module/+merge/170212
Your team Zorba Coders is subscribed to branch lp:zorba/geo-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module

2013-07-09 Thread Chris Hillery
Review: Approve

Approving the changes as they are. Matthias, let us know if you think it should 
JSONified immediately or if we can come back to it.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214
Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_couchbase_update into lp:zorba/couchbase-module

2013-07-09 Thread Zorba Build Bot
Validation queue succeeded - proposal merged!
-- 
https://code.launchpad.net/~zorba-coders/zorba/install_couchbase_update/+merge/171023
Your team Zorba Coders is subscribed to branch lp:zorba/couchbase-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module

2013-07-09 Thread Chris Hillery
One note: we cannot JSONify the geo module [can we?], since it is an EXPath 
module. There are no common APIs or schemas between geo and geoproj so far as I 
know, but they might be used by similar people. So, might it be weird if one is 
XML and one is JSON? Not really sure how to make that call.
-- 
https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214
Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp