[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue result for https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518 Stage "CommitZorba" failed. Check console output at http://jenkins.lambda.nu/job/CommitZorba/217/console to view the results. -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
The test failure is kind of interesting. It looks like that FOTS test case might actually have some assumptions about the locale it is being run in, which is probably not cool -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518 :
Votes: {'Approve': 1, 'Pending': 1}
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
This validation queue run is executing with LANG=en_US.UTF-8. -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue starting for the following merge proposals: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue result for https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518 Stage "TestZorbaUbuntu" failed. 1 tests failed (8573 total tests run). Check test results at http://jenkins.lambda.nu/job/TestZorbaUbuntu/357/testReport/ to view the results. -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
This validation queue run should be executing with LANG unset in the environment. -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Validation queue starting for the following merge proposals: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Review: Approve Chris: if you can, try running a few tests using this branch on jenkins *without* LANG set. -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/pjl-misc into lp:zorba.
Commit message:
Now always initializing country and lang.
Requested reviews:
Paul J. Lucas (paul-lucas)
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518
Now always initializing country and lang.
--
https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/189518
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/util/locale.cpp'
--- src/util/locale.cpp 2013-08-02 18:31:23 +
+++ src/util/locale.cpp 2013-10-06 23:51:23 +
@@ -1310,15 +1310,15 @@
}
iso3166_1::type get_host_country() {
- iso3166_1::type country;
+ iso3166_1::type country = iso3166_1::unknown;
-# ifdef WIN32
+#ifdef WIN32
zstring const name( get_locale_info( LOCALE_SISO3166CTRYNAME ) );
country = iso3166_1::find( name );
-# else
+#else
zstring const loc_info( get_unix_locale() );
parse( loc_info, nullptr, &country );
-# endif /* WIN32 */
+#endif /* WIN32 */
return country;
}
@@ -1328,15 +1328,15 @@
// ICU's Locale::getDefault().getLanguage() should be used here, but it
// sometimes returns "root" which isn't useful.
//
- iso639_1::type lang;
+ iso639_1::type lang = iso639_1::unknown;
-# ifdef WIN32
+#ifdef WIN32
zstring const name( get_locale_info( LOCALE_SISO639LANGNAME ) );
lang = find_lang( name );
-# else
+#else
zstring const loc_info( get_unix_locale() );
parse( loc_info, &lang );
-# endif /* WIN32 */
+#endif /* WIN32 */
if ( !lang )
lang = iso639_1::en; // default to English
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsound-validator into lp:zorba
Validation queue succeeded - proposal merged! -- https://code.launchpad.net/~zorba-coders/zorba/jsound-validator/+merge/186908 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsound-validator into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsound-validator into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsound-validator/+merge/186908 -- https://code.launchpad.net/~zorba-coders/zorba/jsound-validator/+merge/186908 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsound-validator into lp:zorba
Validation queue starting for the following merge proposals: https://code.launchpad.net/~zorba-coders/zorba/jsound-validator/+merge/186908 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https://code.launchpad.net/~zorba-coders/zorba/jsound-validator/+merge/186908 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/win-fix into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/win-fix into lp:zorba has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/win-fix/+merge/189190 -- https://code.launchpad.net/~zorba-coders/zorba/win-fix/+merge/189190 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/win-fix into lp:zorba
Validation queue succeeded - proposal merged! -- https://code.launchpad.net/~zorba-coders/zorba/win-fix/+merge/189190 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/win-fix into lp:zorba
Validation queue result for https://code.launchpad.net/~zorba-coders/zorba/win-fix/+merge/189190 Stage "TestZorbaUbuntu" failed. 17 tests failed (8560 total tests run). Check test results at http://jenkins.lambda.nu/job/TestZorbaUbuntu/354/testReport/ to view the results. -- https://code.launchpad.net/~zorba-coders/zorba/win-fix/+merge/189190 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/win-fix into lp:zorba
Validation queue starting for the following merge proposals: https://code.launchpad.net/~zorba-coders/zorba/win-fix/+merge/189190 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https://code.launchpad.net/~zorba-coders/zorba/win-fix/+merge/189190 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/win-fix into lp:zorba
Validation queue starting for the following merge proposals: https://code.launchpad.net/~zorba-coders/zorba/win-fix/+merge/189190 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https://code.launchpad.net/~zorba-coders/zorba/win-fix/+merge/189190 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
