Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-06-17 Thread Chris Hillery
After that, I'm afraid we've got some more substantive changes to be made to JSON-ify this module. I'll update the bug with details. If you'd like, we could merge this first pass (after you've addressed the coding guidelines issues) and then have a separate proposal for the JSONiq updates; other

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-06-17 Thread Chris Hillery
Luis - thanks for getting to this module so quickly. Based on this you've raised some coding-guideline issues, such as the use of and error codes. After discussion with Matthias, I've proposed some clarifications to the coding guidelines document on the Wiki; please take a look and update this

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-06-17 Thread Chris Hillery
Review: Needs Fixing See the updated task description on the bug report. Also, see the updated coding guidelines for and error codes. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188062/+merge/169946 Your team Zorba Coders is subscribed to branch lp:zorba/queue-module. -- Mailing li

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-06-17 Thread Chris Hillery
Review: Needs Fixing -- https://code.launchpad.net/~zorba-coders/zorba/bug-1188061/+merge/169553 Your team Zorba Coders is subscribed to branch lp:zorba/stack-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launc

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-test into lp:zorba

2013-06-18 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/zorba-test into lp:zorba has been updated. Status: Code failed to merge => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba-test/+merge/169747 -- https://code.launchpad.net/~zorba-coders/zorba/zorba-test/+m

[Zorba-coders] [Merge] lp:~ceejatec/zorba/http-client-test into lp:zorba/http-client-module

2013-06-18 Thread Chris Hillery
The proposal to merge lp:~ceejatec/zorba/http-client-test into lp:zorba/http-client-module has been updated. Status: Code failed to merge => Needs review For more details, see: https://code.launchpad.net/~ceejatec/zorba/http-client-test/+merge/169748 -- https://code.launchpad.net/~ceejatec/

[Zorba-coders] [Merge] lp:~ceejatec/zorba/http-client-test into lp:zorba/http-client-module

2013-06-18 Thread Chris Hillery
The proposal to merge lp:~ceejatec/zorba/http-client-test into lp:zorba/http-client-module has been updated. Status: Needs review => Code failed to merge For more details, see: https://code.launchpad.net/~ceejatec/zorba/http-client-test/+merge/169748 -- https://code.launchpad.net/~ceejatec/

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/zorba-test into lp:zorba

2013-06-18 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/zorba-test into lp:zorba has been updated. Status: Needs review => Code failed to merge For more details, see: https://code.launchpad.net/~zorba-coders/zorba/zorba-test/+merge/169747 -- https://code.launchpad.net/~zorba-coders/zorba/zorba-test/+m

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_data-cleaning-module into lp:zorba/data-cleaning-module

2013-06-18 Thread Chris Hillery
Review: Needs Fixing 1. Need to put tags between doc paragraphs, including after leading short description. (Remove tags.) 2. The error in currency-convert() should be in the module's own namespace/prefix, with ALL-CAPS name. 3. Based on the test cases, some other functions also raise errors

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/correct_LP_bug_number into lp:zorba

2013-06-19 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/correct_LP_bug_number/+merge/170309 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/correct_LP_bug_number into lp:zorba

2013-06-19 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/correct_LP_bug_number into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/correct_LP_bug_number/+merge/170309 -- https://code.launchpad.net/~zorba-coders/zorba/cor

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-06-19 Thread Chris Hillery
> Also, add a note on the module documentation section about using the header > jsoniq version "1.0"; at the top and put a link to a page that describes this > header. Cezar, it is not necessary for users to have a jsoniq version header in their queries to use this module. They can use ("field")

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-tutorial-schema into lp:zorba

2013-06-20 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/fix-tutorial-schema into lp:zorba. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-tutorial-schema/+merge/170582 This fixes tests on the RQ broken by the http

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-tutorial-schema into lp:zorba

2013-06-20 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-tutorial-schema/+merge/170582 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-tutorial-schema into lp:zorba

2013-06-20 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fix-tutorial-schema into lp:zorba has been updated. Commit Message changed to: Moved "tutorial" schema into same pool as http-test-data; updated URIs. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix-tutorial-schema/+merge/17

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/json-http-module into lp:zorba

2013-06-20 Thread Chris Hillery
IMHO, it's not a good idea to have any notes in module docs about how to use JSONiq. Virtually ask of our modules will have the same concerns, so we'd need to duplicate it dozens of times. This isn't the appropriate location for that information. I would take out that doc. -- https://code.launc

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new_xqdoc_sorin into lp:zorba

2013-06-21 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new_xqdoc_sorin/+merge/169654 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new_tags_security into lp:zorba/security-module

2013-06-21 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new_tags_security/+merge/170758 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://l

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new_tags_security into lp:zorba/security-module

2013-06-21 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new_tags_security into lp:zorba/security-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new_tags_security/+merge/170758 -- https://code.launchpad.net/~zorba-coders/z

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new_tags_security into lp:zorba/security-module

2013-06-21 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new_tags_security into lp:zorba/security-module has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new_tags_security/+merge/170758 -- https://code.launchpad.net/~zorba-coders/z

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new_tags_security into lp:zorba/security-module

2013-06-21 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new_tags_security into lp:zorba/security-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new_tags_security/+merge/170758 -- https://code.launchpad.net/~zorba-coders/z

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/environ-mac-fix into lp:zorba/process-module

2013-06-21 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/environ-mac-fix/+merge/170732 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://laun

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/environ-mac-fix into lp:zorba/process-module

2013-06-21 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/environ-mac-fix into lp:zorba/process-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/environ-mac-fix/+merge/170732 -- https://code.launchpad.net/~zorba-coders/zorba/

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_couchbase_update into lp:zorba/couchbase-module

2013-06-24 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/install_couchbase_update into lp:zorba/couchbase-module. Commit message: Updated install script for Couchbase 2.0.1 and Ubuntu 12.04; some cleanup Requested reviews: Juan Zacarias (juan457) Chris Hillery (ceejatec) For more details

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_couchbase_update into lp:zorba/couchbase-module

2013-06-24 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/install_couchbase_update/+merge/171023 Your team Zorba Coders is subscribed to branch lp:zorba/couchbase-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : h

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_couchbase_update into lp:zorba/couchbase-module

2013-06-24 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/install_couchbase_update into lp:zorba/couchbase-module has been updated. Commit Message changed to: Updated install script for Couchbase 2.0.1 and Ubuntu 12.04; some cleanup For more details, see: https://code.launchpad.net/~zorba-coders/zorba/insta

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module

2013-06-24 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module. Requested reviews: Cezar Andrei (cezar-andrei) Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module

2013-06-24 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://la

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module

2013-06-24 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-missing-functions/+merge/171040

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module

2013-06-24 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-missing-functions/+merge/171040 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsu

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module

2013-06-24 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-missing-functions/+merge/171040 -- https://c

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba

2013-06-24 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/info-extraction-yahoo-broken/+merge/171045 -- https://code.launchpad.net

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba

2013-06-24 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/info-extraction-yahoo-broken/+merge/171045 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba/info-extraction-module

2013-06-24 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba/info-extraction-module. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/info-extraction-yahoo-broken/+merge/171046 -- https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba/info-extraction-module

2013-06-24 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/info-extraction-yahoo-broken/+merge/171046 Your team Zorba Coders is subscribed to branch lp:zorba/info-extraction-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsub

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:zorba

2013-06-24 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/new-rq-fots into lp:zorba. Commit message: Re-enabling tests which pass on the new RQ machine. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171053

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:zorba

2013-06-24 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171053 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:zorba

2013-06-24 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:zorba has been updated. Commit Message changed to: Re-enabling tests which pass on the new RQ machine. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171053 -- https://code.launchpad.net/

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba/info-extraction-module

2013-06-25 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba/info-extraction-module has been updated. Status: Superseded => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/info-extraction-yahoo-broken/+merge/171046 -- https://cod

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module

2013-06-25 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module has been updated. Status: Superseded => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-missing-functions/+merge/171040 -- https:/

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:~zorba-coders/zorba/test-info-extraction-module

2013-06-25 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:~zorba-coders/zorba/test-info-extraction-module. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/info-extraction-yahoo-broken

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:zorba

2013-06-25 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:zorba has been updated. Status: Superseded => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171053 -- https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/17

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:~zorba-coders/zorba/test-data-cleaning-module

2013-06-25 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:~zorba-coders/zorba/test-data-cleaning-module. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-missing-functions

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk

2013-06-25 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk. Requested reviews: Chris Hillery (ceejatec) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171250 -- https://code.launchpad.net/~zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk

2013-06-25 Thread Chris Hillery
Review: Disapprove -- https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171250 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/test-trunk. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : ht

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk

2013-06-25 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk has been updated. Status: Code failed to merge => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171250 -- https://code.launchpad.net/~zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk

2013-06-25 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-missing-functions/+merge/171249 https://code.launchpad.net/~zorba-coders/zorba/info-extraction-ya

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk

2013-06-26 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk has been updated. Commit Message changed to: This is my commit. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171250 -- https://code.launchpad.net/~zorba-c

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba

2013-06-26 Thread Chris Hillery
Per conf call today: yes, convert this to "pure JSONiq". That means, at least, having the "jsoniq" version declaration in the module, and eliminating the xs: prefix from all signatures. Not sure if anything else needs to be (or can be) done. For the time being the file extension should remain .

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module

2013-06-26 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032 -- https://code.launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk

2013-06-26 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk has been updated. Status: Merged => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171250 -- https://code.launchpad.net/~zorba-coders/zorba/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk

2013-06-26 Thread Chris Hillery
merge 171248 -- https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171250 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/test-trunk. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://la

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:~zorba-coders/zorba/test-data-cleaning-module

2013-06-26 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-missing-functions/+merge/171249 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/test-data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@list

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:~zorba-coders/zorba/test-info-extraction-module

2013-06-26 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/info-extraction-yahoo-broken/+merge/171248 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/test-info-extraction-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk

2013-06-26 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171250 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/test-trunk. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:~zorba-coders/zorba/test-trunk has been updated. Status: Merged => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171250 -- https://code.launchpad.net/~zorba-coders/zorba/

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:zorba

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171053 -- https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/1710

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module has been updated. Commit Message changed to: Added EXPECTED_FAILURE()s for tests that appear to depend on webservices that no longer exist. For more details, see: https://code.launch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba/info-extraction-module

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba/info-extraction-module has been updated. Commit Message changed to: Added EXPECTED_FAILURE() for test broken by missing Yahoo functionality. For more details, see: https://code.launchpad.net/~zorba-coders/zo

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/data-cleaning-missing-functions into lp:zorba/data-cleaning-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/data-cleaning-missing-functions/+merge/171040 -- https://c

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba/info-extraction-module

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/info-extraction-yahoo-broken into lp:zorba/info-extraction-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/info-extraction-yahoo-broken/+merge/171046 -- https://code.

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:zorba

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171053 -- https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/1710

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189798-stack into lp:zorba/stack-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189798-stack/+merge/171308 Your team Zorba Coders is subscribed to branch lp:zorba/stack-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://laun

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189798 into lp:zorba

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1189798 into lp:zorba has been updated. Description changed to: Relocated and renamed Zorba errors & warnings "modules." This merge must be performed at the same time as https://code.launchpad.net/~zorba-coders/zorba/bug-1189798-stack/+merge/171

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189798 into lp:zorba

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189798/+merge/171183 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1189798-queue into lp:zorba/queue-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1189798-queue/+merge/171309 Your team Zorba Coders is subscribed to branch lp:zorba/queue-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://laun

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-rq-fots into lp:zorba

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/new-rq-fots into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/171053 -- https://code.launchpad.net/~zorba-coders/zorba/new-rq-fots/+merge/1710

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052 into lp:zorba

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1158052 into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-read-pdf/+merge/170949 https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-oracle-nosql-db/+merge/170948 https://

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052 into lp:zorba

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052/+merge/170725 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052 into lp:zorba

2013-06-27 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1158052 into lp:zorba has been updated. Description changed to: https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-read-pdf/+merge/170949 https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-oracle-nosql-db/+merge/170948 https://code

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-image into lp:zorba/image-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-image/+merge/170946 Your team Zorba Coders is subscribed to branch lp:zorba/image-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://laun

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-jdbc into lp:zorba/jdbc-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-jdbc/+merge/170947 Your team Zorba Coders is subscribed to branch lp:zorba/jdbc-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-sqlite into lp:zorba/sqlite-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-sqlite/+merge/170953 Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://la

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-couchbase into lp:zorba/couchbase-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-couchbase/+merge/170951 Your team Zorba Coders is subscribed to branch lp:zorba/couchbase-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : http

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-security into lp:zorba/security-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-security/+merge/170950 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-geo into lp:zorba/geo-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-geo/+merge/170945 Your team Zorba Coders is subscribed to branch lp:zorba/geo-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpa

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-data-formatting into lp:zorba/data-formatting-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-data-formatting/+merge/170944 Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubs

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-oracle-nosql-db into lp:zorba/oracle-nosql-db-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-oracle-nosql-db/+merge/170948 Your team Zorba Coders is subscribed to branch lp:zorba/oracle-nosql-db-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubs

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-read-pdf into lp:zorba/read-pdf-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-read-pdf/+merge/170949 Your team Zorba Coders is subscribed to branch lp:zorba/read-pdf-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1158052-archive into lp:zorba/archive-module

2013-06-27 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1158052-archive/+merge/170943 Your team Zorba Coders is subscribed to branch lp:zorba/archive-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fake-change into lp:zorba

2013-06-30 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/fake-change into lp:zorba. Commit message: Fake Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/172254 -- https://code.launchpad.net/~zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fake-change into lp:zorba

2013-06-30 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fake-change into lp:zorba has been updated. Commit Message changed to: Fake For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/172254 -- https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/172254 Y

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fake-change into lp:zorba

2013-06-30 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fake-change into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/172254 -- https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/1722

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fake-change into lp:zorba

2013-06-30 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/fake-change into lp:zorba has been updated. Status: Approved => Work in progress For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/172254 -- https://code.launchpad.net/~zorba-coders/zorba/fake-change/+merge/

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-code into lp:zorba

2013-07-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/broken-code into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/broken-code/+merge/172435 This commit also requires merging https://code.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-test into lp:zorba

2013-07-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/broken-test into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/broken-test/+merge/172436 -- https://code.launchpad.net/~zorba-coders/zorba/broken-test

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-code into lp:zorba

2013-07-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/broken-code into lp:zorba has been updated. Description changed to: This commit also requires merging https://code.launchpad.net/~zorba-coders/zorba/broken-test/+merge/172436 . For more details, see: https://code.launchpad.net/~zorba-coders/zorba/br

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-code into lp:zorba

2013-07-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/broken-code into lp:zorba has been updated. Description changed to: This commit also requires merging https://code.launchpad.net/~zorba-coders/zorba/broken-test/+merge/172436. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bro

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-code into lp:zorba

2013-07-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/broken-code into lp:zorba has been updated. Description changed to: For more details, see: https://code.launchpad.net/~zorba-coders/zorba/broken-code/+merge/172435 -- https://code.launchpad.net/~zorba-coders/zorba/broken-code/+merge/172435 Your tea

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-test into lp:zorba

2013-07-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/broken-test into lp:zorba has been updated. Description changed to: This change depends on https://code.launchpad.net/~zorba-coders/zorba/broken-security-test/+merge/172439. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/broke

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/broken-security-test into lp:zorba/security-module

2013-07-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/broken-security-test into lp:zorba/security-module. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/broken-security-test/+merge/172439 -- https://code.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-trunk into lp:zorba

2013-07-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/dummy-trunk into lp:zorba. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dummy-trunk/+merge/172447 This change depends on https://code.launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-security-module into lp:zorba/security-module

2013-07-01 Thread Chris Hillery
Chris Hillery has proposed merging lp:~zorba-coders/zorba/dummy-security-module into lp:zorba/security-module. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dummy-security-module/+merge/172448 -- https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-security-module into lp:zorba/security-module

2013-07-01 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/dummy-security-module/+merge/172448 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-trunk into lp:zorba

2013-07-01 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/dummy-trunk/+merge/172447 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dummy-trunk into lp:zorba

2013-07-01 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/dummy-trunk into lp:zorba has been updated. Description changed to: This change depends on https://code.launchpad.net/~zorba-coders/zorba/dummy-security-module/+merge/172448. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dumm

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_datetime-module into lp:zorba

2013-07-02 Thread Chris Hillery
Review: Needs Fixing Error codes need updating. Rest of the changes look good. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_datetime-module/+merge/172685 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188062 into lp:zorba/queue-module

2013-07-09 Thread Chris Hillery
Review: Needs Fixing 1. Error QNames should not be declared as public constants (see coding guidelines). Declare them as private variables as follows: declare %private variable $queue:NOT-EXISTS as xs:QName := fn:QName($queue:ERR-NS, "queue:NOT-EXISTS"); 2. The current XQDoc for those error QN

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188061 into lp:zorba/stack-module

2013-07-09 Thread Chris Hillery
Review: Needs Fixing Basically the same comments as the queue proposal: 1. Make the error QName variables %private; 2. Fix or eliminate the XQDoc for the error QNames; 3. Replace "node" with "item" in function XQDoc. In addition: 4. You have a stray at the beginning of the header XQDoc comment

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/http-client-based-on-json-http-client into lp:zorba/http-client-module

2013-07-09 Thread Chris Hillery
Review: Needs Information 1. Do we need to promote this to version 2.0 of the EXpath module? Isn't the public API exactly the same, as defined by EXpath? I understand the implementation is different, but I don't believe that's relevant for module versioning. 2. (Possibly the same question) Do

<    1   2   3   4   5   6   7   8   9   10   >