Review: Needs Information
1. Do we need to promote this to version 2.0 of the EXpath module? Isn't the
public API exactly the same, as defined by EXpath? I understand the
implementation is different, but I don't believe that's relevant for module
versioning.
2. (Possibly the same question)
The proposal to merge lp:~zorba-coders/zorba/http-client-wrapper into lp:zorba
has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
--
Depends on lp:~zorba-coders/zorba/http-client-wrapper
--
https://code.launchpad.net/~zorba-coders/zorba/http-client-based-on-json-http-client/+merge/169578
Your team Zorba Coders is subscribed to branch lp:zorba/http-client-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to
To avoid replicating conversion code (600-700 lines) between the core XML http
client and the Expath http client as discussed in:
https://code.launchpad.net/~zorba-coders/zorba/http-client-based-on-json-http-client/+merge/169578
I introduced a wrapper module for doing all conversions.
--
Federico Cavalieri has proposed merging
lp:~zorba-coders/zorba/expath-http-on-json-http into
lp:zorba/http-client-module.
Requested reviews:
Cezar Andrei (cezar-andrei)
Chris Hillery (ceejatec)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http
The proposal to merge lp:~zorba-coders/zorba/expath-http-on-json-http into
lp:zorba/http-client-module has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http/+merge/176996
--
Federico Cavalieri has proposed merging
lp:~zorba-coders/zorba/expath-http-on-json-http into
lp:zorba/http-client-module.
Requested reviews:
Cezar Andrei (cezar-andrei)
Chris Hillery (ceejatec)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/expath-http-on-json-http
Ready for review.
This is updates the expath http client to be based on the wrapper module
introduced in lp:~zorba-coders/zorba/http-client-wrapper
The comments of the previous branch (outdated links, wrapper conversion module)
have been addressed.
--
The proposal to merge lp:~zorba-coders/zorba/http-client-wrapper into lp:zorba
has been updated.
Commit Message changed to:
HTTP client request/response conversion in a separate module
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/http-client-wrapper/+merge/176980
--
Apparently the Expath HTTP Client queries 2 and 3 fail on the zorba demo website
(http://zorbawebsite2.my28msec.com/html/demo)
This does not seem to depend on the latest http client merge which apparently
is not there yet.
Is this a known problem?
--
Given the comments I received for the http-module I fear that the way I am
disconnecting from cloudant is not correct, because curl_global_init/cleanup
must not be called multiple times from different modules.
I tried disconnecting invoking an XQuery function but this does not work
because the
Hi Chris,
thanks for the quick review.
I think it is currently a core module due to the auto-disconnect functionality.
External module can have cpp external functions?
However, as I wrote in my previous comment, this feature is almost certainly
wrong at the moment.
If I recall correctly,
Actually, a few code problems:
1. ConnectionMap::destroy() invokes a function in the
http://28msec.io/modules/cloudant namespace. I think that should be in
http://zorba.io/modules/cloudant, right?
This is commented out :) I tried doing it in XQuery but I didn't manage so I
left the code
Ahh, I see, that call in ConnectionMap::destroy() is commented out. Didn't
notice that the first time.
Regarding the curl disconnect problems: That would all go away if this module
used the http-client module, rather than using C++ to invoke CURL directly. Is
there a reason this module
The proposal to merge lp:~zorba-coders/zorba/expath-http-on-json-http into
lp:zorba/http-client-module has been updated.
Commit Message changed to:
Updated the expath http client on top of the json http client
For more details, see:
The proposal to merge lp:~zorba-coders/zorba/expath-http-on-json-http into
lp:zorba/http-client-module has been updated.
Commit Message changed to:
Updated the expath http client to use the json http client
For more details, see:
I agree that an external module is best suited for this module.
I will look in the wiki to see the submit procedure.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-cloudant/+merge/177111
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
I did not find a description of the process necessary to propose a new module
in the wiki.
What should I do?
Thanks
--
https://code.launchpad.net/~zorba-coders/zorba/feature-cloudant/+merge/177111
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Federico Cavalieri has proposed merging lp:~zorba-coders/zorba/bug1207668 into
lp:zorba.
Commit message:
Fixed bug 1207668
Requested reviews:
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug1207668/+merge/178223
Fixed bug
- The indentation has several problems. Could you please make it consistent.
Especially in the C++ code.
sure.
- Why don't you use the same approach as we did for xbrl-cloud and keep the
connection map in JSONiq (using the map module)? I think that would be more
appropriate for this module
Module in lp:~zorba-coders/zorba/cloudant-module
--
https://code.launchpad.net/~zorba-coders/zorba/feature-external-cloudant-module/+merge/178255
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Resubmit
External module merge proposal in
lp:~zorba-coders/zorba/feature-external-cloudant-module
and
lp:~zorba-coders/zorba/cloudant-module
--
https://code.launchpad.net/~zorba-coders/zorba/feature-cloudant/+merge/177111
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Ready for review
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
nope, let me fix it
On Wed, Aug 14, 2013 at 3:14 PM, Ghislain Fourny ghislain.fou...@28msec.com
wrote:
One of the tests uses ext:nomaterialization without dash. Is this intented?
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044
Your team Zorba Coders is
Fixed and pushed
On Wed, Aug 14, 2013 at 9:36 PM, Federico Cavalieri
federico.cavali...@28msec.com wrote:
nope, let me fix it
On Wed, Aug 14, 2013 at 3:14 PM, Ghislain Fourny
ghislain.fou...@28msec.com wrote:
One of the tests uses ext:nomaterialization without dash. Is this
intented
Thanks for the review.
Can you explain me why
SYNC_CODE(theCollection-theLatch.rlock();)
and
SYNC_CODE(theCollection-theLatch.unlock();)
has been commented in this branch?
They were already commented in the branch when I started working on it.
--
Thanks for the feedback.
Merging
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1026250/+merge/138044
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Federico Cavalieri has proposed merging
lp:~zorba-coders/zorba/fix-random-annotation into lp:zorba.
Commit message:
Fixed random#0 function annotation.
Requested reviews:
Zorba Coders (zorba-coders)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-random-annotation
Federico Cavalieri has proposed merging
lp:~zorba-coders/zorba/fix-dbedit-parse-xml-segfault into lp:zorba.
Commit message:
Fixed db:edit and fn:parse-xml segfault
Requested reviews:
Zorba Coders (zorba-coders)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-dbedit
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix-random-annotation/+merge/199706
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
Validation queue result for https://code.launchpad.net/~zorba-coders/zorba
/fix-dbedit-parse-xml-segfault/+merge/199707
Stage CommitZorba failed.
Check console output at
http://jenkins.lambda.nu:8180/job/CommitZorba/260/console to view the results.
--
Federico Cavalieri has proposed merging
lp:~zorba-coders/zorba/fix-accesses-dyn-ctx into lp:zorba.
Commit message:
Fixed dynamic context access declaration in the General Functions and Operators
on Sequences module
Requested reviews:
Federico Cavalieri (fcavalieri)
For more details, see
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix-accesses-dyn-ctx/+merge/200322
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix-external_func_exceptions/+merge/200922
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
I found a regression, investigating
--
https://code.launchpad.net/~zorba-coders/zorba/fix-fncall-iterator/+merge/215934
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix-fncall-iterator/+merge/215934
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/http-client-update/+merge/216204
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Federico Cavalieri has proposed merging
lp:~zorba-coders/zorba/http-client-update into lp:zorba.
Commit message:
Updated http client with deterministic send-request functions, improved
documentation, transparent retries and patch method support.
Requested reviews:
Matthias Brantner (matthias
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/feature-caching/+merge/216291
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/feature-caching-annotations/+merge/216293
Your team Zorba Coders is subscribed to branch
lp:~zorba-coders/zorba/feature-caching.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix-boost-typedef/+merge/217976
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The choice of the data structure to hold the flags is open to discussion.
I considered:
- std::bitset
- uint64
- vectorbool (storage optimized specialization is mandated by the standard)
The size of std::bitset is determined at compile time, boost:dynamic_bitset
brings the boost dependency,
Federico Cavalieri has proposed merging
lp:~zorba-coders/zorba/fix-boost-typedef into lp:zorba.
Commit message:
Removed boost dependency
Fixed typedef
Requested reviews:
Matthias Brantner (matthias-brantner)
Federico Cavalieri (fcavalieri)
Paul J. Lucas (paul-lucas)
For more details, see
Review: Approve
I have the same question as Matthias, maybe it make sense to offer the feature
for all module level variable declarations.
Apart from that, it looks good.
--
https://code.launchpad.net/~zorba-coders/zorba/api-var-annot/+merge/218485
Your team Zorba Coders is subscribed to branch
101 - 144 of 144 matches
Mail list logo
