Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-05 Thread Nicolae Brinza
Ghislain, I've fixed the null/true/false etc and select issues (points 5 and 8). -- -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-03 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Commit Message changed to: Parsers updates. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-03 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-03 Thread Nicolae Brinza
1. Parser.y, line 2259: is || (block != NULL block-isEmpty()) really needed? Will block not always be null if a BlockExpr is {} (see StatementsAndOptionalExpr nonterminal)? Nope, you can have a nested empty block {{}}. 2. Why is the OBJECT token treated specially and not mentioned in

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-02 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183479 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183479

[Zorba-coders] [Merge] lp:~nbrinza/zorba/trunk-test into lp:zorba

2013-09-02 Thread Nicolae Brinza
The proposal to merge lp:~nbrinza/zorba/trunk-test into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/trunk-test/+merge/183495 -- https://code.launchpad.net/~nbrinza/zorba/trunk-test/+merge/183495 Your team Zorba

[Zorba-coders] [Merge] lp:~nbrinza/zorba/trunk-test into lp:zorba

2013-09-02 Thread Nicolae Brinza
Nicolae Brinza has proposed merging lp:~nbrinza/zorba/trunk-test into lp:zorba. Commit message: Test merge. Requested reviews: Nicolae Brinza (nbrinza) For more details, see: https://code.launchpad.net/~nbrinza/zorba/trunk-test/+merge/183495 Test merge. -- https://code.launchpad.net

[Zorba-coders] [Merge] lp:~nbrinza/zorba/trunk-test into lp:zorba

2013-09-02 Thread Nicolae Brinza
The proposal to merge lp:~nbrinza/zorba/trunk-test into lp:zorba has been updated. Status: Merged = Rejected For more details, see: https://code.launchpad.net/~nbrinza/zorba/trunk-test/+merge/183495 -- https://code.launchpad.net/~nbrinza/zorba/trunk-test/+merge/183495 Your team Zorba

[Zorba-coders] [Merge] lp:~nbrinza/zorba/trunk-test2 into lp:zorba

2013-09-02 Thread Nicolae Brinza
The proposal to merge lp:~nbrinza/zorba/trunk-test2 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504 -- https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504 Your team

[Zorba-coders] [Merge] lp:~nbrinza/zorba/trunk-test2 into lp:zorba

2013-09-02 Thread Nicolae Brinza
Nicolae Brinza has proposed merging lp:~nbrinza/zorba/trunk-test2 into lp:zorba. Commit message: Test merge. Requested reviews: Nicolae Brinza (nbrinza) For more details, see: https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504 Test merge. -- https://code.launchpad.net

[Zorba-coders] [Merge] lp:~nbrinza/zorba/trunk-test2 into lp:zorba

2013-09-02 Thread Nicolae Brinza
The proposal to merge lp:~nbrinza/zorba/trunk-test2 into lp:zorba has been updated. Status: Approved = Rejected For more details, see: https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504 -- https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504 Your team Zorba

[Zorba-coders] [Merge] lp:~nbrinza/zorba/trunk-test2 into lp:zorba

2013-09-02 Thread Nicolae Brinza
The proposal to merge lp:~nbrinza/zorba/trunk-test2 into lp:zorba has been updated. Status: Rejected = Approved For more details, see: https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504 -- https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504 Your team Zorba

[Zorba-coders] [Merge] lp:~nbrinza/zorba/trunk-test2 into lp:zorba

2013-09-02 Thread Nicolae Brinza
The proposal to merge lp:~nbrinza/zorba/trunk-test2 into lp:zorba has been updated. Status: Approved = Rejected For more details, see: https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504 -- https://code.launchpad.net/~nbrinza/zorba/trunk-test2/+merge/183504 Your team Zorba

[Zorba-coders] [Merge] lp:~nbrinza/zorba/error-messages into lp:zorba

2013-08-21 Thread Nicolae Brinza
The proposal to merge lp:~nbrinza/zorba/error-messages into lp:zorba has been updated. Commit Message changed to: Fixed bugs #1210320 and #1212423 - misplaced compiler error For more details, see: https://code.launchpad.net/~nbrinza/zorba/error-messages/+merge/181327 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/use-dataguide into lp:zorba

2013-08-20 Thread Nicolae Brinza
Paul, I've also addressed your comments on the merge proposal. -- -- https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/use-dataguide into lp:zorba

2013-08-19 Thread Nicolae Brinza
I have fixed issues 1 through 3. Regarding point 4: your approach, if I understood it correctly, will only build the dataflow information, but not the dataguide itself. To compute it, it would require an additional pass through the expression tree and an additional data structure. Regarding

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/skip-items into lp:zorba

2013-07-26 Thread Nicolae Brinza
I've fixed the crash and added the query as zorba/eval/eval16.xq. -- -- https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/use-dataguide into lp:zorba

2013-07-26 Thread Nicolae Brinza
I don't understand why. In my example it wouldn't. The count functions could count the number of empty objects or objects that contain only the STREET field. I've looked into the test and here are the issues: 1) The fn:count() does not have the %explores-json annotation. I've confused it with

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/use-dataguide into lp:zorba

2013-07-26 Thread Nicolae Brinza
Ok, it wasn't too much work -- I've added a special handler for fn:count() in the dataguide code and now the example you gave prunes all the fields except price. -- -- https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385 Your team Zorba Coders is subscribed to branch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/use-dataguide into lp:zorba

2013-07-26 Thread Nicolae Brinza
I meant the STREET field. I've used price in the testcase. -- https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/use-dataguide into lp:zorba

2013-07-26 Thread Nicolae Brinza
I have no idea what problem this MP is supposed to solve; nor do I know what a data guide is. Paul, I've made some changes to the JSON loader so that it skips creating nodes that are not in a given template (== dataguide). Since you've written the loader, could you please review only the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/use-dataguide into lp:zorba

2013-07-26 Thread Nicolae Brinza
The way I see this is not a problem with the fn functions. The problem is related to the fact how the objects are used. In this case, the objects are used to construct a new object. The dataguide needs to handle that. Similar to serialization, this means that the entire object is needed. Yes,

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/use-dataguide into lp:zorba

2013-07-25 Thread Nicolae Brinza
I have tried some basic queries and there is a huge performance improvement. This is great. However, I detected a memory leak and have one question. - memory leak in translator.cpp:4823 I've fixed it. - In the following query, no dataguide seems to be pushed into the parser. Why? The

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/skip-items into lp:zorba

2013-07-25 Thread Nicolae Brinza
- In ZorbaCollectionIterator::initCollection lines 307 and 326, you eventually add skipCount twice. Something smells spooky here. Yes, it seems it was added twice. I've fixed it. I've also added the skip() function to the EvalIterator. -- --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/skip-items into lp:zorba

2013-07-23 Thread Nicolae Brinza
I've looked into the index probe iterators but they already optimize any skipping. They take a Skip parameter and then they push it into an underlying iterator e.g. ProbeValueTreeIndexIterator which handles the skip internally. So there is nothing to be done there. I've pushed the pending

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/dataguide into lp:zorba

2013-07-23 Thread Nicolae Brinza
I've done some additional testing, and these are the results: For the xray query, the largest that we have in the testsuite, compilation time with --compile-only is pretty much the same with and without the dataguide computaiton, at around ~0.08 sec. With a specially constructed query that

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/use-dataguide into lp:zorba

2013-07-23 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/use-dataguide/+merge/176385 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/skip-items into lp:zorba

2013-07-19 Thread Nicolae Brinza
- Shouldn't skip take an unsigned integer? The parameters to fn:subsequence and co are all signed. E.g. you can pass a negative skip. - Why is the while loop in collections_impl.cpp:397 necessary if initCollection is called before? I think there might be a bug in initCollection.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/dataguide into lp:zorba

2013-07-19 Thread Nicolae Brinza
DataGuides serve as dynamic schemas, generated from the database. What we generate is a schema from the query. Still, it is a data schema, not a query schema. The one in the paper would be a Database DataGuide and ours would be Query DataGuide. I would agree to change it to

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/dataguide into lp:zorba

2013-07-18 Thread Nicolae Brinza
- I find the name dataguide misleading because it's a guide on the query and not on the data. Maybe QueryPruneGuide would be more meaningful The query itself is not pruned, the data is. I think dataguide is the established term -- see for example this paper:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/skip-items into lp:zorba

2013-07-17 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/dataguide into lp:zorba

2013-07-17 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/dataguide/+merge/173026 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/skip-items into lp:zorba

2013-07-15 Thread Nicolae Brinza
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/skip-items into lp:zorba. Commit message: Implemented the Skip-items facility Requested reviews: Nicolae Brinza (nbrinza) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/skip-items/+merge/174723 Implemented

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-07-10 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/dataguide into lp:zorba

2013-07-04 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/dataguide into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/dataguide/+merge/173026 -- https://code.launchpad.net/~zorba-coders/zorba/dataguide/+merge/173026

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-06-27 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Commit Message changed to: Changed module's errors to the new modules guidelines; Potential fix for execvpe() on Macs For more details, see:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-06-27 Thread Nicolae Brinza
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module. Commit message: Changed module's errors to the new modules guidelines; Potential fix for execvpe() on Macs Requested reviews: Nicolae Brinza (nbrinza) Ghislain Fourny (gislenius) Related bugs

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-06-27 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-06-27 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-06-27 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/171824 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-06-13 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-06-13 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-06-13 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-06-13 Thread Nicolae Brinza
I've merged Paul's change -- it was only a one line change. -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-10 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167907 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167907

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-10 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-10 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-10 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-10 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-07 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-07 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167907 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167907

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/array-unboxing into lp:zorba

2013-06-07 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/array-unboxing into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/array-unboxing/+merge/168099 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-06 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-06 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-06 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-06-04 Thread Nicolae Brinza
For some reason, the commits to my checked-out branch are not pushed automatically, and I forgot to do it manually. It is pushed now. I've also fixed all issues you reported except for the namespace change to zorba.io. As far as I understood, it will be done for all modules at once -- it is

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1182910 into lp:zorba

2013-06-04 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/fix_bug_1182910 into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1182910/+merge/167369 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1182910 into lp:zorba

2013-06-04 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1182910/+merge/167369 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-06-03 Thread Nicolae Brinza
Matthias, They URI messages won't appear anymore, but I've done it by calling abort() instead of exit() in the child fork() in the process module, because: -- it will keep the Zorba URIs leaks messages in the Release build -- the exit code in the case of an error is lost anyway due to the

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-27 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-27 Thread Nicolae Brinza
I've fixed all the issues except for the leaks problem. I have not removed the printing of the URIs because it would disable them for the entire Zorba engine. Even if the messages are removed there is still the problem of the exit code, which cannot be fixed easily now. -- --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-23 Thread Nicolae Brinza
Regarding the referenced URI messages -- these are indeed coming from the StringPool as leaked entries. When the main process is fork()'ed, the child process is basically a copy of the parent process with all the statically allocated objects duplicated. When the child process calls exit(),

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module. Commit message: Version 2.0 of the process module, allows running executables directly, without invoking bash/cmd.exe Requested reviews: Nicolae Brinza (nbrinza) Matthias Brantner (matthias

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164354 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module. Commit message: Version 2.0 of the process module, allows running executables directly, without invoking bash/cmd.exe Requested reviews: Nicolae Brinza (nbrinza) Matthias Brantner (matthias

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Commit Message changed to: Version 2.0 of the process module, allows running executables directly, without invoking bash/cmd.exe For more details, see:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 Your team Zorba Coders is subscribed to branch lp:zorba/process-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module

2013-05-17 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/process-2 into lp:zorba/process-module has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/process-2/+merge/164415 --

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-exec into lp:zorba

2013-05-16 Thread Nicolae Brinza
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/new-exec into lp:zorba. Commit message: Modified files that use the process module to request version 1.0, in preparation of the new version of the module. Requested reviews: Nicolae Brinza (nbrinza) Matthias Brantner (matthias

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-exec into lp:zorba

2013-05-16 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new-exec/+merge/164166 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-exec into lp:zorba

2013-05-16 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-exec into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-exec/+merge/164166 -- https://code.launchpad.net/~zorba-coders/zorba/new-exec/+merge/164166 Your

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/null-type-fix into lp:zorba

2013-05-15 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/null-type-fix/+merge/163883 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/new-jsoniq. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/null-type-fix into lp:~zorba-coders/zorba/new-jsoniq

2013-05-15 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/null-type-fix/+merge/163902 Your team Zorba Coders is subscribed to branch lp:~zorba-coders/zorba/new-jsoniq. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
I've added a mention in the ChangeLog -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Approved = Rejected For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 Your

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Rejected = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
Done -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
Yeah, I just fixed that unit test as well... -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Nicolae Brinza
The proposal to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Nicolae Brinza
Matthias, your suggestions for two improved warnings do not change the messages: you just switched the order of the words. The warnings are built around the template: feature not supported by the common language grammar{: $1} So it is not easy to make this swap. I could probably do it,

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Nicolae Brinza
Why would you need a qualified value if the option itself is already qualified? I guess because the option name and the option value may not live in the same namespace. Why not? It's not as if you do schema validation on the options and their values. The option needs to be qualified to

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Nicolae Brinza
(by the way, character entity references do not exist in XML. There are character references (#...;) and entity references (...;), but not both at the same time if I am correct :-) ) Indeed you're right. I trusted Wikipedia which uses the term character entity references and says ``The XML

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Nicolae Brinza
Fixed all the raised issues. -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1176038 into lp:zorba

2013-05-08 Thread Nicolae Brinza
Nicolae Brinza has proposed merging lp:~zorba-coders/zorba/bug-1176038 into lp:zorba. Commit message: Fixed a bug in the parser that was revealed by bison 2.7 + #include clean-up Requested reviews: Nicolae Brinza (nbrinza) Paul J. Lucas (paul-lucas) Related bugs: Bug #1176038 in Zorba

  1   2   3   4   5   >