[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
** Changed in: zorba Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: Fix Released Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
** Changed in: zorba Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: Fix Committed Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
** Branch linked: lp:~paul-lucas/zorba/bug-898075 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: In Progress Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
** Changed in: zorba Status: New => In Progress -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: In Progress Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
OK, I added a new Zorba error code, ZXQD0006_INVALID_UTF8_BYTE_SEQUENCE, and now throw that upon reading an invalid UTF-8 byte. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: New Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
Ignoring the optimization for the moment, I've applied William's patch. However, it didn't properly read UTF-8 characters. I've since added utf8::read() that reads UTF-8 byte sequence from an istream and am now using it. However, there's another TODO in the code -- what to do if utf8::read() reads an invalid UTF-8 byte sequence? -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: New Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
Recode it so it converts only one character at a time to a code-point. There's no need for a vector. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: New Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
So what do we do? -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: New Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
Perhaps, but the non-streaming case uses a large vector. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: New Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
I didn't understand that todo. Could you provide me more information? The vector size is always 1 with a string stream. The patch I provided works great with an infinite string. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: New Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
Read the "TODO" comment on line 113. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: New Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
I'm not sure I understand comment #5. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: New Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
It doesn't do anything about materializing the vector (which doesn't need to be done). -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: New Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
My patch is a little bit buggy but gives an idea on how to solve the problem. Should I continue on the issue and make a merge proposal or I leave it to Paul? -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: New Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
Paul, could you please investigate this issue. Does William's patch resolve this? ** Changed in: zorba Assignee: (unassigned) => Paul J. Lucas (paul-lucas) ** Changed in: zorba Milestone: None => 2.2 -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: New Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
The following patch implements the function with streamable string. -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: New Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Bug 898075] Re: fn:string-to-codepoints() doesn't stream
** Patch added: "string-to-codepoints.patch" https://bugs.launchpad.net/zorba/+bug/898075/+attachment/2613490/+files/string-to-codepoints.patch -- You received this bug notification because you are a member of Zorba Coders, which is the registrant for Zorba. https://bugs.launchpad.net/bugs/898075 Title: fn:string-to-codepoints() doesn't stream Status in Zorba - The XQuery Processor: New Bug description: fn:string-to-codepoints($string-stream) Doesn't work in a streaming manner. To manage notifications about this bug go to: https://bugs.launchpad.net/zorba/+bug/898075/+subscriptions -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
