Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
Review: Approve s/hust/just -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Approved = Work in progress For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-988417-block-internal-module-2012-05-05T02-07-02.544Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
Validation queue job bug-988417-block-internal-module-2012-05-05T02-07-02.544Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Commit Message changed to: enable blocking of internal modules by running through URI mapping (but not through URL resolution) during translation For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-988417-block-internal-module-2012-05-02T20-19-00.73Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
Validation queue job bug-988417-block-internal-module-2012-05-02T20-19-00.73Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 4 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
Review: Approve Ah, yes, I guess you want the exception to be thrown anyway. Cool, that works. -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/103542 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/104207 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
It seemed to me that the whole point of distinguishing between built-in modules and other modules here was that one does not want to invoke the the existing URI resolution mechanisms. Wanting to keep this spirit of the existing code, I proposed this solution. If that's not needed, then that's fine with me. (The one thing that I'm not extremely fond of is that we would invoke exceptions to find the answer to a simple question, but I can live with that.) Obviously going through the URIMapper mechanism would have the great advantage of not forcing the user of the API to find out which modules are internal and which ones aren't. This would also make programs written agains this API more robust wrt. to changes in the internal/external classification of modules. -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/103542 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
IMHO, the point of built-in modules was to prevent the overhead of *compiling* those modules, not bypassing URI resolution per se. It is true, though, that invoking URI resolution implies a bit of performance overhead. I believe that if only the URI mapping stage is invoked that the overhead will be relatively small. It probably is important to bypass the URL Resolution stage, because that's where things like making network connections to download the module might occur. I agree that using exceptions to communicate results isn't ideal, but I think the code reuse and API consolidation outweighs that concern in this case. However, it would actually be pretty easy to either modify apply_uri_mappers() or provide a slight variant of that method (with appropriate refactoring) which simply checked for DENY_ACCESS and returned a bool instead of throwing an exception. I could do that if you like. -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/103542 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-988417-block-internal-module into lp:zorba
I've changed this as proposed (I think) and added some tests. Having the exception throw directly seems to have the advantage that I get consistent behavior between internal and external modules - so that seems to be good. As resolution doesn't seem to happen in the current scenario, the only thing that's still not that nice is that we're updating the vector for something that's in principle a read-only operation. But, as you said, that's probably a minor overhead. -- https://code.launchpad.net/~zorba-coders/zorba/bug-988417-block-internal-module/+merge/103542 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
