Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-951772 into lp:zorba

2012-03-11 Thread William Candillon 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-951772 into lp:zorba

2012-03-11 Thread William Candillon 
The proposal to merge lp:~zorba-coders/zorba/bug-951772 into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-951772 into lp:zorba

2012-03-11 Thread Zorba Build Bot 
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/bug-951772-2012-03-11T20-07-13.451Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-951772 into lp:zorba

2012-03-11 Thread Zorba Build Bot 
Validation queue job bug-951772-2012-03-11T20-07-13.451Z is finished. The final 
status was:

All tests succeeded!
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-951772 into lp:zorba

2012-03-11 Thread noreply 
The proposal to merge lp:~zorba-coders/zorba/bug-951772 into lp:zorba has been 
updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-951772 into lp:zorba

2012-03-10 Thread Matthias Brantner 
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/bug-951772 into 
lp:zorba.

Requested reviews:
  Matthias Brantner (matthias-brantner)
  William Candillon (wcandillon)
Related bugs:
  Bug #951772 in Zorba: Comment node crashes serialization
  https://bugs.launchpad.net/zorba/+bug/951772

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910

fixed bug #951772 Comment node crashes serialization)
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'ChangeLog'
--- ChangeLog	2012-03-09 22:12:26 +
+++ ChangeLog	2012-03-11 03:27:21 +
@@ -23,6 +23,7 @@
   * Types-related optimizations for runtime operators (comparisons, FnBoolean, Or, And,
 Compare, instance-of, cast, castable, treat, promote).
   * Fixed bug #911585 (management of variables during eval)
+  * Fixed bug #951772 (Comment node crashes serialization)
   * Fixed bug #866423 (fn:empty and fn:exists iterators must reset their input in
 case of early-out)
   * More efficient implementation for base64Binary items

=== modified file 'src/runtime/parsing_and_serializing/parsing_and_serializing_impl.cpp'
--- src/runtime/parsing_and_serializing/parsing_and_serializing_impl.cpp	2012-02-02 09:56:52 +
+++ src/runtime/parsing_and_serializing/parsing_and_serializing_impl.cpp	2012-03-11 03:27:21 +
@@ -202,6 +202,11 @@
 if (lChildElem-isNode()  lChildElem-getNodeKind() == store::StoreConsts::elementNode)
 {
 #endif
+  if (lChildElem-getNodeKind() != store::StoreConsts::elementNode)
+  {
+continue;
+  }
+
   store::Item_t lChildName = lChildElem-getNodeName();
   if (lChildName-getLocalName() == use-character-maps)
   {

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-951772 into lp:zorba

2012-03-10 Thread Matthias Brantner 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-951772 into lp:zorba

2012-03-10 Thread Zorba Build Bot 
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/bug-951772-2012-03-11T03-35-11.001Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-951772 into lp:zorba

2012-03-10 Thread Zorba Build Bot 
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 1 Approve, 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-951772 into lp:zorba

2012-03-10 Thread Zorba Build Bot 
The proposal to merge lp:~zorba-coders/zorba/bug-951772 into lp:zorba has been 
updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-951772/+merge/96910
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp