Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job jsoniq-roundtrip-2012-09-21T05-41-03.33Z is finished. The final status was: 2 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T07-06-03.989Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue job jsoniq-roundtrip-2012-09-21T07-06-03.989Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Needs Fixing, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Review: Approve Approve the serialization changes. I skimmed the relevant tests as well. I didn't dive deeply into the implementation of the roundtrip functions. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Review: Needs Fixing
- JNTY0023 doesn't exist in the spec
- jn:decode-from-roundtrip should return item()*, e.g. it could also return
atomics
- Probably not related to this proposal but it's strange that the following
example doesn't raise a sequence-type matching error (in this branch)
jn:decode-from-roundtrip({ Q{http://jsoniq.org/roundtrip}type; :
xs:dateTime, Q{http://jsoniq.org/roundtrip}value; :
2012-09-21T09:44:14.753-07:00 }) instance of xs:dateTime
- jn:encode-for-roundtrip should accept item()*
- the exception raised in JSONEncodeForRoundtripIterator::encodeNode doesn't
have a query location. It could have one by directly raising an XQueryException
or catching and rethrowing it in nextImpl with the location added.
- ChangeLog entry missing
--
https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
- JNTY0023 doesn't exist in the spec
I've sent an e-mail to the list to add it to the spec.
- jn:decode-from-roundtrip should return item()*, e.g. it could also return
atomics
- Probably not related to this proposal but it's strange that the following
example doesn't raise a sequence-type matching error (in this branch)
jn:decode-from-roundtrip({ Q{http://jsoniq.org/roundtrip}type; :
xs:dateTime, Q{http://jsoniq.org/roundtrip}value; :
2012-09-21T09:44:14.753-07:00 }) instance of xs:dateTime
- jn:encode-for-roundtrip should accept item()*
Thinking more about this both functions should probably accept and return
item()* as simple atomic values 5 should just go through untouched.
I've changed the signature to item()* for now and sent an e-mail to the list
for clarification.
- the exception raised in JSONEncodeForRoundtripIterator::encodeNode doesn't
have a query location. It could have one by directly raising an
XQueryException or catching and rethrowing it in nextImpl with the location
added.
fixed
- ChangeLog entry missing
fixed
--
https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T18-48-12.23Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue job jsoniq-roundtrip-2012-09-21T18-48-12.23Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 2 Approve, 1 Needs Fixing. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T20-22-01.521Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T03-03-12.864Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The attempt to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job jsoniq-roundtrip-2012-09-21T03-03-12.864Z is finished. The final status was: 2 tests did not succeed - changes not commited. Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T04-13-03.065Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Review: Needs Fixing s/Cannot/can not/ Please don't use Uppercase as you would a normal sentence. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue job jsoniq-roundtrip-2012-09-21T04-13-03.065Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Needs Fixing, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
s/Cannot/can not/ Please don't use Uppercase as you would a normal sentence. fixed -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-roundtrip-2012-09-21T05-41-03.33Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba
BTW: Why are the enum types so monstrously long? In this particular case, Zorba_jsoniq_multiple_items_t can be replaced by a bool. Not sure. I agree that there are many ways in which this could be done differently. But I would like to keep the diff small so that it is easier to see what was changed. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
