[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-08-08 Thread Zorba Build Bot
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-08-08 Thread Zorba Build Bot
Validation queue result for 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312

Stage TestZorbaUbuntu failed.
115 tests failed (8402 total tests run).

Check test results at 
http://jenkins.lambda.nu/job/TestZorbaUbuntu/193/testReport/ to view the 
results.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-08-08 Thread Chris Hillery
Review: Needs Information

A great number of parsing and serializing test cases fail with these changes. 
Do we have any plans to fix them up? It's not clear to me if anyone is driving 
this issue anymore...
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-04-30 Thread Paul J. Lucas
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-04-30 Thread Paul J. Lucas
The proposal to merge lp:~zorba-coders/zorba/bug-1103819 into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-04-30 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/bug-1103819-2013-04-30T18-29-01.523Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-04-30 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug-1103819 into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job bug-1103819-2013-04-30T18-29-01.523Z is finished.  The
  final status was:

  

  117 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-04-30 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-1103819 into lp:zorba has been 
updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-02-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1103819 into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-02-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1103819 into lp:zorba has been 
updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-02-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1103819 into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-02-09 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/bug-1103819-2013-02-09T08-51-07.388Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-02-09 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug-1103819 into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job bug-1103819-2013-02-09T08-51-07.388Z is finished.  The
  final status was:

  

  31 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-02-09 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-1103819 into lp:zorba has been 
updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-02-09 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-1103819 into lp:zorba has been 
updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-02-09 Thread Zorba Build Bot
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/bug-1103819-2013-02-09T09-20-57.362Z/log.html
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-02-09 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug-1103819 into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job bug-1103819-2013-02-09T09-20-57.362Z is finished.  The
  final status was:

  

  6 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-02-09 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-1103819 into lp:zorba has been 
updated.

Status: Approved = Needs review

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1103819 into lp:zorba

2013-02-03 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~zorba-coders/zorba/bug-1103819 into 
lp:zorba.

Commit message:
Reworked some catch clauses.

Requested reviews:
  Paul J. Lucas (paul-lucas)
Related bugs:
  Bug #1103819 in Zorba: Use of catch (...) should be reduced or mitigated
  https://bugs.launchpad.net/zorba/+bug/1103819
  Bug #1106581 in Zorba: Use of throw 0 as flow-control
  https://bugs.launchpad.net/zorba/+bug/1106581
  Bug #1106586 in Zorba: Use of catch (...) swallows exceptions
  https://bugs.launchpad.net/zorba/+bug/1106586

For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312

Reworked some catch clauses.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1103819/+merge/146312
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/api/xqueryimpl.cpp'
--- src/api/xqueryimpl.cpp	2013-01-08 08:34:08 +
+++ src/api/xqueryimpl.cpp	2013-02-03 18:00:35 +
@@ -79,6 +79,7 @@
 namespace zorba
 {
 
+#define QUERY_TRY try
 
 #define QUERY_CATCH \
   catch (ZorbaException const e)   \
@@ -941,7 +942,7 @@
 {
   SYNC_CODE(AutoMutex lock(theMutex);)
 
-  try
+  QUERY_TRY
   {
 checkNotClosed();
 checkCompiled();
@@ -964,22 +965,7 @@
 
 return true;
   }
-  catch (ZorbaException const e)
-  {
-ZorbaImpl::notifyError(theDiagnosticHandler, e);
-  }
-  catch (FlowCtlException const)
-  {
-ZorbaImpl::notifyError(theDiagnosticHandler, User interrupt);
-  }
-  catch (std::exception const e)
-  {
-ZorbaImpl::notifyError(theDiagnosticHandler, e.what());
-  }
-  catch (...)
-  {
-ZorbaImpl::notifyError(theDiagnosticHandler);
-  }
+  QUERY_CATCH
 
   return false;
 }

=== modified file 'src/capi/cdynamic_context.cpp'
--- src/capi/cdynamic_context.cpp	2012-09-19 21:16:15 +
+++ src/capi/cdynamic_context.cpp	2013-02-03 18:00:35 +
@@ -271,10 +271,7 @@
   CDynamicContext::free(XQC_DynamicContext* context)
   {
 try {
-  CDynamicContext* me = CDynamicContext::get(context);
-  delete me;
-} catch (ZorbaException const) { 
-  assert(false);
+  delete CDynamicContext::get(context);
 } catch (...) { 
   assert(false);
 }

=== modified file 'src/capi/cexpression.cpp'
--- src/capi/cexpression.cpp	2012-09-19 21:16:15 +
+++ src/capi/cexpression.cpp	2013-02-03 18:00:35 +
@@ -227,10 +227,7 @@
   CExpression::free(XQC_Expression* expr)
   {
 try {
-  CExpression* me = CExpression::get(expr);
-  delete me;
-} catch (ZorbaException const) {
-  assert(false);
+  delete CExpression::get(expr);
 } catch (...) {
   assert(false);
 }

=== modified file 'src/capi/cimplementation.cpp'
--- src/capi/cimplementation.cpp	2012-09-19 21:16:15 +
+++ src/capi/cimplementation.cpp	2013-02-03 18:00:35 +
@@ -507,10 +507,7 @@
   CImplementation::free(XQC_Implementation* impl)
   {
 try {
-  CImplementation* me = CImplementation::get(impl);
-  delete me;
-} catch (ZorbaException const) {
-  assert(false);
+  delete CImplementation::get(impl);
 } catch (...) {
   assert(false);
 }

=== modified file 'src/capi/csequence.cpp'
--- src/capi/csequence.cpp	2012-09-19 21:16:15 +
+++ src/capi/csequence.cpp	2013-02-03 18:00:35 +
@@ -492,10 +492,7 @@
 CSequence::free(XQC_Sequence* seq)
 {
   try {
-CSequence* me = CSequence::get(seq);
-delete me;
-  } catch (ZorbaException const) {
-assert(false);
+delete CSequence::get(seq);
   } catch (...) {
 assert(false);
   }

=== modified file 'src/capi/cstatic_context.cpp'
--- src/capi/cstatic_context.cpp	2012-09-19 21:16:15 +
+++ src/capi/cstatic_context.cpp	2013-02-03 18:00:35 +
@@ -666,10 +666,7 @@
   CStaticContext::free(XQC_StaticContext* context)
   {
 try {
-  CStaticContext* me = CStaticContext::get(context);
-  delete me;
-} catch (ZorbaException const) { 
-  assert(false);
+  delete CStaticContext::get(context);
 } catch (...) { 
   assert(false);
 }

=== modified file 'src/context/default_url_resolvers.cpp'
--- src/context/default_url_resolvers.cpp	2013-01-24 12:11:43 +
+++ src/context/default_url_resolvers.cpp	2013-02-03 18:00:35 +
@@ -21,6 +21,7 @@
 #include util/uri_util.h
 #include util/http_util.h
 #include util/fs_util.h
+#include util/string_util.h
 #include store/api/store.h
 #include store/api/item_factory.h
 #include store/api/collection.h
@@ -93,6 +94,11 @@
 new StreamResource((lStream-getStream()), lStream-getStreamReleaser());
 lStream-setStreamReleaser(nullptr);
 return lResource;
+  } catch (std::exception const e) {
+std::string const msg(
+  BUILD_STRING( Could not create stream resource: , e.what() )
+);
+throw os_error::exception( , aUrl.c_str(), msg.c_str() );
   } catch (...) {
 throw os_error::exception(, aUrl.c_str(), Could not create stream resource);
   }

=== modified file