Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba
Review: Approve After a closer look the bugs are fixed and all the new testcase check for specific errors. Indeed the message can be misleading in the case of bug #912722 but not totaly incorect (depending on the implented algorithm) and the error code is correct. -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/87749 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba
Review: Approve Fixed conflict and merged latest from trunk. -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/99767 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/99767 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/99767 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba
I transferred the bugs to Cezar, thanks. They are blocking the merge of the PUL production/application. When those are fixed I think there will be another very small issue to cope with validation, which occur when I try to validate an element against a specific type definition. However, maybe a real fix to 912722 will solve this. All in all i do not consider them really urgent, because I am about to leave for a conference, and I will be basically unavailable to do real work for a week or so. Thus even if they are fixed in this timeframe the integration of the PUL branch will not occur sooner. Is a real fix to 912722 expensive to make? Cheers -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/87749 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba
I'm not sure, if I figure the right Xerces Error code for it should be easy but prom past this was quite tricky. Cezar On Tue, Jan 24, 2012 at 8:04 AM, Federico Cavalieri fcavalier...@gmail.comwrote: I transferred the bugs to Cezar, thanks. They are blocking the merge of the PUL production/application. When those are fixed I think there will be another very small issue to cope with validation, which occur when I try to validate an element against a specific type definition. However, maybe a real fix to 912722 will solve this. All in all i do not consider them really urgent, because I am about to leave for a conference, and I will be basically unavailable to do real work for a week or so. Thus even if they are fixed in this timeframe the integration of the PUL branch will not occur sooner. Is a real fix to 912722 expensive to make? Cheers -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/87749https://code.launchpad.net/%7Ezorba-coders/zorba/bugs-912586-912593-912722/+merge/87749 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/87749 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba
Markos is correct, if a/ element is inside root element than, root has a complex type and is not a simple type which anysimpleType represents. This should make the validation failing in the example from bug #912722 even if lax is specified. So this doesn't fix the bug #912722, at least the comment Fixed bug #912586, #912593 and #912722 (assertion failures with lax validation) should be changed. Cezar, will you then take care of these bugs and provide the correct fixes? Federico is only a volunteer at this time, and he shouldn't be spending too much time on this. Federico, will you transfer these bugs to Cezar? What is their priority? Are they blocking the PUL-related work? -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/87749 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba
Federico, I am approving this, but my knowledge of XML Schema and Zorba's implementation of it is not good enough to do a real review. So, I am also adding Cezar as a reviewer. For example, after your fix, the query in bug #912722 complains that no declaration found for element 'a'. But, I think, the real problem is that a should not be there at all given that the type of the root element is xs:int. But then again, I could be wrong. That's why I am sking Cezar to review this, -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/87749 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/87749 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bugs-912586-912593-912722 into lp:zorba
Review: Needs Fixing Markos is correct, if a/ element is inside root element than, root has a complex type and is not a simple type which anysimpleType represents. This should make the validation failing in the example from bug #912722 even if lax is specified. So this doesn't fix the bug #912722, at least the comment Fixed bug #912586, #912593 and #912722 (assertion failures with lax validation) should be changed. -- https://code.launchpad.net/~zorba-coders/zorba/bugs-912586-912593-912722/+merge/87749 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp