Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-948879 into lp:zorba

2012-04-13 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-948879/+merge/101874 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-948879 into lp:zorba

2012-04-13 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-948879/+merge/101874 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-948879 into lp:zorba

2012-04-13 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-948879/+merge/101874 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-948879 into lp:zorba

2012-04-12 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-948879/+merge/101708 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-948879 into lp:zorba

2012-04-12 Thread Chris Hillery
Review: Needs Fixing To maintain ABI compatibility, new virtual functions in the public API need to be added at the end of the class definition. At least, that is what I've been led to believe. Not sure if we're caring about ABI compat yet, but we might as well get into the habit. --