The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
Review: Disapprove
There are several problems:
1. The new string pool is not thread-safe (the current one is)
2. The check made in ~StringPool() must be implemented in the new pool as well
3. Most of the time, the strings that are inserted in the pool are "char *"
strings (for example, during
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 1 Approve, 1 Needs Fixing, 3 Pending.
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.
-
Validation queue job feature-unordered_map-2012-08-08T05-22-02.016Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://laun
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-08-08T05-22-02.016Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.
-
Review: Needs Fixing
The old string pool should be removed if it's not used anymore (instead of
ifdefing it out).
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 1 Pending.
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://la
Validation queue job feature-unordered_map-2012-07-31T17-35-59.766Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://laun
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-07-31T17-35-59.766Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Your team Zorba Coders is subscribed to branch lp:zorba.
-
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/feature-unordered_map
into lp:zorba.
Requested reviews:
Paul J. Lucas (paul-lucas)
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/117498
Added pool class and replaced StringPool.
--
http
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unorder
Validation queue job feature-unordered_map-2012-07-13T00-16-08.126Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://laun
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-07-13T00-16-08.126Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
Your team Zorba Coders is subscribed to branch lp:zorba.
-
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/feature-unordered_map
into lp:zorba.
Requested reviews:
Paul J. Lucas (paul-lucas)
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114328
Fixed typo.
--
https://code.launchpad.net/~paul-l
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unorder
Validation queue job feature-unordered_map-2012-07-09T23-13-58.367Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://laun
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-07-09T23-13-58.367Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.
-
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
The attempt to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job feature-unordered_map-2012-07-09T22-27-55.487Z is
fin
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-07-09T22-27-55.487Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.
-
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
The attempt to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job feature-unordered_map-2012-07-09T17-45-03.094Z is
fin
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-07-09T17-45-03.094Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.
-
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/feature-unordered_map
into lp:zorba.
Requested reviews:
Paul J. Lucas (paul-lucas)
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/114013
Fixed warnings.
--
https://code.launchpad.net/~pa
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unorder
Validation queue job feature-unordered_map-2012-06-29T03-29-54.186Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://laun
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-06-29T03-29-54.186Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.
-
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 1 Approve, 1 Pending.
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job feature-unordered_map-2012-06-29T02-17-56.706Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://laun
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-06-29T02-17-56.706Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.
-
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/feature-unordered_map
into lp:zorba.
Requested reviews:
Paul J. Lucas (paul-lucas)
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/112679
Added the missing specialization for hash>.
--
ht
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unorder
Validation queue job feature-unordered_map-2012-06-28T23-43-07.109Z is
finished. The final status was:
All tests succeeded!
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://laun
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-unordered_map-2012-06-28T23-43-07.109Z/log.html
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
Your team Zorba Coders is subscribed to branch lp:zorba.
-
The proposal to merge lp:~paul-lucas/zorba/feature-unordered_map into lp:zorba
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
--
https://code.launchpad.net/~paul-lucas/zorba/feature-u
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
Review: Approve
--
https://code.launchpad.net/~paul-lucas/zorba/feature-unordered_map/+merge/110657
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~
55 matches
Mail list logo
