Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba

2013-04-12 Thread Ghislain Fourny
It looks good! - Could we add a test that checks that $object.$$ parses? - Why was type promotion changed to a treat-as in FO normalization? Is it for performance? The only promotion I can think to happen is a URI being promoted to a string in an object lookup. We have not discussed this yet I

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba

2013-04-12 Thread Matthias Brantner
It looks good! - Could we add a test that checks that $object.$$ parses? done - Why was type promotion changed to a treat-as in FO normalization? Is it for performance? The only promotion I can think to happen is a URI being promoted to a string in an object lookup. We have not discussed

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba

2013-04-12 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-objnav_contextitem/+merge/158448 -- https://code.launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba

2013-04-12 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-objnav_contextitem-2013-04-12T20-25-43.731Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/feature-objnav_contextitem/+merge/158448 Your team Zorba Coders is subscribed to branch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba

2013-04-12 Thread Zorba Build Bot
Validation queue job feature-objnav_contextitem-2013-04-12T20-25-43.731Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/feature-objnav_contextitem/+merge/158448 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba

2013-04-12 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/feature-objnav_contextitem/+merge/158448 Your team Zorba Coders is

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba

2013-04-12 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-objnav_contextitem/+merge/158448 -- https://code.launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba

2013-04-11 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-objnav_contextitem/+merge/158448 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba

2013-04-11 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-objnav_contextitem/+merge/158448 -- https://code.launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba

2013-04-11 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-objnav_contextitem-2013-04-11T18-15-52.126Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/feature-objnav_contextitem/+merge/158448 Your team Zorba Coders is subscribed to branch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba

2013-04-11 Thread Zorba Build Bot
Validation queue job feature-objnav_contextitem-2013-04-11T18-15-52.126Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/feature-objnav_contextitem/+merge/158448 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba

2013-04-11 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1, Needs Information 1, Resubmit 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/feature-objnav_contextitem/+merge/158448 Your team Zorba Coders is

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba

2013-04-11 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/feature-objnav_contextitem into lp:zorba has been updated. Status: Approved = Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-objnav_contextitem/+merge/158448 -- https://code.launchpad.net/~zorba-coders