Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/sqlite-check-for-metadata-availability/+merge/145041
Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
The proposal to merge
lp:~zorba-coders/zorba/sqlite-check-for-metadata-availability into
lp:zorba/sqlite-module has been updated.
Commit Message changed to:
- New feature detection code added to CMake to be sure that SQLite is able to
read metadata (fix for Mac OSX)
For more details, see
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/sqlite-check-for-metadata-availability-2013-04-30T18-03-45.308Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/sqlite-check-for-metadata-availability/+merge/145041
Your team Zorba Coders
Validation queue job
sqlite-check-for-metadata-availability-2013-04-30T18-03-45.308Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/sqlite-check-for-metadata-availability/+merge/145041
Your team Zorba Coders is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/sqlite-check-for-metadata-availability/+merge/145041
Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
The proposal to merge
lp:~zorba-coders/zorba/sqlite-check-for-metadata-availability into
lp:zorba/sqlite-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/sqlite-check-for-metadata-availability/+merge/145041
I think this branch is corrected as Chris suggested. Please re-review.
--
https://code.launchpad.net/~zorba-coders/zorba/sqlite-check-for-metadata-availability/+merge/145041
Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module.
--
Mailing list:
Luis Rodriguez Gonzalez has proposed merging
lp:~zorba-coders/zorba/sqlite-check-for-metadata-availability into
lp:zorba/sqlite-module.
Requested reviews:
Chris Hillery (ceejatec)
Related bugs:
Bug #1102549 in Zorba: SQLite module doesn't link on MacOS
Review: Needs Fixing
Unless I'm missing something, it'd be cleaner to avoid the compilation of
JSONMetadataItemSequence entirely by #ifdef-ing out the class and method
definitions in the .cpp and .h files.
--
9 matches
Mail list logo