Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module
Review: Approve Yes, we cannot JSONify the EXPath module. More than that, this processing depends on XML data formats for which it doesn't make sense to do it on JSON because the input data is XML and people want to process that. A JSONiq geo module would be a completely separate effort. Right now, we should just do the basics and that's it. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214 Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module
Validation queue starting for the following merge proposals: https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214 Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module
Validation queue succeeded - proposal merged! -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214 Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module
The proposal to merge lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214 -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214 Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module
Review: Needs Information The changes as made seem fine. Two concerns: 1. Are there any errors raised by the module functions? If so, are they documented? 2. Matthias: This seems like it is an ideal candidate for JSONify-ing; would you agree? If so, what would you think is the priority? I'm tempted to merge this revision as it stands, and file a separate lower-priority bug to JSONify this module later if we have time. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214 Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module
The changes as made seem fine. Two concerns: 1. Are there any errors raised by the module functions? If so, are they documented? No errors are thrown by the module. 2. Matthias: This seems like it is an ideal candidate for JSONify-ing; would you agree? If so, what would you think is the priority? I'm tempted to merge this revision as it stands, and file a separate lower-priority bug to JSONify this module later if we have time. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214 Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module
Review: Approve Approving the changes as they are. Matthias, let us know if you think it should JSONified immediately or if we can come back to it. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214 Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module
One note: we cannot JSONify the geo module [can we?], since it is an EXPath module. There are no common APIs or schemas between geo and geoproj so far as I know, but they might be used by similar people. So, might it be weird if one is XML and one is JSON? Not really sure how to make that call. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214 Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module
Juan Zacarias has proposed merging lp:~zorba-coders/zorba/update3.0_geoproj-module into lp:zorba/geoproj-module. Commit message: Changes for Update 3.0 Requested reviews: Chris Hillery (ceejatec) Related bugs: Bug #1188046 in Zorba: Update non-core module geoproj https://bugs.launchpad.net/zorba/+bug/1188046 For more details, see: https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214 Changes for Update 3.0 -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_geoproj-module/+merge/170214 Your team Zorba Coders is subscribed to branch lp:zorba/geoproj-module. === modified file 'src/CMakeLists.txt' --- src/CMakeLists.txt 2012-08-07 19:49:24 + +++ src/CMakeLists.txt 2013-06-18 22:44:26 + @@ -11,10 +11,6 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. - -# all external module libraries are generated in the directory -# of the corresponding .xq file -MESSAGE(STATUS Add com) -ADD_SUBDIRECTORY(com) - -MESSAGE(STATUS End modules) +DECLARE_ZORBA_SCHEMA (FILE geoproj-param.xsd + URI http://zorba.io/modules/geoproj-param;) +DECLARE_ZORBA_MODULE (URI http://zorba.io/modules/geoproj; VERSION 1.0 FILE geoproj.xq) === removed file 'src/com/CMakeLists.txt' --- src/com/CMakeLists.txt 2011-10-06 08:18:23 + +++ src/com/CMakeLists.txt 1970-01-01 00:00:00 + @@ -1,14 +0,0 @@ -# Copyright 2006-2008 The FLWOR Foundation. -# -# Licensed under the Apache License, Version 2.0 (the License); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an AS IS BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -ADD_SUBDIRECTORY(zorba-xquery) === removed file 'src/com/zorba-xquery/CMakeLists.txt' --- src/com/zorba-xquery/CMakeLists.txt 2011-10-06 08:18:23 + +++ src/com/zorba-xquery/CMakeLists.txt 1970-01-01 00:00:00 + @@ -1,14 +0,0 @@ -# Copyright 2006-2008 The FLWOR Foundation. -# -# Licensed under the Apache License, Version 2.0 (the License); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an AS IS BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -ADD_SUBDIRECTORY(www) === removed file 'src/com/zorba-xquery/www/CMakeLists.txt' --- src/com/zorba-xquery/www/CMakeLists.txt 2011-10-06 08:18:23 + +++ src/com/zorba-xquery/www/CMakeLists.txt 1970-01-01 00:00:00 + @@ -1,14 +0,0 @@ -# Copyright 2006-2008 The FLWOR Foundation. -# -# Licensed under the Apache License, Version 2.0 (the License); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an AS IS BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -ADD_SUBDIRECTORY(modules) === removed file 'src/com/zorba-xquery/www/modules/CMakeLists.txt' --- src/com/zorba-xquery/www/modules/CMakeLists.txt 2011-07-27 00:24:29 + +++ src/com/zorba-xquery/www/modules/CMakeLists.txt 1970-01-01 00:00:00 + @@ -1,16 +0,0 @@ -# Copyright 2006-2008 The FLWOR Foundation. -# -# Licensed under the Apache License, Version 2.0 (the License); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an AS IS BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. -DECLARE_ZORBA_SCHEMA (FILE geoproj-param.xsd - URI http://www.zorba-xquery.com/modules/geoproj-param;) -DECLARE_ZORBA_MODULE (URI http://www.zorba-xquery.com/modules/geoproj; VERSION 1.0 FILE geoproj.xq) === removed file 'src/com/zorba-xquery/www/modules/geoproj-param.xsd' --- src/com/zorba-xquery/www/modules/geoproj-param.xsd 2011-08-05 02:22:02 + +++
