Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
The proposal to merge lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
Validation queue starting for the following merge proposals: https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
Validation queue result for https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Stage TestZorbaUbuntu failed. 13 tests failed (8416 total tests run). Check test results at http://jenkins.lambda.nu/job/TestZorbaUbuntu/127/testReport/ to view the results. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
Validation queue starting for the following merge proposals: https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
[Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
Validation queue succeeded - proposal merged! -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
FYI, I moved the string module into the new modules/atomic directory. Also fixed the version number in DECLARE_ZORBA_MODULE(). -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
Added the implementation of the is-seekable function in the string module. Also removed the materialize from the test since it was doing nothing, since it returns a seekable stream by the file function read-text. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
All the changes were addressed except for -I know that it's unrelated to the change but the example using file:read-text in the materialize function doesn't make sense anymore. Because read-text returns a seekable string it can be consumed more than once. The http-client would be the right example. Also, a is-seekable function would be great to have. Should I do this change? -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
Discussed with Juan - the is-seekable() function should be easy enough to add, so sure, let's do it. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
Per conf call today: yes, convert this to pure JSONiq. That means, at least, having the jsoniq version declaration in the module, and eliminating the xs: prefix from all signatures. Not sure if anything else needs to be (or can be) done. For the time being the file extension should remain .xq. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
Review: Needs Fixing need merge with the trunk to get the static_context.cpp changes that Paul just submitted. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/update3.0_string-module into lp:zorba
- Shouldn't the module be in version 1.0? - I forgot what the final decision was but I thought that modules should be pure JSONiq if possible. This would be a perfect candidate in which case all the types should be changed (i.e. xs prefix removed). - Can we make the link to the module in options.dox refer to zorba.io? - I know that it's unrelated to the change but the example using file:read-text in the materialize function doesn't make sense anymore. Because read-text returns a seekable string it can be consumed more than once. The http-client would be the right example. Also, a is-seekable function would be great to have. -- https://code.launchpad.net/~zorba-coders/zorba/update3.0_string-module/+merge/171376 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
