[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-15 Thread noreply 
The proposal to merge lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba 
has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
-- 
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-15 Thread Zorba Build Bot 
Validation queue job fn_trace_jsoniq_fix-2012-08-15T15-41-05.154Z is finished. 
The final status was:

All tests succeeded!
-- 
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-15 Thread Zorba Build Bot 
Validation queue starting for merge proposal.
Log at: 
http://zorbatest.lambda.nu:8080/remotequeue/fn_trace_jsoniq_fix-2012-08-15T15-41-05.154Z/log.html
-- 
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-15 Thread Till Westmann 
The proposal to merge lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba 
has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
-- 
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-15 Thread Till Westmann 
Review: Approve

Of course! I'm sorry about the confusion.
-- 
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-15 Thread David Graf 
This query doesn't work because the serializer of the query result throws an 
error. The result of a query must not be an attribute. fn:trace does work on my 
side:

./bin/zorba -q 'trace(attribute { "a" } { 1 }, "a")'
a [1]:  a="1"  <== fn:trace print

serialization error [err:SENR0001]: "1": can not serialize attribute node; 
raised at /home/dagraf/zorba/sandbox/src/api/serialization/serializer.cpp:456

You need to execute something like: ./bin/zorba -q 'data(trace(attribute { "a" 
} { 1 }, "a"))'
... to not see an error.
-- 
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-14 Thread Till Westmann 
Review: Needs Fixing

I'm trying to run:

zorba -q 'trace(attribute { "a" } { 1 }, "a")'

and that still results in a 

serialization error [err:SENR0001]: "1": can not serialize attribute node

Does this work for you?
-- 
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-14 Thread David Graf 
Review: Approve


-- 
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-14 Thread David Graf 
The proposal to merge lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba 
has been updated.

Commit Message changed to:

Because the jsoniq_emitter aggregates the xml_emitter, it needs to handover all 
the parameters. Inclusive aEmitAttributes.

For more details, see:
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
-- 
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-14 Thread David Graf 
David Graf has proposed merging lp:~davidagraf/zorba/fn_trace_jsoniq_fix into 
lp:zorba.

Requested reviews:
  David Graf (davidagraf)
  Till Westmann (tillw)

For more details, see:
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478

Because the jsoniq_emitter aggregates the xml_emitter, it needs to handover all 
the parameters. Inclusive aEmitAttributes.
-- 
https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478
Your team Zorba Coders is subscribed to branch lp:zorba.
=== modified file 'src/api/serialization/serializer.cpp'
--- src/api/serialization/serializer.cpp	2012-07-25 23:20:47 +
+++ src/api/serialization/serializer.cpp	2012-08-14 07:19:22 +
@@ -1220,11 +1220,12 @@
 
 serializer::jsoniq_emitter::jsoniq_emitter(
   serializer* the_serializer,
-  std::ostream& the_stream)
+  std::ostream& the_stream,
+  bool aEmitAttributes)
   :
 emitter(the_serializer, the_stream),
 theEmitterState(JESTATE_UNDETERMINED),
-theXMLEmitter(new xml_emitter(the_serializer, the_stream)),
+theXMLEmitter(new xml_emitter(the_serializer, the_stream, aEmitAttributes)),
 theJSONEmitter(new json_emitter(the_serializer, the_stream))
 {
 }
@@ -2668,7 +2669,7 @@
   else if (method == PARAMETER_VALUE_JSON)
 e = new json_emitter(this, *tr);
   else if (method == PARAMETER_VALUE_JSONIQ)
-e = new jsoniq_emitter(this, *tr);
+e = new jsoniq_emitter(this, *tr, aEmitAttributes);
 #endif
   else
   {

=== modified file 'src/api/serialization/serializer.h'
--- src/api/serialization/serializer.h	2012-07-25 00:15:29 +
+++ src/api/serialization/serializer.h	2012-08-14 07:19:22 +
@@ -423,7 +423,10 @@
   class jsoniq_emitter : public emitter
   {
   public:
-jsoniq_emitter(serializer* the_serializer, std::ostream& the_stream);
+jsoniq_emitter(
+serializer* the_serializer, 
+std::ostream& the_stream,
+bool aEmitAttributes = false);
 
 virtual ~jsoniq_emitter();
 

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp