Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug-1210677-autoptr into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
--
https://code.launchpad.net/~zorba-coders/zorba/bug
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-util-jvm/+merge/185899
Well, crap. Didn't see that with all the other changes. Now what...
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Needs Fixing
This MP is touching .csv files.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
The proposal to merge lp:~zorba-coders/zorba/bug-1210677-autoptr into lp:zorba
has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Stage CommitZorba failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/181/console to
view the results.
--
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-util-jvm/+merge/185899
:
Votes: {'Approve': 1}
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-archive/+merge/185901
:
Votes: {'Approve': 1}
Review: Needs Fixing
There don't seem to be enough #include zorba/internal/unique_ptr.h in the
.cpp files, e.g., src/util/singleton.h.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-util-jvm/+merge/185899
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
The proposal to merge lp:~zorba-coders/zorba/bug-1210677-autoptr into lp:zorba
has been updated.
Description changed to:
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677
The proposal to merge lp:~zorba-coders/zorba/bug-1210677-autoptr into lp:zorba
has been updated.
Description changed to:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-util-jvm/+merge/185899
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-archive/+merge/185901
https
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Stage BuildZorbaUbuntu failed.
Check compiler output at
http://jenkins.lambda.nu/job/BuildZorbaUbuntu/347/parsed_console to view the
results.
--
Changes made as suggested.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Stage ZorbaVQ failed.
Check console output at http://jenkins.lambda.nu/job/ZorbaVQ/357/console to
view the results.
--
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Stage BuildZorbaUbuntu failed.
Check compiler output at
http://jenkins.lambda.nu/job/BuildZorbaUbuntu/318/parsed_console to view the
results.
--
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-geo/+merge/184927 :
Votes: {'Approve': 1}
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-html/+merge/184930 :
Votes: {'Approve': 1}
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-geo/+merge/184927
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-html/+merge/184930
The proposal to merge lp:~zorba-coders/zorba/bug-1210677-autoptr into lp:zorba
has been updated.
Description changed to:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-geo/+merge/184927
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-html/+merge/184930
https
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Stage CommitZorba failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/164/console to
view the results.
--
Review: Approve
Approving, but you might want to fix the following:
* s/an unique_ptr/a unique_ptr/
* There are places where a unique_ptr variable is explicitly initialized with
NULL. This is unnecessary.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your
The proposal to merge lp:~zorba-coders/zorba/bug-1210677-autoptr into lp:zorba
has been updated.
Commit Message changed to:
Replace all instances of auto_ptr with unique_ptr. Add std::move() where
necessary. Remove #include memory where no longer necessary. Removed
auto_vector.
For more
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/bug-1210677-autoptr/+merge/180455
Stage ZorbaVQ failed.
Check console output at http://jenkins.lambda.nu/job/ZorbaVQ/293/console to
view the results.
--
29 matches
Mail list logo
