Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-867376-2013-05-03T15-12-05.295Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug-867376-2013-05-03T15-12-05.295Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been
updated.
Commit Message changed to:
Added URI processing module.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
--
https://code.launchpad.net/~zorba-coders/zorba/bug
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been
updated.
Description changed to:
- Fix for Bug 867376 URI processing module
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
--
https://code.launchpad.net/~zorba-coders
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-867376-2013-05-02T09-13-03.471Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug-867376-2013-05-02T09-13-03.471Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Review: Needs Fixing
- Could you give an example in the documentation of uri:parse and show a
resulting URI object?
- The names of the variables are all upper-case. I know that we don't have any
coding conventions for it but the names in the full-text module are all
lower-case. Should we be
- Could you give an example in the documentation of uri:parse and show a
resulting URI object?
Done
- The names of the variables are all upper-case. I know that we don't have any
coding conventions for it but the names in the full-text module are all lower-
case. Should we be consistent here?
I believe all outstanding comments have been addressed; Matthias, one more
pass, please?
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
I have pushed some final documentation improvements.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The attempt to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275
(message):
Validation queue job bug-867376-2013-05-03T03-13-20.382Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
One of the FOTS tests crashes
We already pushed a fix for that one before asking for your re-review (it was
an infinite loop eventually causing OOM).
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
I will include the 3 different errors for uri:serialize(), Should I leave
uri:parse() without any error code?
I'm sure there are some reasonable errors for uri:parse(), but I'm not totally
sure what they might be. It's possible that URI.cpp will already throw some
exceptions if you try to
There are still some test failures. serialize-direct-uris now throws ZURI
errors, which is good, but the test needs to be adapted for that (split the
failing cases into separate tests with a .spec file containing the Error: you
expect).
More worrying, FOTS/fn-resolve-uri is failing. I'm
Review: Needs Fixing
There are still some test failures. serialize-direct-uris now throws ZURI
errors, which is good, but the test needs to be adapted for that (split the
failing cases into separate tests with a .spec file containing the Error: you
expect).
More worrying, FOTS/fn-resolve-uri
I will include the 3 different errors for uri:serialize(), Should I leave
uri:parse() without any error code?
I'm sure there are some reasonable errors for uri:parse(), but I'm not totally
sure what they might be. It's possible that URI.cpp will already throw some
exceptions if you try to
Hmmm weird. Yep, those results are there after all. I'm not sure where they
went when I looked at this the first time. Ok then.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
As for the error condition, I've been thinking about it more, and I'm pretty
sure that uri:serialize() needs to enforce at least the following rules:
1. You can specify opaque-part, OR some subset of
host/port/path/user-info/query. Not both. (Put another way: If opaque-part is
specified, then
Also - the header comment for uri.xq is wrong:
(:~
: This module provides string related functions.
:
: @author Matthias Brantner
: @project XDM/atomic
:
:)
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Your team Zorba Coders is subscribed to branch lp:zorba.
As for the error condition, I've been thinking about it more, and I'm pretty
sure that uri:serialize() needs to enforce at least the following rules:
1. You can specify opaque-part, OR some subset of host/port/path/user-
info/query. Not both. (Put another way: If opaque-part is specified,
Review: Needs Fixing
- Why is there a schema imported in uri.xq? I don't think it's needed anymore.
- The documentation should say what types of errors the function can raise.
- It would be nice to have constants for the names of the fields in the objects
(e.g. scheme, opaque-part)
- Why does
Also, currently serialize-direct-uri.xq fails because the expected output file
serialize-direct-uri.xml.res is missing a couple results, namely the opaque URI
tests at the end. Did you forget to commit that file?
--
https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233
Your
Review: Needs Fixing
I think actually there are some error conditions that we're not catching
currently. For instance, the following input in serialize-direct-uri.xq:
{ scheme : file, path : d:/a/b/c }
is a non-opaque URI because it has a path, rather than an opaque-part. But it
produces the
26 matches
Mail list logo
