Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-27 Thread Paul J. Lucas
Uhm I don't think it was ever the intention to move *all* unit tests from test/unit to src/unit_tests. Tests that test things that are *supposed* to be in the public API (as opposed to things declared ZORBA_DLL_PUBLIC just so they'd link) should *stay* in test/unit, e.g., stemmer.cpp, token

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-27 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/bug-896426 into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your tea

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-27 Thread Zorba Build Bot
Validation queue job bug-896426-2012-01-27T07-38-56.145Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-code

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-26 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-896426-2012-01-27T07-38-56.145Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: http

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-26 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-896426 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Yo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-26 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-code

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-code

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Zorba Build Bot
Validation queue job bug-896426-2012-01-19T10-12-03.231Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-code

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-896426 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Yo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. Got: 1 Needs Information, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-c

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-896426-2012-01-19T10-12-03.231Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: http

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-896426 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Yo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Chris Hillery
I killed the validation queue job above. It was doomed to fail because of a mistaken merge to the trunk. I am correcting the trunk and will re-start the validation queue for this proposal when it is fixed. -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your team Zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-896426 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Yo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug-896426 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job bug-896426-2012-01-19T09-25-58.981Z is finished. The final st

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-896426-2012-01-19T09-25-58.981Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: http

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-896426 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Yo

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-896426 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Yo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in src/unit_tests/CMakeLists.txt -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Chris Hillery
No reason not to incorporate these changes, though; I'm starting the remote queue for them (probably the branch will need to be updated from the trunk). -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-19 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-896426 into lp:zorba has been updated. Commit Message changed to: Migrated several unit tests to libunittest. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 -- https://code.launchpad.net/~zorba-code

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-18 Thread Paul J. Lucas
It's not critical. I was hoping that Chris would have migrated more unit tests. -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@li

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2012-01-18 Thread Matthias Brantner
Review: Needs Information Should we merge these changes? -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubsc

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2011-11-29 Thread Paul J. Lucas
The proposal to merge lp:~zorba-coders/zorba/bug-896426 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 -- https://code.launchpad.net/~zorba-coders/zorba/bug-896426/+merge/83885 Yo

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-896426 into lp:zorba

2011-11-29 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~zorba-coders/zorba/bug-896426 into lp:zorba. Requested reviews: Paul J. Lucas (paul-lucas) Related bugs: Bug #896426 in Zorba: "Unit test migration" https://bugs.launchpad.net/zorba/+bug/896426 For more details, see: https://code.launchpad.net/~zorba-