I've added this improvement in commit 10674.
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/95147
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/95147
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
I approve the fix but the indentation still deserves some improvements (i.e. a
space after the if if().
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/95147
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/95147
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Commit Message changed to:
Optimize iterator generation for the concat operator (fixes bug #942011)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/95147
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/95147
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/concat_operator-2012-02-29T16-12-18.077Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/95147
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Validation queue job concat_operator-2012-02-29T16-12-18.077Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/95147
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/95147
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge
A small code improvement: rather thah doing a dynamic_cast to check if an expr
is an fo_expr, use the get_expr_kind() method. So, the code would look like
this:
if (right-get_expr_kind() == fo_expr_kind)
{
fo_expr* lfoExpr = static_castfo_expr*(right.getp());
etc;
}
Also, please
William Candillon has proposed merging lp:~zorba-coders/zorba/concat_operator
into lp:zorba.
Requested reviews:
Markos Zaharioudakis (markos-za)
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #937120 in Zorba: Improve error message for ||
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94869
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator
There are additional revisions which have not been approved in review. Please
seek review and approval of these new revisions.
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94869
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94869
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Commit Message changed to:
Add the XQuery 3.0 concat operator
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94009
--
https://code.launchpad.net/~zorba
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94009
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/concat_operator-2012-02-21T17-12-08.91Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94009
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Review: Needs Fixing
- I talked to Paul about the error message. He said it should be:
multi-item sequence can not be operand for concatenation
- NoSeqForFnOp_3: the _3 usually indicates that this error message has 3
parameters which is wrong in this case
--
Validation queue job concat_operator-2012-02-21T17-12-08.91Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94009
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1.
Got: 1 Approve, 1 Needs Fixing, 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94009
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94009
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94036
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94036
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Commit Message changed to:
XQuery 3.0 concat operator
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94036
--
https://code.launchpad.net/~zorba-coders
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94036
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator
Validation queue job concat_operator-2012-02-21T18-54-11.262Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94036
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/94036
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge
Review: Needs Information
Looks pretty good. One question: shouldn't the StringConcatExpr not be added to
the %destructor directive in xquery_parser.y?
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/93773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Commit Message changed to:
Add the XQuery 3.0 concat operator (||)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/93773
--
https://code.launchpad.net
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/93773
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/concat_operator-2012-02-20T16-10-08.516Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/93773
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
The attempt to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job concat_operator-2012-02-20T16-10-08.516Z is finished
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/93773
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/93879
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/concat_operator-2012-02-20T17-36-08.312Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/93879
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Validation queue job concat_operator-2012-02-20T17-36-08.312Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/93879
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1.
Got: 1 Approve, 3 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/93879
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
The proposal to merge lp:~zorba-coders/zorba/concat_operator into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/concat_operator/+merge/93879
--
https://code.launchpad.net/~zorba-coders/zorba/concat_operator
38 matches
Mail list logo
