Review: Approve
I reviewed CMakeConfiguration.txt, bin/CMakeLists.txt,
bin/debugger/config.h.cmake.
Looks good to me. I was only thinking if it would be a good idea to remove the
option ZORBA_WITH_DEBUGGER_CLIENT (generating the debugger client if debugging
is switched on). The less options
The proposal to merge lp:~zorba-coders/zorba/debugger_client into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge/86305
--
https://code.launchpad.net/~zorba-coders/zorba/debugger_client
The proposal to merge lp:~zorba-coders/zorba/debugger_client into lp:zorba has
been updated.
Commit Message changed to:
Mature zorba debugger with graceful degradation if libedit not found.
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge/86305
The attempt to merge lp:~zorba-coders/zorba/debugger_client into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:272
(message):
Validation queue job debugger_client-2011-12-20T16-40-29.862Z is finished
The proposal to merge lp:~zorba-coders/zorba/debugger_client into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge/86305
--
https://code.launchpad.net/~zorba-coders/zorba/debugger_client
The proposal to merge lp:~zorba-coders/zorba/debugger_client into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge/86305
--
https://code.launchpad.net/~zorba-coders/zorba/debugger_client
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/debugger_client-2011-12-20T17-21-18.291Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge/86305
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
The attempt to merge lp:~zorba-coders/zorba/debugger_client into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:272
(message):
Validation queue job debugger_client-2011-12-20T17-21-18.291Z is finished
The proposal to merge lp:~zorba-coders/zorba/debugger_client into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge/86305
--
https://code.launchpad.net/~zorba-coders/zorba/debugger_client
The proposal to merge lp:~zorba-coders/zorba/debugger_client into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge/86305
--
https://code.launchpad.net/~zorba-coders/zorba/debugger_client
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/debugger_client-2011-12-20T18-12-16.752Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge/86305
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Validation queue job debugger_client-2011-12-20T18-12-16.752Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge/86305
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/debugger_client into lp:zorba has
been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge/86305
--
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge/86305
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/debugger_client/+merge/85567
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
15 matches
Mail list logo