Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Hi Cezar,
In general, an object constructor expression is not always valid JSON, as it is
more general. For example, { 1 : 1 } is valid JSONiq although it is not valid
JSON. A key expression, can be anything, and will be atomized and cast to
xs:string.
Also, { null : 1 } (which is what is
I understand, it make sense in this way but it's very dangerous, in this
way I don't think it helps the users on contrary can leave bad code falsely
working.
Cezar
On Thu, Sep 13, 2012 at 6:38 AM, Ghislain Fourny ghislain.fou...@28msec.com
wrote:
Hi Cezar,
In general, an object constructor
The proposal to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/fix-1046415-2012-09-13T14-49-49.139Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job fix-1046415-2012-09-13T14-49-49.139Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge
The proposal to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/fix-1046415-2012-09-13T15-19-50.542Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job fix-1046415-2012-09-13T15-19-50.542Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 2 Approve, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/fix-1046415-2012-09-13T20-14-47.795Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job fix-1046415-2012-09-13T20-14-47.795Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge
The proposal to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/fix-1046415-2012-09-13T20-54-55.036Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The attempt to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba failed.
Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job fix-1046415-2012-09-13T20-54-55.036Z is finished. The
final
The proposal to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge
The proposal to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/fix-1046415-2012-09-14T04-04-53.838Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job fix-1046415-2012-09-14T04-04-53.838Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Hi Matthias,
- I think the empty string is a valid JSON name.
- The current semantics of { null : 1 }(null) in the spec is indeed to return
1. I think I am fine with this.
- I uploaded more tests (somehow they did not get uploaded yesterday).
--
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Information
- Is the empty string a valid name? Should we raise an error if the name of a
pair is an empty string? Currently, the following query works fine: { :
1}()
- What should happen if the key expression evaluates to null. Currently, the
following query returns 1; { null :
As far as I can make out, an empty string is a valid key for an object.
jsonlint.com at least agrees.
null is not a valid key, and we should raise an error if such a case arises.
Also, the fact that using the *string* null as an accessor worked in that
case frightens me.
--
As far as I can make out, an empty string is a valid key for an object.
jsonlint.com at least agrees.
Fair enough.
null is not a valid key, and we should raise an error if such a case arises.
Also, the fact that using the *string* null as an accessor worked in that
case frightens me.
Ghislain Fourny has proposed merging lp:~zorba-coders/zorba/fix-1046415 into
lp:zorba.
Requested reviews:
Chris Hillery (ceejatec)
Matthias Brantner (matthias-brantner)
Related bugs:
Bug #1046415 in Zorba: jsoniq: pair name needs to cast to string
The proposal to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge
Review: Needs Fixing
It works great for the usual cases, e.g. if the name is an integer.
However, the following query raises a strange error:
{ { foo : bar} : foo }
[jerr:JNTY0004]: object items do not have typed value. This might be hard to
understand by users.
--
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/fix-1046415-2012-09-07T22-57-28.435Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Needs Fixing, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/fix-1046415 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge/123283
--
https://code.launchpad.net/~zorba-coders/zorba/fix-1046415/+merge
36 matches
Mail list logo
