Review: Disapprove
Good catch, but wrong solution. The item directory is necessary but somehow its
CMakeLists.txt is missing. I will propose a proper fix.
--
https://code.launchpad.net/~zorba-coders/zorba/fix_warning_cmake/+merge/185050
Your team Zorba Coders is subscribed to branch lp:zorba.
-
The proposal to merge lp:~zorba-coders/zorba/fix_warning_cmake into lp:zorba
has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/fix_warning_cmake/+merge/185050
--
https://code.launchpad.net/~zorba-coders/zorba/fix_warning
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/fix_warning_cmake/+merge/185050
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zo
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/fix_warning_cmake/+merge/185050 :
Votes: {'Pending': 2}
--
https://code.launchpad.net/~zorba-coders/zorba/fix_warning_cmake/+merge/185050
Your team Zorba Coders is subscribed to branch lp:zorb
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/fix_warning_cmake/+merge/185050
Stage "CommitZorba" failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/167/console to
view the results.
--
https://code.launchpad.net/~zorba-coders/zorba/fix_warning
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/fix_warning_cmake/+merge/185050
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/fix_warning_cmake/+merge/185050
Your te
Sorin Marian Nasoi has proposed merging
lp:~zorba-coders/zorba/fix_warning_cmake into lp:zorba.
Commit message:
fixed CMake warning (was spotted in CMake 2.8.1)
Requested reviews:
Chris Hillery (ceejatec)
Sorin Marian Nasoi (sorin.marian.nasoi)
For more details, see:
https://code.launchpad.
7 matches
Mail list logo