Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/temp-csx-schema-2012-04-26T20-17-19.67Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Validation queue job temp-csx-schema-2012-04-26T20-17-19.67Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba has
been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba has
been updated.
Description changed to:
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge
The proposal to merge lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba has
been updated.
Commit Message changed to:
Add zorba::Item::getTypeCode(), and make corresponding SchemaTypeCode enum part
of the public API. Add zorba::ItemFactory::assignElementTypedValue() to allow
construction
I've cleaned this up a bit, and IMHO it's ready to merge.
Markos, I've added you as a reviewer since we discussed these changes in email
a while ago (late February / early March, email subjects Zorba public API
problem and SchemaTypeCode). At the time, you said that you thought the
Review: Needs Information
Wouldn't it be better if the new functions in the ItemFactory (e.g.
assignElementTypedValue) would be members of Item?
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
IMHO, it's better on ItemFactory, although it doesn't really fit either place
very well. Putting it on ItemFactory at least makes it clearer that it should
be used while constructing a new tree, while you're making other ItemFactory
calls. I'd be afraid that putting it on Item would make it
Chris Hillery has proposed merging lp:~zorba-coders/zorba/temp-csx-schema into
lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
Chris Hillery (ceejatec)
Related bugs:
Bug #935666 in Zorba: Item types need to have their own class
The proposal to merge lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba has
been updated.
Commit Message changed to:
ignore for now
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx
Review: Needs Fixing
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema
The proposal to merge lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema
The proposal to merge lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba has
been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/temp-csx-schema-2012-03-06T01-56-13.404Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
Validation queue job temp-csx-schema-2012-03-06T01-56-13.404Z is finished. The
final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Needs Fixing, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/temp-csx-schema into lp:zorba has
been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema/+merge/96035
--
https://code.launchpad.net/~zorba-coders/zorba/temp-csx-schema
22 matches
Mail list logo
