Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/xqxq-url-resolver into
lp:zorba/xqxq-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue job xqxq-url-resolver-2012-10-19T08-27-45.258Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/xqxq-url-resolver into
lp:zorba/xqxq-module has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
--
https://code.launchpad.net/~zorba-coders/zorba/xqxq
Review: Approve
I initially saw some bad memory hits when I did a build of this branch as well,
but after merging the latest trunk and doing a clean build, it all looks good.
I do not see the memory leaks Sorin noted; I ran the url- tests with valgrind,
and the only memory leaks reported were
The proposal to merge lp:~zorba-coders/zorba/xqxq-url-resolver into
lp:zorba/xqxq-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/123604
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xqxq-url-resolver-2012-10-18T06-21-40.181Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/123604
Your team Zorba Coders is subscribed to branch
The attempt to merge lp:~zorba-coders/zorba/xqxq-url-resolver into
lp:zorba/xqxq-module failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job xqxq-url-resolver-2012-10-18T06-21-40.181Z
The proposal to merge lp:~zorba-coders/zorba/xqxq-url-resolver into
lp:zorba/xqxq-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/123604
--
https://code.launchpad.net/~zorba-coders/zorba
Whoops, right - this merge proposal won't pass until
https://code.launchpad.net/~zorba-coders/zorba/zorba-xqxq-url-resolver/+merge/123602
is merged. Ignore these test failures for now.
--
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/123604
Your team Zorba Coders is
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/123604
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
I don't feel comfortable with the QName solution. It would be great if HOFs
could be used for this. As far as I understood earlier discussions, this should
have been developed together with Nicolae. Using HOFs would also solve the
static context problem. Maybe the HOF
Chris Hillery has proposed merging lp:~zorba-coders/zorba/xqxq-url-resolver
into lp:zorba/xqxq-module.
Commit message:
Bug 903797: add feature to prepare-main-module() to enable URI mappers and URL
resolvers written in XQuery.
Requested reviews:
Chris Hillery (ceejatec)
Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/xqxq-url-resolver into
lp:zorba/xqxq-module has been updated.
Commit Message changed to:
Bug 903797: add feature to prepare-main-module() to enable URI mappers and URL
resolvers written in XQuery.
For more details, see:
https://code.launchpad.net
Review: Approve
Now using HOF!
--
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe
The proposal to merge lp:~zorba-coders/zorba/xqxq-url-resolver into
lp:zorba/xqxq-module has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/xqxq-url-resolver-2012-10-19T01-22-47.205Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
Your team Zorba Coders is subscribed to branch
Validation queue job xqxq-url-resolver-2012-10-19T01-22-47.205Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve, 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.
--
The proposal to merge lp:~zorba-coders/zorba/xqxq-url-resolver into
lp:zorba/xqxq-module has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
--
https://code.launchpad.net/~zorba-coders/zorba
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
There is a memory leak in the implementation.
To check simply run
ctest -R url-
and look into the build/Testing/Temporary/LastTest.log.
Here is what you will see:
test xqxq/url-schema-resolver
[...]
=== end of result ===
testdriver: success (non-canonical result # 1
Juan Zacarias has proposed merging lp:~zorba-coders/zorba/xqxq-url-resolver
into lp:zorba/xqxq-module.
Requested reviews:
Matthias Brantner (matthias-brantner)
Chris Hillery (ceejatec)
Related bugs:
Bug #903797 in Zorba: XQXQ feature request: custom schema uri resolver
23 matches
Mail list logo
